| commit | 976dffd7fc65f8c06c14887d9125be205cf1ecb6 | [log] [tgz] |
|---|---|---|
| author | Tom Bergan <tombergan@google.com> | Tue Jul 07 23:06:45 2020 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jul 07 23:06:45 2020 +0000 |
| tree | 262e050aaaddd331cf339531c80be04d18e72959 | |
| parent | 84751c22db64bfb45cbf00ae4d0c7f34d46be581 [diff] |
[audio_core][test] Refactor audio_core integration tests, step 2 The existing TestFixture methods ExpectCallback and ExpectError are useful shorthands but can produce difficult-to-diagnose error messages because they don't contain any context about the error. To address this difficulty, I've replaced the ErrorHandler() and CompletionCallback() methods with: * AddErrorHandler, which ties each error handler to a specific FIDL protocol object to help diagnose which protocol object failed * AddCallback, which is like the old CompletionCallback except that each callback is named. Additionally, multiple callbacks can be queued to test an expected sequence of calls (this simplifies a few tests). Most of the changes in this CL follow mechanically from the above changes. The exception is api/gain_control_test.cc, which was also dramatically simplified using a TYPED_TEST_SUITE. Bug: 50645 Multiply: audio-core-api-tests Change-Id: I8bd8d89000f6667ee8e9c5a77e7ab2911a9fabc5 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/401610 Commit-Queue: Tom Bergan <tombergan@google.com> Reviewed-by: Tim Detwiler <tjdetwiler@google.com> Testability-Review: Tim Detwiler <tjdetwiler@google.com>
Pink + Purple == Fuchsia (a new operating system)
Fuchsia is a modular, capability-based operating system. Fuchsia runs on modern 64-bit Intel and ARM processors.
Fuchsia is an open source project with a code of conduct that we expect everyone who interacts with the project to respect.
See Getting Started.
See fuchsia.dev.