tree 262e050aaaddd331cf339531c80be04d18e72959
parent 84751c22db64bfb45cbf00ae4d0c7f34d46be581
author Tom Bergan <tombergan@google.com> 1594163205 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1594163205 +0000

[audio_core][test] Refactor audio_core integration tests, step 2

The existing TestFixture methods ExpectCallback and ExpectError are
useful shorthands but can produce difficult-to-diagnose error messages
because they don't contain any context about the error. To address this
difficulty, I've replaced the ErrorHandler() and CompletionCallback()
methods with:

* AddErrorHandler, which ties each error handler to a specific FIDL
  protocol object to help diagnose which protocol object failed

* AddCallback, which is like the old CompletionCallback except that
  each callback is named. Additionally, multiple callbacks can be queued
  to test an expected sequence of calls (this simplifies a few tests).

Most of the changes in this CL follow mechanically from the above
changes. The exception is api/gain_control_test.cc, which was also
dramatically simplified using a TYPED_TEST_SUITE.

Bug: 50645
Multiply: audio-core-api-tests
Change-Id: I8bd8d89000f6667ee8e9c5a77e7ab2911a9fabc5
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/401610
Commit-Queue: Tom Bergan <tombergan@google.com>
Reviewed-by: Tim Detwiler <tjdetwiler@google.com>
Testability-Review: Tim Detwiler <tjdetwiler@google.com>