Google Git
Sign in
fuchsia / third_party / webkit / 2c4a8028578da85b15ae2cdcfde1271a99a7e1d0 / . / Tools / ChangeLog-2015-11-21
blob: da108a1b17abfe1ce90e09335f9a37d5af06f6fc [file] [log] [blame]
2015-11-20 Said Abou-Hallawa <sabouhallawa@apple.com>
Unreviewed, add watchlist for PerformanceTests/Animometer and add myself.
* Scripts/webkitpy/common/config/watchlist:
2015-11-20 Alexey Proskuryakov <ap@apple.com>
Went a bit too far, revert part of the previous patch.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2015-11-20 Alexey Proskuryakov <ap@apple.com>
Remove Mavericks bots.
Rubber-stamped by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
* Scripts/copy-webkitlibraries-to-product-directory:
2015-11-20 Said Abou-Hallawa <sabouhallawa@apple.com>
Update the patch and the plan files of the graphics benchmark with the latest revision
https://bugs.webkit.org/show_bug.cgi?id=151503
Reviewed by Ryosuke Niwa.
The time for each graphics test has been shortened from 30 seconds to 10
seconds. We need to update the graphics benchmark patch and plan files so
we can get the results faster. Also this will allow running the benchmark
also on the iOS performance bots.
* Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
* Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
2015-11-20 Michael Catanzaro <mcatanzaro@igalia.com>
Unreviewed, fix installation of ninja-build after the previous commit
* gtk/install-dependencies:
2015-11-20 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] install-dependencies should run installer exactly once
https://bugs.webkit.org/show_bug.cgi?id=151477
Reviewed by Carlos Garcia Campos.
* gtk/install-dependencies:
2015-11-20 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Enable FTL JIT by default on X86_64
https://bugs.webkit.org/show_bug.cgi?id=143822
Reviewed by Carlos Garcia Campos.
* Scripts/build-jsc:
* Scripts/run-javascriptcore-tests:
* Scripts/webkitperl/FeatureList.pm:
* efl/jhbuild.modules:
* gtk/jhbuildrc:
* jhbuild/jhbuildrc_common.py:
(init):
2015-11-19 Michael Catanzaro <mcatanzaro@igalia.com>
Unreviewed, install llvm-static on Fedora to fix build now FTL is enabled
* gtk/install-dependencies:
2015-11-19 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r192667 and r192668.
https://bugs.webkit.org/show_bug.cgi?id=151476
broke api tests (Requested by alexchristensen on #webkit).
Reverted changesets:
"Remove the non-NetworkProcess configurations"
https://bugs.webkit.org/show_bug.cgi?id=151418
http://trac.webkit.org/changeset/192667
"Fix GTK Build after r192667."
http://trac.webkit.org/changeset/192668
2015-11-19 Alex Christensen <achristensen@webkit.org>
Remove the non-NetworkProcess configurations
https://bugs.webkit.org/show_bug.cgi?id=151418
Reviewed by Geoffrey Garen.
* TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
(TestWebKitAPI::TEST):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::generatePageConfiguration):
2015-11-19 Alexey Proskuryakov <ap@apple.com>
LayoutTestRelay processes leak on iOS testers
https://bugs.webkit.org/show_bug.cgi?id=151447
Reviewed by Tim Horton.
* BuildSlaveSupport/kill-old-processes: Added LayoutTestRelay.
2015-11-19 Brent Fulgham <bfulgham@apple.com>
[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
https://bugs.webkit.org/show_bug.cgi?id=151156
Unreviewed test fix.
I tracked down the cause of the test regression on the Windows builders. Once I fixed that,
I realized that the new 'abs_results_directory' value was not needed, so this change reverts
that code.
* Scripts/webkitpy/port/base.py:
(Port.to.start_websocket_server): We don't need a special directory variable on Cygwin anymore.
(Port.abs_results_directory): Deleted.
* Scripts/webkitpy/port/win.py:
(WinPort.__init__): Deleted.
(WinPort.abs_results_directory): Deleted.
(WinPort.results_directory): Deleted.
2015-11-19 Alexey Proskuryakov <ap@apple.com>
build.webkit.org/dashboard: Move layoutTestResultsDirectoryURLForIteration implementation to base class
https://bugs.webkit.org/show_bug.cgi?id=151425
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestResultsDirectoryURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Deleted.
2015-11-19 Youenn Fablet <youenn.fablet@crf.canon.fr>
WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
https://bugs.webkit.org/show_bug.cgi?id=150332
Reviewed by Darin Adler and Ryosuke Niwa.
Removing testharness.js overwriting from LayoutTests/resources to LayoutTests/imported/w3c/web-platform-tests/resources.
Adding support for file comparison in python filesystem.
#NousSommesUnis.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.compare): Adding compare as a wrapper around filecmp.cmp.
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.compare): Adding a mock compare.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
(WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
(TestWebPlatformTestServer.test_previously_spawned_instance): Updated tests to add testharness.js to mock filesystem.
(TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2015-11-18 Jiewen Tan <jiewen_tan@apple.com>
[WK1] Crash loading Blink layout test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
https://bugs.webkit.org/show_bug.cgi?id=150198
<rdar://problem/23136026>
Reviewed by Brent Fulgham.
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::inspectorTestStubURL):
Since WebInspectorUI.framework is not available for iOS, the framework
and corresponding functions are disabled in iOS.
2015-11-18 Alexey Proskuryakov <ap@apple.com>
[Mac] Swipe tests depend on user preferences
https://bugs.webkit.org/show_bug.cgi?id=151403
Reviewed by Tim Horton.
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Override these preferences to match the default for a new OS X installation.
* DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
Swipe tests are not enabled in WK1, but let's override the default anyway.
2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Update xserver version in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=151383
Reviewed by Alejandro G. Castro.
In r192568 I assumed the bots would have a recent enough Xvfb
to use the -displayfd option, but I forgot we build our own
xserver just for Xvfb. The version we build is too old, so
we could just use an updated version (the same bots have
installed, for example) to use the -displayfd option.
* gtk/jhbuild.modules: Update xserver to 1.16.4.
* gtk/patches/xserver-fix-glx-init.patch: Deleted.
* gtk/patches/xserver-remove-bogus-dependencies.patch: Updated to
apply on 1.16.4.
2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix webkitpy tests after r192568.
Instead of ignoring exception when closing mock fds, use a helper
function that the unit test can override to do nothing.
* Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_close_pipe):
(XvfbDriver._xvfb_run):
* Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
[XvfbDriver] Fail to run all layout tests when X server started with -displayfd option
https://bugs.webkit.org/show_bug.cgi?id=151135
Reviewed by Darin Adler.
The XvfbDriver uses the x server command line to check the
displays that are currently in use. This doesn't work when X
server was started with -displayfd option. This option is used to let
the server find the display id available that is written to the
given file descriptor. With this option xorg doesn't need to
create the lock files in tmp either. The -displayfd option is also
available in Xvfb, so we could use it too. That would simplify the
code, fixing also race conditions between the check for available
displays and Xvfb opening the connection, we wouldn't need to wait
for 4 seconds after launching Xvfb, and all lock files we are
using won't be needed either.
* Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_pipe): Helper function to create the pipe, only
needed to be overriden by unit tests.
(XvfbDriver._xvfb_read_display_id): Helper function to read from
the pipe, only needed to be overriden by unit tests.
(XvfbDriver._xvfb_run): Run Xvfb with -displayfd option, using a
pipe to read the display id.
(XvfbDriver._start): Call _xvfb_run() and remove the code to run
Xvfb for a given display.
(XvfbDriver.stop): Remove code to release and delete file locks.
* Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.assertDriverStartSuccessful): Deleted.
(XvfbDriverTest): Deleted.
(XvfbDriverTest.test_stop.FakeXvfbProcess): Deleted.
2015-11-17 Alexey Proskuryakov <ap@apple.com>
run-webkit-tests should not truncate persistent lines
https://bugs.webkit.org/show_bug.cgi?id=151376
rdar://problem/23162775
Reviewed by Antti Koivisto.
It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
unexpected result) messages that remain on the screen to be read. In practice, this
almost always truncates the test path, which is important to see.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line):
(Printer.print_finished_test):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_test_status_line):
2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ unit tests after r192469.
In r192469 jhbuild version was updated and coinfig lcas API changed.
* jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available): Pass an empty list for
conditions to the Config constructor.
2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Use commit id instead of tag name for jhbuild revision.
In r192469 I updated the jhbuild version to 3.12.0, and used the
tag instead of the commit id to make it easier to read and
remember. But we use the commit id to check if the current
revision is up to date, and when compared to the tag id it always
fails and jhbuild is always updated.
* jhbuild/jhbuild-wrapper: Use commit id and add a comment to
remember this is the id of 3.12.0.
2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ layout tests running after r192469.
We fail to find the Gallium llvmpipe driver because of the build
directory change in r192469.
* gtk/jhbuildrc: Use buildroot instead of checkoutdir to build
the LLVMPIPE_LIBGL_PATH.
2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Use FTL by default when LLVM 3.7 is available
https://bugs.webkit.org/show_bug.cgi?id=142128
Reviewed by Csaba Osztrogonác.
* Scripts/run-javascriptcore-tests: Enable FTL for GTK+ port when
architecture is x86_64.
* Scripts/update-webkit-libs-jhbuild:
(cleanJhbuild): Remove also the separate Build directory used by
GTK+ port now.
* Scripts/webkitdirs.pm:
(isX86_64):
* Scripts/webkitperl/FeatureList.pm: Enable FTL by default for
GTK+ port when architecture is x86_64.
* gtk/jhbuild-optional.modules: Remove llvm.
* gtk/jhbuild.modules: Add llvm 3.7 and include it as dependecy
only when architecture is x86_64.
* gtk/jhbuildrc: Set a buildroot to use a separate build
directory. LLVM 3.7 fails to build if configure script is run from
source dir. Since it's not possible to use a separate build dir
only for llvm, we do it now globally. Modules not supporting non
source build dirs are marked in the moduleset. Also set x86_64
condition when the architecture is x86_64.
* gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
* gtk/patches/llvm-elf-add-stackmaps.patch: Removed.
* gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
* gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed.
* jhbuild/jhbuild-wrapper: Use a newer jhbuild version to be able
to use conditions.
2015-11-15 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r192462.
https://bugs.webkit.org/show_bug.cgi?id=151295
failing python tests (Requested by youenn on #webkit).
Reverted changeset:
"WPT server should use its own testharness.js file and
generate a warning when it does not match WebKit version"
https://bugs.webkit.org/show_bug.cgi?id=150332
http://trac.webkit.org/changeset/192462
2015-11-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
https://bugs.webkit.org/show_bug.cgi?id=150332
Reviewed by Darin Adler.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
(WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
2015-11-14 Nan Wang <n_wang@apple.com>
AX: add a new trait for elements in fieldset on iOS
https://bugs.webkit.org/show_bug.cgi?id=151281
Reviewed by Chris Fleizach.
* DumpRenderTree/AccessibilityUIElement.cpp:
(assistiveTechnologySimulatedFocusCallback):
(fieldsetAncestorElementCallback):
(childAtIndexCallback):
(getElementTextLengthCallback):
(hasContainedByFieldsetTraitCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::elementTextLength):
(AccessibilityUIElement::hasContainedByFieldsetTrait):
(AccessibilityUIElement::fieldsetAncestorElement):
(AccessibilityUIElement::url):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::identifier):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
(WTR::AccessibilityUIElement::rowCount):
2015-11-13 Keith Miller <keith_miller@apple.com>
Unreviewed, change JavaScriptCore watchlist to exclude inspector things.
* Scripts/webkitpy/common/config/watchlist:
2015-11-13 Tim Horton <timothy_horton@apple.com>
Support printing in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=151276
<rdar://problem/23525715>
Reviewed by Beth Dakin.
* MiniBrowser/mac/MainMenu.xib:
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController printWebView:]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController printWebView:]):
Hook up printing to Minibrowser!
2015-11-13 Tim Horton <timothy_horton@apple.com>
Hardware keyboard spacebar scrolls too far on iOS
https://bugs.webkit.org/show_bug.cgi?id=151227
<rdar://problem/23500681>
Reviewed by Simon Fraser.
* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
* WebKitTestRunner/UIScriptContext/UIScriptContext.h:
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didFinishScrolling]):
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::platformSetDidEndScrollingCallback):
(WTR::UIScriptController::platformClearAllCallbacks):
Expose _didFinishScrolling on WKWebView to the UIScriptController.
2015-11-13 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed test fix.
* Scripts/webkitpy/port/win.py:
(WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
using Cygwin), but should be in DOS format for non-Cygwin clients.
2015-11-12 Daniel Bates <dabates@apple.com>
Add my apple.com email address to contributors.json
* Scripts/webkitpy/common/config/contributors.json:
2015-11-12 Daniel Bates <dabates@apple.com>
webkitpy: Remove extraneous word "the" from the description of command attach-to-bug
* Scripts/webkitpy/tool/commands/upload.py:
(AttachToBug):
2015-11-12 Brent Fulgham <bfulgham@apple.com>
[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
https://bugs.webkit.org/show_bug.cgi?id=151156
Reviewed by Anders Carlsson.
My earlier patch was incomplete. There are some Python libraries that want
to receive UNIX style paths, even though all of our applications and tools
use DOS paths. To handle this special case, we need to track a UNIX-style
absolute path that can be given to things like the Python socket server.
When we cut over to all-native Windows Python we can get rid of this
special case code.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
path into something Cygwin can use internally.
* Scripts/webkitpy/port/base.py:
(Port.results_directory): Remove custom Windows code. Instead, override
the method in the windows port object.
(Port.abs_results_directory): Add stub.
(Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
path.
* Scripts/webkitpy/port/win.py:
(WinPort.__init__): Added to initialze new _abs_results_directory value.
(WinPort.abs_results_directory): Added,
(WinPort.results_directory): Modified to also create a value for
_abs_results_directory
2015-11-12 Keith Miller <keith_miller@apple.com>
Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.
* Scripts/webkitpy/common/config/watchlist:
2015-11-12 Keith Miller <keith_miller@apple.com>
Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.
* Scripts/webkitpy/common/config/watchlist:
2015-11-12 Daniel Bates <dabates@apple.com>
Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
https://bugs.webkit.org/show_bug.cgi?id=151191
Reviewed by Andy Estes.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.
Will override this setting in DumpRenderTree.xcconfig.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now
compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
and skip installation when building for iOS since we are not interested in the build product
and are only building this target to make the Apple Internal build system happy.
* DumpRenderTree/mac/DumpRenderTreeMain.mm:
(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.
* WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
* WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm
on iOS Only to produce a built product and make the Apple Internal build system happy. No need
to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.
* WebKitTestRunner/mac/main.mm:
(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.
2015-11-12 Chris Dumez <cdumez@apple.com>
Unreviewed, add watchlist for history/ and add myself.
* Scripts/webkitpy/common/config/watchlist:
2015-11-12 Chris Dumez <cdumez@apple.com>
Unreviewed, update my watchlists.
* Scripts/webkitpy/common/config/watchlist:
2015-11-12 Daniel Bates <dabates@apple.com>
Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
https://bugs.webkit.org/show_bug.cgi?id=151207
Rubber-stamped by Alexey Proskuryakov.
The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.
* Scripts/build-jsc:
* Scripts/build-layouttestrelay:
* Scripts/build-webkit:
* Scripts/copy-webkitlibraries-to-product-directory:
* Scripts/run-api-tests:
(runTest):
(prepareEnvironmentForRunningTestTool):
* Scripts/run-javascriptcore-tests:
* Scripts/webkitdirs.pm:
(XcodeOptions):
(willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
(willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
(isIOSWebKit):
(runIOSWebKitApp):
(willUseIOSDeviceSDKWhenBuilding): Deleted.
(willUseIOSSimulatorSDKWhenBuilding): Deleted.
2015-11-12 Daniel Bates <dabates@apple.com>
run-api-tests fails to run with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=151076
Reviewed by Alexey Proskuryakov.
Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.
A side benefit of this change it is sufficient to run the tests without launching Simulator.app
to boot the simulator device beforehand because simctl will boot the device for us.
Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
This makes Control-C terminate the app gracefully.
* Scripts/run-api-tests:
(runTest):
(listAllTests):
(prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
variables in the simulator environment.
* Scripts/webkitdirs.pm:
(shutDownIOSSimulatorDevice): Added.
(restartIOSSimulatorDevice): Added.
2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
[EFL] fix EvasGL configuration error
https://bugs.webkit.org/show_bug.cgi?id=151180
Reviewed by Csaba Osztrogonác.
EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
Additionally, duplicated elm_config_accel_preference_set() call is eleminated.
* MiniBrowser/efl/main.c:
(window_create):
(elm_main):
2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Fix EFL 1.16 with enabled NEON support
https://bugs.webkit.org/show_bug.cgi?id=151188
Unreviewed buildfix, disable NEON temporarily after r192358.
* efl/jhbuild.modules:
2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Bump EFL version to 1.16.0
https://bugs.webkit.org/show_bug.cgi?id=150228
Reviewed by Gyuyoung Kim.
* efl/jhbuild.modules:
* efl/patches/efl-remove-XPrint.patch: Removed.
2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
https://bugs.webkit.org/show_bug.cgi?id=150972
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
[EFL] fix EvasGL configuration error
https://bugs.webkit.org/show_bug.cgi?id=151180
Reviewed by Gyuyoung Kim.
EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet
* MiniBrowser/efl/main.c:
(window_create):
2015-11-11 Brent Fulgham <bfulgham@apple.com>
[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
https://bugs.webkit.org/show_bug.cgi?id=151156
Reviewed by Anders Carlsson.
* Scripts/webkitpy/port/base.py:
(Port.results_directory): Don't pass paths through 'abspath'
(Port._build_path): Ditto.
* Scripts/webkitpy/port/win.py:
(WinPort._build_path): Ditto.
2015-11-11 Akos Kiss <akiss@inf.u-szeged.hu>
Unreviewed, add myself to the committers list.
* Scripts/webkitpy/common/config/contributors.json:
2015-11-11 Anders Carlsson <andersca@apple.com>
_WKRemoteObjectInterface should handle specifying allowed classes for reply block arguments
https://bugs.webkit.org/show_bug.cgi?id=151144
Reviewed by Tim Horton.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
(remoteObjectInterface):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[RemoteObjectRegistryPlugIn selectionAndClickInformationForClickAtPoint:completionHandler:]):
2015-11-10 Wenson Hsieh <wenson_hsieh@apple.com>
UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing
https://bugs.webkit.org/show_bug.cgi?id=151101
<rdar://problem/23428601>
Reviewed by Simon Fraser.
WebKitTestRunner may still crash in the scenario where a marker event is dequeued and handled
after uiScriptComplete has been called. This patch teaches the UI script execution context to
defer script completion until all non-persistent tasks (currently tap, double tap and hardware
keyboard) have been handled, so marker events will no longer bleed through tests.
We accomplish this by changing the behavior of uiScriptComplete. When calling uiScriptComplete,
we store that a request to complete the UI-side script for the current parent callback has been
made. Subsequently, when a callback (either persistent or non-persistent) finishes invoking and
a request has been made to complete the UI script (this request may have been made when running
a previous callback) we check if all the non-persistent callbacks that have the same parent
callback as the current one have finished. If so, we complete the callback immediately;
otherwise, we wait until the in-flight non-persistent callbacks finish execution to complete the
UI script.
This patch also refactors some logic in UIScriptContext. It introduces a new convention for
assigning IDs to callbacks: IDs 1000 and above are treated as non-persistent callbacks, whereas
IDs between 0 and 999 are persistent task callbacks. This is similar to the existing convention
for assigning IDs in the 100s range to parent callbacks, and allows us to easily differentiate
between callbacks that are persistent and non-persistent, as well as determine when an existing
persistent callback must be unregistered before a new callback function can be set.
* WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(isPersistentCallbackID):
(UIScriptContext::runUIScript):
(UIScriptContext::nextTaskCallbackID):
(UIScriptContext::prepareForAsyncTask):
(UIScriptContext::asyncTaskComplete):
(UIScriptContext::registerCallback):
(UIScriptContext::fireCallback):
(UIScriptContext::requestUIScriptCompletion):
(UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
(UIScriptContext::currentParentCallbackHasOutstandingAsyncTasks):
(UIScriptContext::uiScriptComplete): Deleted.
* WebKitTestRunner/UIScriptContext/UIScriptContext.h:
(WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setWillBeginZoomingCallback):
(WTR::UIScriptController::willBeginZoomingCallback):
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::uiScriptComplete):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::zoomToScale):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
(WTR::UIScriptController::platformClearAllCallbacks): Deleted.
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::doAsyncTask):
2015-11-10 Daniel Bates <dabates@apple.com>
Teach Makefile to build LayoutTestRelay when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=150849
Reviewed by Alexey Proskuryakov.
Unless variable DO_NOT_BUILD_LAYOUT_TEST_RELAY is non-empty, build LayoutTestRelay when
building WebKit tools.
* Makefile:
2015-11-10 David Kilzer <ddkilzer@apple.com>
[check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
<http://webkit.org/b/104417>
Reviewed by Brent Fulgham.
* Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.process_clean_line): Allow 'k' to start enums.
(check_enum_casing): Update error message to discuss 'k'.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest.test_enum_casing): Update error
messages, and add new tests for enums that start with lowercase
letters.
2015-11-10 Geoffrey Garen <ggaren@apple.com>
run-jsc-benchmarks doesn't work with internal benchmarks
https://bugs.webkit.org/show_bug.cgi?id=151047
Reviewed by Filip Pizlo.
* Scripts/run-jsc-benchmarks: Use Pathname so we get a "/" inserted when
we concatenate.
2015-11-10 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Use CROSS_PLATFORM_CONTEXT_MENUS
https://bugs.webkit.org/show_bug.cgi?id=150642
Reviewed by Martin Robinson.
Remove test for input methods submenu.
* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2015-11-09 Joonghun Park <jh718.park@samsung.com>
Unreviewed, add myself to the committers list.
* Scripts/webkitpy/common/config/contributors.json:
2015-11-09 Ryuan Choi <ryuan.choi@navercorp.com>
[EFL] Crash while opening child webview with EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
https://bugs.webkit.org/show_bug.cgi?id=145924
Reviewed by Gyuyoung Kim.
* MiniBrowser/efl/main.c:
(on_window_create):
(window_create):
* TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
2015-11-09 Anders Carlsson <andersca@apple.com>
Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
https://bugs.webkit.org/show_bug.cgi?id=151056
rdar://problem/23222609
Reviewed by Tim Horton.
Update test.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
2015-11-09 Tim Horton <timothy_horton@apple.com>
Add drawsBackground SPI to WKWebView, and get rid of drawsTransparentBackground from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=151054
<rdar://problem/22907994>
Reviewed by Simon Fraser.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):
Use drawsBackground instead, and make sure to set the window background color,
otherwise it might end up being gray anyway!
WebKit1 still doesn't work unless you turn off toolbar blurring, but at least
WebKit2 is working now!
2015-11-09 Isaac Devine <isaac@devinesystems.co.nz>
Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
https://bugs.webkit.org/show_bug.cgi?id=151013
Use the variable defined in the CMake scripts to determine the cairo include location, rather
than relying on a environment variable to be set correctly. Otherwise the DumpRenderTreeLib.vcxproj will
contain "\include\cairo" rather than the fully qualified path to the cairo include location.
Reviewed by Darin Adler.
* DumpRenderTree/PlatformWin.cmake:
2015-11-09 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Fix the gst-plugins-bad jhbuild module build on Ubuntu 15.10
https://bugs.webkit.org/show_bug.cgi?id=150928
Reviewed by Gyuyoung Kim.
* efl/jhbuild.modules:
2015-11-07 Daniel Bates <dabates@apple.com>
Attempt to fix the Windows EWS bot after r192087
(https://bugs.webkit.org/show_bug.cgi?id=150859)
Following r192087 Port._build_path() stores the computed root directory path in option
_cached_root instead of overwriting option root. We need to teach the Windows-specific
logic to make use of option _cached_root instead of option root when computing its adjusted
path and to cache its adjusted in _cached_root instead of root.
* Scripts/webkitpy/port/win.py:
(WinPort._build_path):
2015-11-06 Daniel Bates <dabates@apple.com>
Do not build LayoutTestRelay when --root is specified to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=150989
Reviewed by Alexey Proskuryakov.
The script run-webkit-tests should only check if LayoutTestRelay exists when invoked with
--root and exit with an error if it does not exist. That is, we should not build LayoutTestRelay
when it does not exist and an explicit directory of built executables was specified via --root.
This will make the criterion for building LayoutTestRelay match the criterion for building
DumpRenderTree/WebKitTestRunner.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._check_port_build): Moved logic from IOSSimulatorPort.{_check_build_relay, check_build} to here.
(IOSSimulatorPort._check_build_relay): Deleted.
(IOSSimulatorPort.check_build): Deleted.
2015-11-06 Tim Horton <timothy_horton@apple.com>
Add preliminary (SPI) support for NSTextFinder on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=150907
<rdar://problem/19171624>
Reviewed by Darin Adler.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Added.
(-[FindInPageNavigationDelegate webView:didFinishNavigation:]):
(TEST):
Add an API test.
* WebEditingTester/WK1WebDocumentController.m:
* WebEditingTester/WK2WebDocumentController.m:
(-[WK2WebDocumentController awakeFromNib]):
(-[WK2WebDocumentController contentView]):
Use incremental find, and show the overlay/indicator.
2015-11-06 Alexey Proskuryakov <ap@apple.com>
iOS test results are not visible on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=150884
Reviewed by Darin Adler.
One more change was needed for the minimal fix.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
2015-11-06 Daniel Bates <dabates@apple.com>
Teach Makefile to build LayoutTestRelay when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=150849
Reviewed by Alexey Proskuryakov.
Override the user-specified arguments SDKROOT and ARCHS to use the default SDK
and default ARCHS since LayoutTestRelay is a Mac command line tool.
* LayoutTestRelay/Makefile: Define OVERRIDE_SDKROOT and OVERRIDE_ARCHS.
2015-11-05 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
Add runtime and compile time flags for enabling Web Animations API and model.
https://bugs.webkit.org/show_bug.cgi?id=150914
Reviewed by Benjamin Poulain.
Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag.
* Scripts/webkitperl/FeatureList.pm:
2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
[EFL] Separate beforeunload confirm callback from confirm callback
https://bugs.webkit.org/show_bug.cgi?id=150964
Reviewed by Gyuyoung Kim.
* MiniBrowser/efl/main.c:
(on_javascript_before_unload_confirm):
(window_create):
2015-11-05 Jason Marcell <jmarcell@apple.com>
run-webkit-test should look in --root directory for LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=150859
Reviewed by Daniel Bates.
For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
LayoutTestRelay in the Mac build directory when --root is unspecified.
* Scripts/webkitpy/port/base.py:
(Port._build_path): Use '_cached_root' instead of 'root' so that we don't overwrite the
argument that was passed in via the --root argument.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.relay_path):
2015-11-05 David Kilzer <ddkilzer@apple.com>
TestWebKitAPI crashed in TestWebKitAPI: TestWebKitAPI::SharedBufferTest_copyBufferCreatedWithContentsOfExistingFile_Test::TestBody
<http://webkit.org/b/150931>
<rdar://problem/23409384>
Reviewed by Youenn Fablet.
* TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::TEST_F(SharedBufferTest, copyBufferCreatedWithContentsOfExistingFile)):
- Switch from strnstr() to memcmp() since strings are
not guaranteed to be NULL-terminated.
- Add another expectation that the size is greater than
zero since memcmp() returns 0 (matching) if the length
argument is zero.
(TestWebKitAPI::TEST_F(SharedBufferTest, appendBufferCreatedWithContentsOfExistingFile)):
- Same change to keep tests consistent, although the
second string is NULL-terminated in this case.
2015-11-05 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r192073.
https://bugs.webkit.org/show_bug.cgi?id=150962
"Broke the internal iOS build; will investigate offline"
(Requested by dydz on #webkit).
Reverted changeset:
"Teach Makefile to build LayoutTestRelay when building for iOS
Simulator"
https://bugs.webkit.org/show_bug.cgi?id=150849
http://trac.webkit.org/changeset/192073
2015-11-05 Daniel Bates <dabates@apple.com>
Teach Makefile to build LayoutTestRelay when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=150849
Reviewed by Alexey Proskuryakov.
* LayoutTestRelay/Makefile: Temporarily override SDKROOT when it is iphonesimulator so
that we build with the default SDK. We assume that the default SDK is the OS X SDK.
* Makefile: Append LayoutTestRelay to the list of modules to build when building with
SDK iphonesimulator.
2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
[EFL] Add try_close API to handle beforeunload event
https://bugs.webkit.org/show_bug.cgi?id=150705
Reviewed by Gyuyoung Kim.
* MiniBrowser/efl/main.c:
(on_window_deletion):
Call ewk_view_try_close instead of removing object directly.
(window_create): Fixed that passes wrong data.
2015-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
Fix crashing and flaky UIScriptController-based tests in fast/events/ios
https://bugs.webkit.org/show_bug.cgi?id=150901
<rdar://problem/23261499>
Reviewed by Simon Fraser.
Clear out zooming and keyboard-related callbacks after uiScriptComplete has been invoked. This prevents
later tests from calling into code which previous tests attached to these callbacks and causing
WebKitTestRunner to crash due to accessing a deallocated UIScriptController.
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::platformClearAllCallbacks):
(WTR::UIScriptController::uiScriptComplete):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::platformClearAllCallbacks):
2015-11-04 Jer Noble <jer.noble@apple.com>
[iOS] <video> elements without audio tracks should not interrupt music
https://bugs.webkit.org/show_bug.cgi?id=149888
Reviewed by Eric Carlson.
Add tests to ensure that the AVAudioSession category is correctly set when playing
back media both with and without audio tracks.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Added.
(-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Added.
* TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Added.
* TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Added.
* TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Added.
2015-11-04 Alexey Proskuryakov <ap@apple.com>
iOS test results are not visible on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=150884
Reviewed by Darin Adler.
Re-generated builders.jsonp using generate_builders_json.py.
I think that this is all that's needed for basic support. There is more work needed
to display test expectations, but that's already mostly broken even for Mac.
* TestResultServer/static-dashboards/builders.jsonp:
2015-11-03 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r191995.
https://bugs.webkit.org/show_bug.cgi?id=150880
Broke iOS tests (Requested by ap on #webkit).
Reverted changeset:
"run-webkit-test should look in --root directory for
LayoutTestRelay"
https://bugs.webkit.org/show_bug.cgi?id=150859
http://trac.webkit.org/changeset/191995
2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
Add graphics benchmark to performance bot
https://bugs.webkit.org/show_bug.cgi?id=150450
Reviewed by Chris Dumez.
* Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
* Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
Add a patch and a plan to set the defaults of the benchmark, run it,
collect the result and report it to the benchmark runner.
2015-11-03 Jason Marcell <jmarcell@apple.com>
run-webkit-test should look in --root directory for LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=150859
Reviewed by Daniel Bates.
For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
LayoutTestRelay in the Mac build directory when --root is unspecified.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.relay_path):
2015-11-03 Alexey Proskuryakov <ap@apple.com>
build.webkit.org/dashboard should use ISO dates in Trac URLs
https://bugs.webkit.org/show_bug.cgi?id=150855
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._xmlTimelineURL):
2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
Unreviewed, add myself to the SVG watchlist.
* Scripts/webkitpy/common/config/watchlist:
2015-11-03 Wenson Hsieh <wenson_hsieh@apple.com>
Fix touch event sending crash in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=150848
<rdar://problem/23360841>
Reviewed by Simon Fraser.
Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
2015-11-03 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed build fix after r191958.
* MiniBrowser/win/MiniBrowser.h: Add missing include.
* MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
2015-11-02 Jiewen Tan <jiewen_tan@apple.com>
Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
* Scripts/webkitpy/common/config/contributors.json:
2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, add unittest after r191827.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2015-11-02 Andy Estes <aestes@apple.com>
[Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
https://bugs.webkit.org/show_bug.cgi?id=150819
Reviewed by Dan Bernstein.
This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
2015-11-02 Anders Carlsson <andersca@apple.com>
Begin work on supporting reply blocks in _WKRemoteObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150739
Reviewed by Tim Horton.
Add a test. We only test the encoding right now.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
2015-11-02 Tim Horton <timothy_horton@apple.com>
Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Anders Carlsson.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
Revert some parts of r188828 which no longer apply.
2015-10-30 Dana Burkart <dburkart@apple.com>
svn-apply should handle unified diffs
https://bugs.webkit.org/show_bug.cgi?id=150650
Reviewed by Darin Adler.
* Scripts/VCSUtils.pm:
(parseUnifiedDiffHeader):
This method parses a unified diff header, and returns a information in the
style of parseGitDiffHeader and parseSvnDiffHeader.
(parseDiffHeader):
Teach parseDiffHeader to recognize unified diff headers.
(parseDiff):
Teach parseDiff to recognize unified diffs.
* Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
* Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
Fix the FTL JIT build with system LLVM on Linux
https://bugs.webkit.org/show_bug.cgi?id=150795
Reviewed by Filip Pizlo.
* efl/install-dependencies:
* gtk/install-dependencies:
2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Bump harfbuzz versions to 0.9.35
https://bugs.webkit.org/show_bug.cgi?id=150448
Reviewed by Gyuyoung Kim.
* efl/jhbuild.modules:
2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
[EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
https://bugs.webkit.org/show_bug.cgi?id=150622
Reviewed by Gyuyoung Kim.
* efl/install-dependencies:
* efl/jhbuild.modules:
2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
Fix EFL jhbuild module build on Ubuntu 15.10
https://bugs.webkit.org/show_bug.cgi?id=150621
Reviewed by Gyuyoung Kim.
* efl/jhbuild.modules:
* efl/patches/efl-remove-XPrint.patch: Added.
2015-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
[GLIB] Remove delete on destroy GMainLoopSources
https://bugs.webkit.org/show_bug.cgi?id=150771
Reviewed by Žan Doberšek.
* TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
(TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
2015-11-01 Yusuke Suzuki <utatane.tea@gmail.com>
[ES6] Support Generator Syntax
https://bugs.webkit.org/show_bug.cgi?id=150769
Reviewed by Geoffrey Garen.
Added ENABLE_ES6_GENERATORS flag.
* Scripts/webkitperl/FeatureList.pm:
2015-11-01 Alexey Proskuryakov <ap@apple.com>
Sort EWS bots in popovers
https://bugs.webkit.org/show_bug.cgi?id=150782
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
(BubbleQueueView.prototype._popoverContentForBubbleQueue):
2015-10-31 Filip Pizlo <fpizlo@apple.com>
B3::reduceStrength's DCE should be more agro and less wrong
https://bugs.webkit.org/show_bug.cgi?id=150748
Reviewed by Geoffrey Garen.
Add an LLVM version of testb3's "testComplex".
* ReducedFTL/ComplexTest.cpp: Added.
2015-11-01 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r191831.
https://bugs.webkit.org/show_bug.cgi?id=150774
The new test fails (Requested by ap on #webkit).
Reverted changeset:
"Begin work on supporting reply blocks in
_WKRemoteObjectRegistry"
https://bugs.webkit.org/show_bug.cgi?id=150739
http://trac.webkit.org/changeset/191831
2015-10-31 Andreas Kling <akling@apple.com>
Add a debug overlay with information about web process resource usage.
<https://webkit.org/b/150599>
Reviewed by Darin Adler.
Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleShowResourceUsageOverlay:]):
(-[SettingsController resourceUsageOverlayVisible]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):
2015-10-31 Lucas Forschler <lforschler@apple.com>
Teach the CompileWebKit step to look for additional arguments.
Unreviewed config change.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
2015-10-30 Anders Carlsson <andersca@apple.com>
Begin work on supporting reply blocks in _WKRemoteObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150739
Reviewed by Tim Horton.
Add a test. We only test the encoding right now.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
2015-10-30 Lucas Forschler <lforschler@apple.com>
Add CMAke builder to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=150738
Reviewed by Alex Christensen.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2015-10-30 Brent Fulgham <bfulgham@apple.com>
[Win] build-jsc and run-javascriptcore-tests do not work
https://bugs.webkit.org/show_bug.cgi?id=150700
Reviewed by Mark Lam.
Correct our build system so that it expects Windows to be using CMake,
and to build the correct sub-projects for our JSC helper scripts.
* Scripts/build-jsc: Make sure to build the testapi harness when
building for Windows.
* Scripts/build-webkit:
(1) Use the existing 'cmakeBasedPortName()'
(2) Use File::Spec rather than hard-coding path delimeters.
(3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
method rather than hard-coding the name based on conditional.
* Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
LLVM libraries on Apple Windows build.
* Scripts/run-javascriptcore-tests:
(testapiPath): Use File::Spec rather than hard-coding path delimeters.
* Scripts/run-jsc: Ditto.
* Scripts/webkitdirs.pm:
(cmakeBasedPortName): Update to return the right value for the Apple
Windows port and the WinCairo port.
(isCMakeBuild): Expect CMake build for all Windows ports.
2015-10-30 Carlos Garcia Campos <cgarcia@igalia.com>
[JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
https://bugs.webkit.org/show_bug.cgi?id=150665
Reviewed by Csaba Osztrogonác.
We check it only to wipe the directory or not, but we are still
tryihng to update every module even when the configuration hasn't
changed. This is problematic because it makes the whole build fail
when any repository fails to checkout an already checked out
revision, because the server is down for example. This is even
more problematic for the bots that skip perfectly valid revisions.
It's still possible to force an update passing --force command
line argument.
* Scripts/update-webkit-libs-jhbuild:
(deleteJhbuildMd5): Delete the md5sum files if exist.
(runJhbuild): Return early if the md5sum files haven't
changed. Only write them after a successful build and delete them
if the build fails to ensure we don't skip next run.
2015-10-30 Philippe Normand <pnormand@igalia.com>
[GTK] Fix MacCLang build errors in Tools
https://bugs.webkit.org/show_bug.cgi?id=150031
Reviewed by Carlos Garcia Campos.
* TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
* WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
2015-10-29 Hunseop Jeong <hs85.jeong@samsung.com>
[EFL] MiniBrowser didn't work after r191749.
https://bugs.webkit.org/show_bug.cgi?id=150706
Reviewed by Alex Christensen.
Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
* Scripts/run-minibrowser:
2015-10-29 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r191766.
https://bugs.webkit.org/show_bug.cgi?id=150707
Problem with Cygwin build (Requested by bfulgham_ on #webkit).
Reverted changeset:
"[Win] build-jsc and run-javascriptcore-tests do not work"
https://bugs.webkit.org/show_bug.cgi?id=150700
http://trac.webkit.org/changeset/191766
2015-10-29 Brent Fulgham <bfulgham@apple.com>
[Win] build-jsc and run-javascriptcore-tests do not work
https://bugs.webkit.org/show_bug.cgi?id=150700
Reviewed by Mark Lam.
Correct our build system so that it expects Windows to be using CMake,
and to build the correct sub-projects for our JSC helper scripts.
* Scripts/build-jsc: Make sure to build the testapi harness when
building for Windows.
* Scripts/build-webkit:
(1) Use the existing 'cmakeBasedPortName()'
(2) Use File::Spec rather than hard-coding path delimeters.
(3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
method rather than hard-coding the name based on conditional.
* Scripts/run-javascriptcore-tests:
(testapiPath): Use File::Spec rather than hard-coding path delimeters.
* Scripts/run-jsc: Ditto.
* Scripts/webkitdirs.pm:
(cmakeBasedPortName): Update to return the right value for the Apple
Windows port and the WinCairo port.
(isCMakeBuild): Expect CMake build for all Windows ports.
2015-10-29 Alex Christensen <achristensen@webkit.org>
Fix build-jsc on Mac after r191749.
* Scripts/build-jsc:
Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
2015-10-29 Alex Christensen <achristensen@webkit.org>
Fix Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=150686
Reviewed by Filip Pizlo.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(isCachedArgumentfileOutOfDate):
(wrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cmakeBasedPortName):
(determineIsCMakeBuild):
(isCMakeBuild):
(promptUser):
(jhbuildWrapperPrefixIfNeeded): Deleted.
2015-10-29 Lucas Forschler <lforschler@apple.com>
Teach JSC bots to build 32bit instead of x86_64
Reviewed by Mark Lam.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2015-10-29 Per Arne Vollan <peavo@outlook.com>
[WinCairo] Fall back to AppleWin results in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=150672
Reviewed by Alex Christensen.
* Scripts/webkitpy/port/win.py:
(WinCairoPort):
(WinCairoPort.default_baseline_search_path):
2015-10-28 Keith Rollin <krollin@apple.com>
Do not sanitize user input for input[type=url]
https://bugs.webkit.org/show_bug.cgi?id=150346
<rdar://problem/23243240>
Reviewed by Brent Fulgham.
The Windows version of DumpRenderTree's eventSender.keyDown handler
simulates user-entry by decomposing the given character into a virtual
key code and a set of modifier keys. The code that determines if the
shift key should be simulated only worked if the character was an
upper case character. Extend this support to also include symbols that
(on the U.S. keyboard) require holding down the shift key.
This change allows fast/forms/input-user-input-sanitization.html
to succeed, which requires us to simulate the entering of '@' and ':'.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
2015-10-28 Alex Christensen <achristensen@webkit.org>
Compile and link with CMake on Mac
https://bugs.webkit.org/show_bug.cgi?id=150632
Reviewed by Tim Horton.
* TestWebKitAPI/PlatformMac.cmake:
2015-10-28 Xabier Rodriguez Calvar <calvaris@igalia.com>
Unreviewed.
* Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
2015-10-28 Per Arne Vollan <peavo@outlook.com>
Add WinCairo to list of ports in run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=150625
Reviewed by Brent Fulgham.
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(WinPort.run_webkit_tests_command):
(WinCairoPort):
(GtkWK2Port):
* Scripts/webkitpy/port/factory.py:
(PortFactory):
* Scripts/webkitpy/port/win.py:
(WinPort.find_system_pid):
(WinCairoPort):
2015-10-27 Alexey Proskuryakov <ap@apple.com>
WebKitTestRunner leaks in generateWhitelist()
https://bugs.webkit.org/show_bug.cgi?id=150563
Reviewed by Andreas Kling.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::generateWhitelist):
2015-10-27 Anders Carlsson <andersca@apple.com>
Add an API test for _WKRemoteObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150597
Reviewed by Andreas Kling.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
(-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[RemoteObjectRegistryPlugIn sayHello:]):
2015-10-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
Add myself to the reviewers list
https://bugs.webkit.org/show_bug.cgi?id=150581
Unreviewed.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-26 Ryan Haddad <ryanhaddad@apple.com>
Adding myself to contributors.json
* Scripts/webkitpy/common/config/contributors.json:
2015-10-26 Tim Horton <timothy_horton@apple.com>
Don't expose the whitelist/blacklist in _WKUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=150566
Reviewed by Anders Carlsson.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(TEST):
2015-10-26 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r191576.
broke
Reverted changeset:
"[GStreamer] Bump internal jhbuild versions to 1.6.0"
https://bugs.webkit.org/show_bug.cgi?id=149594
http://trac.webkit.org/changeset/191576
2015-10-26 ChangSeok Oh <changseok.oh@collabora.com>
[GStreamer] Bump internal jhbuild versions to 1.6.0
https://bugs.webkit.org/show_bug.cgi?id=149594
Reviewed by Philippe Normand.
Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
useful so they are removed accordingly.
* gtk/jhbuild.modules:
* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
* gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
* gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2015-10-25 Alexey Proskuryakov <ap@apple.com>
API tests fail on El Capitan after r191543
https://bugs.webkit.org/show_bug.cgi?id=150547
Reviewed by Dan Bernstein.
* Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
2015-10-24 Tim Horton <timothy_horton@apple.com>
Add a way to add user style sheets to WKUserContentController
https://bugs.webkit.org/show_bug.cgi?id=150531
<rdar://problem/23191691>
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(TEST):
2015-10-24 Tim Horton <timothy_horton@apple.com>
Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
https://bugs.webkit.org/show_bug.cgi?id=150525
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
(TEST):
Test the various new keys.
2015-10-24 Frederic Wang <fred.wang@free.fr>
check-webkit-style complains about missing operator whitespace inside character literal
https://bugs.webkit.org/show_bug.cgi?id=150396
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
2015-10-23 Michael Saboff <msaboff@apple.com>
REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
https://bugs.webkit.org/show_bug.cgi?id=150513
Reviewed by Saam Barati.
Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
* DumpRenderTree/TestRunner.cpp:
(simulateWebNotificationClickCallback):
(failNextCodeBlock):
(numberOfDFGCompiles):
(TestRunner::staticFunctions):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setBlockAllPlugins):
(WTR::TestRunner::failNextCodeBlock):
(WTR::TestRunner::numberOfDFGCompiles):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
2015-10-23 Anders Carlsson <andersca@apple.com>
Simplify the WebKitLegacy menu conversion code
https://bugs.webkit.org/show_bug.cgi?id=150509
Reviewed by Andreas Kling.
Implement the context menu delegate method so we'll test that code path.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
2015-10-23 Per Arne Vollan <peavo@outlook.com>
[WinCairo] Improve test results for fast layouttests.
https://bugs.webkit.org/show_bug.cgi?id=150464
Reviewed by Alex Christensen.
Set custom device scale factor to 1.0.
* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
2015-10-23 Mark Salisbury <mark.salisbury@hp.com>
[GTK] update-webkitgtk-libs should use mesa tarball
https://bugs.webkit.org/show_bug.cgi?id=150470
update-webkitgtk-libs downloads all build dependencies; in fixing
bug 148941 mesa was switched from ftp to git access. Now an http
tarball is available, which is preferred over accessing via git.
Reviewed by Philippe Normand
* gtk/jhbuild.modules:
Mesa access changed to http tarball.
2015-10-22 Sam Weinig <sam@webkit.org>
Navigations on the same host (but with different schemes and ports) should not trigger universal links
<rdar://problem/22811325>
https://bugs.webkit.org/show_bug.cgi?id=150481
Reviewed by Dan Bernstein.
* TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
Update test to test that navigations on the same host but with different schemes does not
trigger universal links, but that changes in the host do.
2015-10-22 Ryosuke Niwa <rniwa@webkit.org>
REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=150428
Reviewed by Antti Koivisto.
Added a regression test using WebKit API test.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
2015-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ build after r191423.
Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
* gtk/webkitdom.py:
(WebKitDOMDocGenerator):
2015-10-22 Aakash Jain <aakash_jain@apple.com>
[Win][EFL][GTK] webkitpy test failed after r191374.
https://bugs.webkit.org/show_bug.cgi?id=150433
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
(CrashLogsTest.test_find_log_darwin): Same.
2015-10-21 Brian Burg <bburg@apple.com>
Unreviewed, update watchlist for JS builtins.
Add a category for JS builtins code generator, similar to other generators.
Add a nag message to rebaseline builtins generator tests when touching
code generator files in Source/JavaScriptCore/Scripts/builtins/.
* Scripts/webkitpy/common/config/watchlist:
2015-10-21 Brian Burg <bburg@apple.com>
Restructure generate-js-bindings script to be modular and testable
https://bugs.webkit.org/show_bug.cgi?id=149929
Reviewed by Alex Christensen.
Add a stub shell script and basic webkitpy support for running builtins
generator tests.
* Scripts/run-builtins-generator-tests: Added.
(main):
* Scripts/webkitpy/codegen/__init__.py: Added.
* Scripts/webkitpy/codegen/main.py: Added.
The only interesting difference here from the inspector protocol
generator equivalent is that this implementation decodes the target
framework and output mode (combined or separate) from the test's file name.
(BuiltinsGeneratorTests):
(BuiltinsGeneratorTests.__init__):
(BuiltinsGeneratorTests.generate_from_js_builtins):
(BuiltinsGeneratorTests.write_error_file):
(BuiltinsGeneratorTests.detect_changes):
(BuiltinsGeneratorTests.run_tests):
(BuiltinsGeneratorTests.main):
2015-10-21 Aakash Jain <aakash_jain@apple.com>
run-webkit-tests does not copy all crash logs for layout test failures on Mac
https://bugs.webkit.org/show_bug.cgi?id=150407
<rdar://problem/22239750>
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/port/mac.py:
(MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
the log directory.
(MacPort.look_for_new_crash_logs): Uses above method to get crash logs
from log directory and merge them with the list of already crashed tests.
2015-10-21 Filip Pizlo <fpizlo@apple.com>
Failures in PutStackSinkingPhase should be less severe
https://bugs.webkit.org/show_bug.cgi?id=150400
Reviewed by Geoffrey Garen.
Add a test mode for no PutStackSinkingPhase.
* Scripts/run-jsc-stress-tests:
2015-10-21 Nan Wang <n_wang@apple.com>
AX: Expose table size and cell indexes on iOS
https://bugs.webkit.org/show_bug.cgi?id=150366
Reviewed by Chris Fleizach.
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::numberAttributeValue):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
W3C test importer should not import reference files as regular tests
https://bugs.webkit.org/show_bug.cgi?id=150331
Reviewed by Darin Adler.
Updated test_parser to return information that a file can be a referencefile or a manual test.
Updated test importer to skip those files.
Updated/Added test parser unit tests accordingly.
Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
to mark these files as Skip, since they are not direct tests.
* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.__init__):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
* Scripts/webkitpy/w3c/test_parser.py:
(TestParser.analyze_test):
* Scripts/webkitpy/w3c/test_parser_unittest.py:
(test_analyze_non_html_file):
(test_reference_test):
2015-10-20 Aakash Jain <aakash_jain@apple.com>
run-webkit-tests does not copy all crash logs for layout test failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=150056
<rdar://problem/9280656>
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_all_logs): Generic method to find all crash logs.
(CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
It iterates through log directory and returns all the logs based on timestamp.
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
(CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
(CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Modified start_time to start counting before simulator launch
so that we can capture crashes during simualator launch.
(Manager._look_for_new_crash_logs): Browse through list of crashes and append
any test which is not already marked as CRASH to the run_results.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationsModel.get_expectations_string): return PASS in case there
are no expectations defined for this test.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results): Add other_crashes in a separte category in full_results.json.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
from the log directory.
(IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
logs from log directory and merge them with the list of already crashed tests.
2015-10-20 Dana Burkart <dburkart@apple.com>
Fix the build
Unreviewed.
My previous patch was missing a necessary space character.
* Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
2015-10-20 Dana Burkart <dburkart@apple.com>
svn-apply fails to apply binary diffs in some cases
https://bugs.webkit.org/show_bug.cgi?id=64647
Reviewed by Daniel Bates.
* Scripts/VCSUtils.pm:
(decodeGitBinaryPatchDeltaSize): Modified.
We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
* Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
2015-10-20 Alexey Proskuryakov <ap@apple.com>
Mac Debug EWS never finishes when there are failures
https://bugs.webkit.org/show_bug.cgi?id=150334
Reviewed by Daniel Bates.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
2015-10-20 Philippe Normand <pnormand@igalia.com>
[GTK] Enable OpenWebRTC test video/audio sources in tests
This is needed because we can't expect the buildbots to have
webcam/mic devices plugged in.
Rubber-stamped by Carlos Garcia Campos.
* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
2015-10-20 Yoav Weiss <yoav@yoav.ws>
Rename the PICTURE_SIZES flag to CURRENTSRC
https://bugs.webkit.org/show_bug.cgi?id=150275
Reviewed by Dean Jackson.
* Scripts/webkitperl/FeatureList.pm:
2015-10-19 Hunseop Jeong <hs85.jeong@samsung.com>
Unreviewed, add myself to the committers list.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-19 Alexey Proskuryakov <ap@apple.com>
Add new EWS queues to bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=150297
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
2015-10-19 ChangSeok Oh <changseok.oh@collabora.com>
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580
Reviewed by Carlos Garcia Campos.
The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
So we do not need to skip them anymore.
* Scripts/run-gtk-tests:
(TestRunner): Deleted.
2015-10-19 Csaba Osztrogonác <ossy@webkit.org>
Add historical addresses to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=150227
Reviewed by Darin Adler.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
[Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
https://bugs.webkit.org/show_bug.cgi?id=150307
Reviewed by Brent Fulgham.
The DLL build rules have been changed to generate "{Name}Lib.DLL",
but these changes have not yet been applied to the Visual Studio builds.
* MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
2015-10-16 Andreas Kling <akling@apple.com>
[EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
<https://webkit.org/b/150153>
Unreviewed.
Just use simple arrays of LChar and UChar for this test instead of creating String
objects and then getting the characters8()/characters16() from them, since that
doesn't guarantee null-termination (the bug.)
* TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::build): Deleted.
2015-10-16 Tim Horton <timothy_horton@apple.com>
WebKit2.AutoLayoutIntegration API test is failing on some of the bots
https://bugs.webkit.org/show_bug.cgi?id=150255
Reviewed by Simon Fraser.
* Scripts/run-api-tests:
(runTest):
* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
(-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
(-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
(-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
Don't set the layout size until after the load finishes and we're waiting
for the reply, so that there is no race between the new size coming in
and us waiting for it.
2015-10-16 Anders Carlsson <andersca@apple.com>
WebEditingDelegate should be a formal protocol
https://bugs.webkit.org/show_bug.cgi?id=150254
<rdar://problem/23149847>
Reviewed by Dan Bernstein.
* DumpRenderTree/mac/EditingDelegate.h:
Conform to the WebEditingDelegate protocol.
2015-10-16 Tim Horton <timothy_horton@apple.com>
Hook up autolayout intrinsic sizing for WKWebView
https://bugs.webkit.org/show_bug.cgi?id=150219
<rdar://problem/20016905>
Reviewed by Simon Fraser.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
(-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
(-[AutoLayoutWKWebView load:expectingContentSize:]):
(-[AutoLayoutWKWebView expectContentSizeChange:]):
(-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
(TEST):
Add a variety of tests, including one which catches the bug that
the WebCore part of this patch fixes.
2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
Update the help message of --system-malloc
https://bugs.webkit.org/show_bug.cgi?id=150169
Reviewed by Geoffrey Garen.
* Scripts/webkitperl/FeatureList.pm:
2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
Update ImportExpectations according currently imported wpt tests
https://bugs.webkit.org/show_bug.cgi?id=150158
Reviewed by Chris Dumez.
* Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
Unreviewed, Update my email address.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
https://bugs.webkit.org/show_bug.cgi?id=84960
Reviewed by Žan Doberšek.
* Scripts/run-gtk-tests:
(TestRunner): Unskip tests using SessionState.
* TestWebKitAPI/PlatformGTK.cmake: Add
WKPageCopySessionStateWithFiltering test.
2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Missing return value on TestWebExtensions.cpp:193
https://bugs.webkit.org/show_bug.cgi?id=149755
Unreviewed. Add missing return value.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
(permissionRequestCallback):
2015-10-14 Andy Estes <aestes@apple.com>
[iOS] build-dumprendertree does not build ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=150152
Reviewed by Tim Horton.
run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
WebKit.xcworkspace), tests that rely on image diffing won't work properly.
There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
fine on that platform, and results in ImageDiff being built.
* Scripts/build-dumprendertree:
2015-10-14 Brent Fulgham <bfulgham@apple.com>
[Win] Enforce launcher/library naming scheme
https://bugs.webkit.org/show_bug.cgi?id=150124
Reviewed by Alex Christensen.
* DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
* MiniBrowser/win/CMakeLists.txt: Ditto.
* TestWebKitAPI/PlatformWin.cmake: Ditto.
* win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain): Look for a DLL named {name}Lib.dll, rather than the
original {name}.dll.
2015-10-14 Andreas Kling <akling@apple.com>
REGRESSION(r190882): Concatenating a character array and an empty string is broken.
<https://webkit.org/b/150135>
Reviewed by Geoffrey Garen.
Add a new WTF API test that covers this issue.
* TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::build):
(TestWebKitAPI::TEST):
2015-10-14 Alex Christensen <achristensen@webkit.org>
Add SPI for reloading without content blockers
https://bugs.webkit.org/show_bug.cgi?id=150058
rdar://problem/22742222
Reviewed by Sam Weinig.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest):
2015-10-14 Mark Lam <mark.lam@apple.com>
Rename some JSC option names to be more uniform.
https://bugs.webkit.org/show_bug.cgi?id=150127
Reviewed by Geoffrey Garen.
* Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
* Scripts/run-jsc-stress-tests:
2015-10-14 Anders Carlsson <andersca@apple.com>
Change the bundle app cache APIs to take a page
https://bugs.webkit.org/show_bug.cgi?id=150123
Reviewed by Sam Weinig.
Update APIs.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::clearAllApplicationCaches):
(WTR::TestRunner::clearApplicationCacheForOrigin):
(WTR::TestRunner::setAppCacheMaximumSize):
(WTR::TestRunner::applicationCacheDiskUsageForOrigin):
(WTR::TestRunner::originsWithApplicationCache):
2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
Update web-platform-tests tools to the latest revision
https://bugs.webkit.org/show_bug.cgi?id=149645
Reviewed by Darin Adler.
Disabling git submodules information conversion to json install file for web-platform-tests.
Disabling related python unit tests.
The tools submodules contain submodules and the conversion tool does not support that yet.
Updating wpt launcher script to aling it with web-platform-test main script.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
(main):
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
(TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_submodules_generation):
2015-10-13 Alexey Proskuryakov <ap@apple.com>
More debug queue build fixing.
Preserve the build style in one more place. Changed mock build_style from "both"
to "release", as we don't support testing both debug and release.
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.archive_last_test_results):
(MockCommitQueue):
(MockCommitQueue.build_style):
(MockCommitQueue.did_pass_testing_ews):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2015-10-13 Alexey Proskuryakov <ap@apple.com>
More debug queue build fixing.
Add build_style argument to derived classes as well.
* Scripts/webkitpy/common/config/ports.py:
(MacPort):
(MacPort.run_webkit_tests_command):
(WinPort.run_bindings_tests_command):
(WinPort):
(WinPort.run_webkit_tests_command):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port):
(GtkWK2Port.run_webkit_tests_command):
2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
[iOS] Build fix
Unreviewed.
Mach-O section names are limited to 16 characters.
* DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
* DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
2015-10-13 Alexey Proskuryakov <ap@apple.com>
Build fix for mac-debug EWS queue.
Unreviewed.
Pass --debug to run-webkit-tests.
While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
will need to be substantially modified to work in EWS, so the dummy implementation
was not helpful.
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_webkit_unit_tests_command): Deleted.
* Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_javascriptcore_tests_command):
(MockPort):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):
(MockPort.run_webkit_unit_tests_command): Deleted.
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
2015-10-13 Brent Fulgham <bfulgham@apple.com>
[Win] Generate Crash Traces
https://bugs.webkit.org/show_bug.cgi?id=150103
Reviewed by Daniel Bates.
We were using an exception filter to try to emit "#CRASHED" to stderr
when a test program crashed. However, the modern Python implementation
seems capable of recognizing crashes on its own. Furthermore, registering
the exception handler was preventing the JIT debugger (NTSD) from
automatically attaching to the crashing program, so we were not getting
crash traces.
* DumpRenderTree/win/DumpRenderTree.cpp:
(main): Don't register an exception filter.
(exceptionFilter): Deleted.
* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs): Add another regular expression to handle a second crash trace
syntax I encountered during testing.
(CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
try the new one. The PID found by the new expression is in hexadecimal, so
convert it to an integer before returning it.
* Scripts/webkitpy/port/driver.py:
(Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
check for "#CRASHED" after stripping off the EOL characters.
* Scripts/webkitpy/port/win.py:
(WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
invocation. This is apparently used to signal an event when the debugger is finished.
2015-10-13 Alexey Proskuryakov <ap@apple.com>
Mac Debug and 32-bit queues should be separate
https://bugs.webkit.org/show_bug.cgi?id=150092
Reviewed by Lucas Forschler.
* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue._capitalize_after_dash):
(Queue._caplitalize_after_dash): Deleted.
* Scripts/webkitpy/common/config/ews.json:
2015-10-13 Sergio Villar Senin <svillar@igalia.com>
[GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085
Reviewed by Carlos Garcia Campos.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2015-10-13 Sebastian Dröge <sebastian@centricular.com>
Unreviewed, add myself to the committers list.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-12 Alexey Proskuryakov <ap@apple.com>
Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
https://bugs.webkit.org/show_bug.cgi?id=149983
Reviewed by Dan Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2015-10-12 Alexey Proskuryakov <ap@apple.com>
Fix webkitpy tests after r190922.
* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2015-10-12 Alexey Proskuryakov <ap@apple.com>
Add a Mac debug EWS queue
https://bugs.webkit.org/show_bug.cgi?id=150069
Reviewed by Geoffrey Garen.
* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.archive_last_test_results):
(AbstractEarlyWarningSystem.build_style):
(AbstractEarlyWarningSystem.refetch_patch):
(AbstractEarlyWarningSystem.load_ews_classes):
2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
[GTK] Update jhbuild's version of harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=149749
Reviewed by Martin Robinson.
Update harfbuzz to 0.9.35, following the lead of Debian Stable.
* gtk/jhbuild.modules: Updated details for harfbuzz.
2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
https://bugs.webkit.org/show_bug.cgi?id=150026
Reviewed by Philippe Normand.
Backport upstream patch from gst-plugins-bad so that the right version
of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
gets compiled properly, avoiding crashes on runtime while running tests.
* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
* gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
Test font-variant-* and font-feature-settings with mocked preinstalled fonts
https://bugs.webkit.org/show_bug.cgi?id=149777
Reviewed by Simon Fraser.
Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
to the list of tests to preinstall at startup time.
Also, update the generation of the 'name' table in the FontWithFeatures font.
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
(activateFontsIOS):
* FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(Generator::generate):
(Generator::appendCFFTable):
(Generator::appendNameSubtable):
(Generator::appendNAMETable):
* FontWithFeatures/FontWithFeatures/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::allowedFontFamilySet):
2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
Unreviewed. Add Jinyoung Hur as a committer.
* Scripts/webkitpy/common/config/contributors.json:
2015-10-10 Dan Bernstein <mitz@apple.com>
[iOS] Remove unnecessary iOS version checks
https://bugs.webkit.org/show_bug.cgi?id=150002
Reviewed by Alexey Proskuryakov.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
* WebKitTestRunner/ios/UIKitSPI.h:
2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
Unreviewed, rolling out r190689
https://bugs.webkit.org/show_bug.cgi?id=149992
Fixed in other repository.
Reverted changesets:
"Unreviewed, rolling out r190572, r190593, r190594, and r190639."
https://bugs.webkit.org/show_bug.cgi?id=149897
2015-10-09 Brian Burg <bburg@apple.com>
Teach webkitperl how to figure out IOS versions from the SDK
https://bugs.webkit.org/show_bug.cgi?id=149963
Reviewed by Daniel Bates.
It should be easier to check the major and minor version of IOS SDKs.
* Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
* Scripts/webkitdirs.pm:
(splitVersionString): Added.
(determineOSXVersion): Use splitVersionString.
(determineIOSVersion): Added. Look at the SDK version and make a tuple.
(iosVersion): Added.
2015-10-09 Simon Fraser <simon.fraser@apple.com>
[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
https://bugs.webkit.org/show_bug.cgi?id=149960
Reviewed by Tim Horton.
Use adoptWK(), and null out some members (file is not using ARC).
* WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::uiScriptComplete):
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
Remove ENABLE_SUID_SANDBOX_LINUX cruft
https://bugs.webkit.org/show_bug.cgi?id=149954
Reviewed by Darin Adler.
* Scripts/webkitperl/FeatureList.pm:
2015-10-09 Daniel Bates <dabates@apple.com>
Make iOS builders generate debug information in a separate dSYM file
https://bugs.webkit.org/show_bug.cgi?id=149696
Reviewed by Darin Adler.
Similar to the Mac builders, the iOS builders should write debug information
into a separate dSYM file instead of including such information in the binary
itself (default Xcode behavior)
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
Fix webkitpy tests after r190779
https://bugs.webkit.org/show_bug.cgi?id=149949
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_values):
2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
Extend run-benchmark script to support human-readable results conversion.
https://bugs.webkit.org/show_bug.cgi?id=149944
Reviewed by Ryosuke Niwa.
Add '--read-results-json' and '--no-adjust-unit' options.
'--read-results-json' option converts result file to human readable format.
'--no-adjust-unit' option skips scientific notation convertion.
'--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
* Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_tests):
(BenchmarkResults._format_values):
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner._dump):
(BenchmarkRunner.show_results):
(BenchmarkRunner._show_results): Deleted.
* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
(start):
2015-10-08 Daniel Bates <dabates@apple.com>
Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149945
Reviewed by Dan Bernstein.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-9 img.logo):
2015-10-08 Daniel Bates <dabates@apple.com>
Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149943
Reviewed by Dan Bernstein.
Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
teach build-webkit to install them when building for iOS device using the public iOS SDK.
* Scripts/build-webkit:
2015-10-08 Daniel Bates <dabates@apple.com>
Add LLVM binaries for iOS 9 device
https://bugs.webkit.org/show_bug.cgi?id=149913
Reviewed by Filip Pizlo.
Implement support for building LLVM for ARM64-based iOS devices.
* Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
* Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
an existing build earlier in the file such that remove previously built
libraries before building/copying new ones (if applicable).
(fileContains): Moved function outside of if-block.
(isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
(buildLLVM): Added. Extracted machinery to build LLVM into this function and
added logic to build LLVM for ARM64-based iOS devices.
(symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
LLVM into the WebKitBuild directory.
2015-10-08 Alexey Proskuryakov <ap@apple.com>
Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
https://bugs.webkit.org/show_bug.cgi?id=149848
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2015-10-07 Brent Fulgham <bfulgham@apple.com>
[Win] Support 64-bit Build and Testing
https://bugs.webkit.org/show_bug.cgi?id=149904
Reviewed by Daniel Bates.
Extend our existing scripts to support 64-bit build and test operations on
Windows.
* Scripts/build-dumprendertree: We don't need to build DRT on its own;
Windows always builds the whole stack.
* Scripts/webkit-build-directory: Add an option to return the location of
the executable files produced by a specific configuration. This change is
actually useful for Gtk and EFL, too.
* Scripts/webkitdirs.pm:
(executableProductDir): Added. This function appends the proper binary
path to the productDir. This is useful for Windows, Gtk, and EFL ports.
(jscProductDir): Use the new 'executableProductDir' method.
(setPathForRunningWebKitApp): Ditto.
(runSafari): Ditto.
(runMiniBrowser): Ditto.
* Scripts/webkitpy/port/factory.py:
(configuration_options): Add a 64-bit option, used on Windows to specify
which binary target should be used for testing.
* Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
processes when needed.
(WinPort._build_path): Add the correct binary target path to _build_path.
(WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
64-bit paths for 64-bit tests.
(WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
NTSD debugger does not understand this argument.
2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776
Reviewed by Simon Fraser.
This test extends our existing FontWithFeatures project to be able to generate a
TrueType font. This font is conceptually similar as the existing OpenType font,
except the feature -> character mapping is different.
The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.
The letter "A" always is a check mark.
The letter "B" always is an X.
Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when
"kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
mark.
Here are the mappings of font features to letters:
kLigaturesType / kCommonLigaturesOnSelector: C
kLigaturesType / kContextualLigaturesOnSelector: D
kLigaturesType / kRareLigaturesOnSelector: G
kLigaturesType / kHistoricalLigaturesOnSelector: I
kContextualAlternatesType / kContextualAlternatesOnSelector: L
kVerticalPositionType / kInferiorsSelector: O
kVerticalPositionType / kSuperiorsSelector: P
kLowerCaseType / kLowerCaseSmallCapsSelector: S
kUpperCaseType / kUpperCaseSmallCapsSelector: V
kLowerCaseType / kLowerCasePetiteCapsSelector: T
kUpperCaseType / kUpperCasePetiteCapsSelector: W
kLetterCaseType / 14: Y
kStyleOptionsType / kTitlingCapsSelector: a
kNumberCaseType / kUpperCaseNumbersSelector: c
kNumberCaseType / kLowerCaseNumbersSelector: d
kNumberSpacingType / kProportionalNumbersSelector: f
kNumberSpacingType / kMonospacedNumbersSelector: g
kFractionsType / kDiagonalFractionsSelector: i
kFractionsType / kVerticalFractionsSelector: j
kVerticalPositionType / kOrdinalsSelector: Q
kTypographicExtrasType / kSlashedZeroOnSelector: k
kLigaturesType / kHistoricalLigaturesOnSelector: K
kCharacterShapeType / kJIS1978CharactersSelector: m
kCharacterShapeType / kJIS1983CharactersSelector: n
kCharacterShapeType / kJIS1990CharactersSelector: o
kCharacterShapeType / kJIS2004CharactersSelector: p
kCharacterShapeType / kSimplifiedCharactersSelector: q
kCharacterShapeType / kTraditionalCharactersSelector: r
kTextSpacingType / kMonospacedTextSelector: t
kTextSpacingType / kProportionalTextSelector: u
kRubyKanaType / kRubyKanaOnSelector: v
* FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
* FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(GLYFBuilder::GLYFBuilder):
(GLYFBuilder::takeResult):
(GLYFBuilder::moveTo):
(GLYFBuilder::lineTo):
(GLYFBuilder::closePath):
(GLYFBuilder::writePoint):
(GLYFBuilder::append16):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(itemForGlyph):
(Generator::generate):
(Generator::insertSelector):
(Generator::insertFeature):
(Generator::generateFeatureDescription):
(Generator::appendCFFTable):
(Generator::appendGLYFTable):
(Generator::appendLOCATable):
(Generator::appendFEATTable):
(Generator::appendMetamorphosisChain):
(Generator::appendMORXTable):
(Generator::appendHEADTable):
(Generator::appendHMTXTable):
(Generator::appendNameSubtable):
(Generator::append2ByteASCIIString):
(Generator::appendNAMETable):
(generateFont):
(CFFBuilder::curveToCubic): Deleted.
(charStringForGlyph): Deleted.
* FontWithFeatures/FontWithFeatures/FontCreator.h:
* FontWithFeatures/FontWithFeatures/main.cpp:
(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
(drawTextWithFeature): Deleted.
2015-10-07 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r190572, r190593, r190594, and
r190639.
https://bugs.webkit.org/show_bug.cgi?id=149897
Breaks Mavericks build (Requested by litherum on #webkit).
Reverted changesets:
"Allow WKRetainPtrs to be used as keys in hashing data
structures"
https://bugs.webkit.org/show_bug.cgi?id=149762
http://trac.webkit.org/changeset/190572
"REGRESSION(189668?): http/tests/notifications/events.html
flakily asserts or times out"
https://bugs.webkit.org/show_bug.cgi?id=149218
http://trac.webkit.org/changeset/190593
"Prospective Mavericks build fix."
http://trac.webkit.org/changeset/190594
"Post-review cleanup after r190572."
http://trac.webkit.org/changeset/190639
2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):
2015-10-06 Brian Burg <bburg@apple.com>
Unreviewed, try to fix the iOS 8 build after r190368.
On older versions, IOHIDEventCreateForceEvent is not available.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
2015-10-06 Keith Miller <keith_miller@apple.com>
Add gmalloc option to run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=149858
Reviewed by Geoffrey Garen.
run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
* Scripts/run-javascriptcore-tests:
2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
Post-review cleanup after r190572.
Unreviewed.
* TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
2015-10-06 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed build correction.
* TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
are soft-linked at runtime.
2015-10-06 Keith Miller <keith_miller@apple.com>
Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
https://bugs.webkit.org/show_bug.cgi?id=149815
Reviewed by Filip Pizlo.
Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
so should just use one test runner.
* Scripts/run-javascriptcore-tests:
(runJSCStressTests):
(runMozillaTests): Deleted.
(defaultJsDriverArgsForMozillaTests): Deleted.
* Scripts/run-jsc-stress-tests:
2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
[GTK] Make update-webkitgtk-libs work behind firewall
update-webkitgtk-libs can work behind a firewall with changes to
a few packages. Where outbound git and active FTP connections
fail, using http protocol succeeds. Most packages are
already accessed using http.
https://bugs.webkit.org/show_bug.cgi?id=148941
Reviewed by Martin Robinson.
Tools
* gtk/jhbuild.modules:
Replace git URLs with http. Remove no longer used ftp repositories.
Update argument for libxml2's autogen.sh script (--without-python
is ignored; --with-python=no is correct).
* jhbuild/jhbuild-wrapper:
Instead of connecting to git://git.gnome.org/jhbuild, connect to
http://git.gnome.org/browse/jhbuild.
2015-10-06 Daniel Bates <dbates@webkit.org>
Enable XSLT when building WebKit for iOS using the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149827
Reviewed by Alexey Proskuryakov.
Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
run this script before building WebKit for iOS or the build will fail because one or more XSLT
headers cannot be found.
* Scripts/configure-xcode-for-ios-development:
(copyMissingXSLTHeadersToSDKIfNeeded): Added.
2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
https://bugs.webkit.org/show_bug.cgi?id=149218
Reviewed by Alexey Proskuryakov.
Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
when the TestOptions change. Previously, WebNotificationProvider only could handle a single
WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
WebNotificationProvider must be updated to appropriately handle multiple
WKNotificationManagerRefs in flight at the same time.
* WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::~WebNotificationProvider):
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::addNotificationManager):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):
* WebKitTestRunner/WebNotificationProvider.h:
2015-10-05 Daniel Bates <dabates@apple.com>
Disable Bitcode when building for iOS device
https://bugs.webkit.org/show_bug.cgi?id=149818
Reviewed by Alexey Proskuryakov.
Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
when building for iOS device.
* Scripts/webkitdirs.pm:
(XcodeOptions):
2015-10-05 Daniel Bates <dabates@apple.com>
[iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
https://bugs.webkit.org/show_bug.cgi?id=140828
<rdar://problem/19520599>
Reviewed by Alexey Proskuryakov.
Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
to build-webkit.
* Scripts/webkitdirs.pm:
(XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
(hasIOSDevelopmentCertificate): Added.
2015-10-05 Daniel Bates <dabates@apple.com>
DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
https://bugs.webkit.org/show_bug.cgi?id=149766
Reviewed by Alexey Proskuryakov.
Create network storage testing session on iOS.
Currently we do not create a network storage testing session on iOS. A network storage testing session always
has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
returns a non-null pointer to a cookie store.
* DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment):
2015-10-05 Simon Fraser <simon.fraser@apple.com>
Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
available.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
Allow WKRetainPtrs to be used as keys in hashing data structures
https://bugs.webkit.org/show_bug.cgi?id=149762
Reviewed by Anders Carlsson.
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
(TestWebKitAPI::TEST):
2015-10-05 Simon Fraser <simon.fraser@apple.com>
Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
available, and tidy up the #ifdefs in the UIKitSPI header.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _sendHIDEvent:]):
* WebKitTestRunner/ios/UIKitSPI.h:
2015-10-04 Zan Dobersek <zdobersek@igalia.com>
[GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
https://bugs.webkit.org/show_bug.cgi?id=149792
Reviewed by Martin Robinson.
* WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
for WebKitTestRunner multiple times.
2015-10-04 Daniel Bates <dabates@apple.com>
Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)
For now, support calling build-layouttestrelay without --ios-simulator so long
as we are building on a Mac.
* Scripts/build-layouttestrelay:
2015-10-04 Alexey Proskuryakov <ap@apple.com>
Support Trac 1.0.x XML timeline link format
https://bugs.webkit.org/show_bug.cgi?id=149786
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject):
2015-10-04 Alexey Proskuryakov <ap@apple.com>
Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
2015-10-04 Alexey Proskuryakov <ap@apple.com>
Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):
2015-10-02 Daniel Bates <dabates@apple.com>
Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149769
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-simulator-9 img.logo):
2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
REGRESSION(r190370): Speedometer spits out an extra console message
https://bugs.webkit.org/show_bug.cgi?id=149720
Unreviewed. Temporarily ignore the console error message.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._filter_output):
2015-10-02 Brent Fulgham <bfulgham@apple.com>
Provide "--no-ninja" option to avoid using Ninja
https://bugs.webkit.org/show_bug.cgi?id=149757
Reviewed by Alex Christensen.
Add a new command line argument understood by webkitdirs.pm so
that we can conditionally avoid using Ninja. This is an
'opt-out' argument, so no existing Ninja users should be affected.
* Scripts/webkitdirs.pm:
(canUseNinja): Check for option and block ninja if present.
2015-10-02 Aakash Jain <aakash_jain@apple.com>
Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648
Reviewed by Alexey Proskuryakov.
* TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2015-10-02 Daniel Bates <dabates@apple.com>
Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)
For now, pass --ios-simulator.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._build_relay):
2015-10-02 Simon Fraser <simon.fraser@apple.com>
Remove a "nullable" that breaks the iOS 8 build.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2015-10-02 Daniel Bates <dabates@apple.com>
LayoutTestRelay is not built and archived when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=149753
Reviewed by Alexey Proskuryakov and Andy Estes.
Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
product archive when building for iOS Simulator, respectively.
* BuildSlaveSupport/built-product-archive:
(main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
differentiate between iOS device and iOS Simulator platforms.
(webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
from determineWebKitBuildDirectories() into this function so that it can be used by both
determineWebKitBuildDirectories() and archiveBuiltProduct().
(determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
webkitBuildDirectoryForConfigurationAndPlatform().
(createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
for the limitation that ditto(1) can only accept a single directory to archive on its command line.
(archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
* Scripts/build-layouttestrelay:
- Remove unnecessary include of Perl module POSIX.
- Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
* Scripts/build-webkit:
- Invoke script build-layouttestrelay when building for iOS Simulator.
2015-10-02 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed test fix.
You cannot run 'run-webkit-tests' from the command line because it does not know
to append the binary subdirectory (bin32/bin64). We don't see this on our builders
because they explicitly set use the 'root' argument to provide the full path to
the test binaries.
* Scripts/webkitpy/port/win.py:
(WinPort._build_path): Added.
2015-10-02 Alex Christensen <achristensen@webkit.org>
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222
Reviewed by Geoffrey Garen.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest):
Test what happens when you disable content blockers from the SPI.
2015-10-01 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed build fix for run-api-tests
* Scripts/run-api-tests:
(testToolPaths): Windows run needs to specify the binary path.
2015-10-01 Daniel Bates <dabates@apple.com>
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
2015-10-01 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed build fix.
* Scripts/webkitdirs.pm:
(setupAppleWinEnv): Use 64-bit build tools if available
2015-10-01 Brent Fulgham <bfulgham@apple.com>
[Win] Fix TestWebKitAPI build under CMake.
Reviewed by Alex Christensen.
* TestWebKitAPI/PlatformWin.cmake: Add missing link command
for Psapi.lib.
2015-10-01 Brent Fulgham <bfulgham@apple.com>
[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718
Reviewed by Alex Christensen.
* Scripts/webkitdirs.pm:
(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.
2015-10-01 Alexey Proskuryakov <ap@apple.com>
Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.
* Scripts/build-webkit:
2015-10-01 Daniel Bates <dabates@apple.com>
Attempt to fix the iOS 9 Simulator testers
Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* Scripts/build-webkit:
2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710
Reviewed by Martin Robinson.
Add test case to check that we can authenticate sites with an
empty realm.
* TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):
2015-10-01 Alexey Proskuryakov <ap@apple.com>
[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202
Reviewed by Dan Bernstein.
* Scripts/run-api-tests:
(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):
2015-10-01 Daniel Bates <dabates@apple.com>
Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837
Reviewed by Philippe Normand.
* efl/jhbuild.modules:
* efl/patches/openwebrtc-clang-warning-fix.patch: Added.
* efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
Unreviewed. Fix the iOS build after r190407.
* WebKitTestRunner/ios/IOKitSPI.h:
2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676
Reviewed by Simon Fraser.
Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.
* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
the notifications that the keyboard has been raised or lowered.
(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.m:
(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
a keyDown event in WebKit.
* WebKitTestRunner/ios/IOKitSPI.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed, rolling out r190399.
Tests are still failing even after r190362
Reverted changeset:
"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399
2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494
Reviewed by Philippe Normand.
* efl/jhbuild.modules:
* gtk/jhbuild.modules:
2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Unskip GTK+ user media unit tests after r190362.
They should pass now.
* Scripts/run-gtk-tests:
(TestRunner):
2015-09-30 Daniel Bates <dabates@apple.com>
Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
* BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
(extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2015-09-30 Daniel Bates <dabates@apple.com>
Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
Actually, we need to pass --configuration to script webkit-build-directory to have
it return the path to the configuration-specific build directory.
* BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories):
2015-09-30 Daniel Bates <dabates@apple.com>
built-product-archive archives incorrect build directory for iOS port
https://bugs.webkit.org/show_bug.cgi?id=149695
Reviewed by Darin Adler.
Fixes an issue where the script built-product-archive archives a non-existent
build directory for the iOS port. Without loss of generality, the script assumes
the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
to determine the top-level build directory and computes the configuration-specific
build directory to be the concatenation of the the top-level build directory and
the configuration (e.g. Release). This is incorrect. Instead we should call
webkit-build-directory omitting the flag --top-level to compute the path to the
configuration-specific build directory.
* BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
(main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
its purpose and added global variable _configurationBuildDirectory to store the path
to the configuration-specific build directory. Ensure that we have a non-empty string
for both the top-level and configuration-specific build directories.
(determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
Compute the configuration-specific build directory and store it in the global variable
_configurationBuildDirectory.
(archiveBuiltProduct): Modified to use _configurationBuildDirectory.
(extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
as needed.
(determineWebKitBuildDirectory): Deleted.
2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
[EFL] css3/device-adapt/* tests failed after r190335.
https://bugs.webkit.org/show_bug.cgi?id=149655
Reviewed by Simon Fraser.
device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::shouldUseFixedLayout):
2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
Extend JetStream timeout for slow devices.
Reviewed by Chris Dumez.
Extend JetStream timeout to 20 minutes.
* Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2015-09-30 Daniel Bates <dabates@apple.com>
Rename iOS builders/testers to include version
https://bugs.webkit.org/show_bug.cgi?id=149685
Reviewed by Simon Fraser.
Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
make it clear to a reader the version of iOS these builders/testers are using.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2015-09-30 Daniel Bates <dabates@apple.com>
Add iOS criterion for triggering a build
https://bugs.webkit.org/show_bug.cgi?id=149679
Rubber-stamped by Alexey Proskuryakov.
First pass at defining criterion for triggering an iOS build.
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
2015-09-29 Simon Fraser <simon.fraser@apple.com>
[iOS] Allow tests to generate user gestures for UI testing
https://bugs.webkit.org/show_bug.cgi?id=149653
Reviewed by Tim Horton.
Expose functionality in UIScriptController to allow for testing single- and double-tap,
and to listen for completion of scrolling and zooming in the WKWebView.
Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
which hides the complexity of creating these events. Event dispatch is asynchronous.
We detect when the last event has been handled by dispatching a vendor-specific event,
which is detected via -_handleHIDEvent: in our UIApplication subclass.
* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
single and double taps.
* WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::registerCallback): Used to store the callbacks for zooming.
Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
(UIScriptContext::unregisterCallback):
(UIScriptContext::callbackWithID):
(UIScriptContext::fireCallback):
* WebKitTestRunner/UIScriptContext/UIScriptContext.h:
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
(WTR::UIScriptController::willBeginZoomingCallback): Ditto.
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
(WTR::UIScriptController::doubleTapAtPoint): Ditto.
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
(-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
* WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
* WebKitTestRunner/ios/HIDEventGenerator.m: Added.
(simpleDragCurve):
(calculateNextLocation):
(delayBetweenMove):
(+[HIDEventGenerator sharedHIDEventGenerator]):
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator init]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator touchDown:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator liftUp:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator tap:completionBlock:]):
(-[HIDEventGenerator doubleTap:completionBlock:]):
(-[HIDEventGenerator twoFingerTap:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator markerEventReceived:]):
* WebKitTestRunner/ios/IOKitSPI.h: Added.
* WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::globalToContentCoordinates):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
* WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp _handleHIDEvent:]):
2015-09-30 Dana Burkart <dburkart@apple.com>
git-add-reviewer should trim trailing spaces/newlines
https://bugs.webkit.org/show_bug.cgi?id=149513
Reviewed by Darin Adler.
* Scripts/git-add-reviewer:
(nonInteractive):
2015-09-30 Eric Carlson <eric.carlson@apple.com>
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580
Reviewed by Darin Adler.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
order to WKUserMediaPermissionRequestAllow.
2015-09-30 Daniel Bates <dabates@apple.com>
Add iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149549
Reviewed by Alexey Proskuryakov.
Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
* BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2015-09-30 Timothy Hatcher <timothy@apple.com>
Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149674
Reviewed by Lucas Forschler.
* WebKitLauncher/WebKitLauncher.entitlements: Added.
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2015-09-30 Jason Marcell <jmarcell@apple.com>
BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
have an associated trac instance.
https://bugs.webkit.org/show_bug.cgi?id=149673
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
have an associated trac instance.
2015-09-30 Daniel Bates <dabates@apple.com>
Prioritize testing latest build request on iOS test bots
https://bugs.webkit.org/show_bug.cgi?id=149669
Reviewed by Darin Adler.
We should prioritize testing of the latest build request on the iOS test bots
as we do for Mac and Windows test bots.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
2015-09-30 Daniel Bates <dabates@apple.com>
Add buildbot category for iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149667
Reviewed by Darin Adler.
Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
for iOS to the build.webkit.org home page.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2015-09-30 Daniel Bates <dabates@apple.com>
Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)
I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
in <http://trac.webkit.org/changeset/190351>.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
2015-09-30 Daniel Bates <dabates@apple.com>
Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)
{32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
2015-09-30 Lucas Forschler <lforschler@apple.com>
bot210 was configured for a queue instead of bot126.
Unreviewed config.json fix.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2015-09-30 Lucas Forschler <lforschler@apple.com>
Bring El Capitan buildbot infrastructure online.
https://bugs.webkit.org/show_bug.cgi?id=149605
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2015-09-30 Tomas Popela <tpopela@redhat.com>
[GTK] Deprecation warnings in DOMNodeTest
https://bugs.webkit.org/show_bug.cgi?id=149663
After the webkit_dom_document_get_elements_by_tag_name deprecation we
need to update the tests to use webkit_dom_document_query_selector_all
to avoid compilation warnings.
Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
(the suggested replacement for the deprecated function).
Reviewed by Carlos Garcia Campos.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(registerTests):
(WebKitDOMNodeTest::testTagNames): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(prepareDOMForTagNamesTests):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(beforeAll):
(testWebKitDOMNodeTagNames): Deleted.
2015-09-29 Simon Fraser <simon.fraser@apple.com>
WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
https://bugs.webkit.org/show_bug.cgi?id=149650
Reviewed by Tim Horton.
TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
looks at the file path, and not the custom options that come from file comments.
Fix by computing TestOptions before making the TestInvocation, and setting them
as const TestInvocation data. This meant changing various call sites to take
the std::string pathOrURL, rather than the TestInvocation itself.
Also initialize TestInvocation with a WKURLRef, rather than a std::string.
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::testPath):
(WTR::createTestURL):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::testOptionsForTest):
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::createWKURL): Deleted.
(WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
(WTR::TestInvocation::shouldUseFixedLayout): Deleted.
* WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::options):
* WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
(WTR::pathContains):
(WTR::shouldMakeViewportFlexible):
(WTR::shouldUseFixedLayout):
(WTR::isSVGTestPath):
(WTR::isHiDPITestPath):
(WTR::TestOptions::TestOptions):
* WebKitTestRunner/TestOptions.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::pathContains):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2015-09-29 Aakash Jain <aakash_jain@apple.com>
Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648
Reviewed by Alexey Proskuryakov.
* QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
difference between new appscale and old Google App Engine implementation.
* TestResultServer/app.yaml: Same.
* TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2015-09-29 Daniel Bates <dabates@apple.com>
configure-xcode-for-ios-development does not work with Xcode 7
https://bugs.webkit.org/show_bug.cgi?id=149640
Reviewed by Alexey Proskuryakov.
When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
because it cannot find the Xcode specification files for iOS simulator and device. These
files have moved to a new location in Xcode 7 distribution. Moreover we must add the
relevant definitions to the Xcode 7 specification files directly as opposed to creating
new specification files with the added definitions (as we did in older versions of Xcode)
in order for Xcode 7 to honor these definitions.
* Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
(updateXcodeSpecificationFilesForSDKIfNeeded): Added.
(updateXcode7SpecificationFile): Added.
(createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
(writeXcodeSpecification): Moved congratulations line to caller so as to write out the
appropriate success message.
(mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
(createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
(createXcodeSpecificationFromSpecificationAndId): Deleted.
2015-09-29 Brent Fulgham <bfulgham@apple.com>
[Win] Allow 'prepare-ChangeLog' to be used without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=149639
Reviewed by Alex Christensen.
* Scripts/VCSUtils.pm:
(exitStatus): Use 'isWindows()' method.
(isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
an error. This method could probably just go away.
(normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
always changing to Unix style.
(unixPath): Added. Needed so Windows can always show a Unix path in the
ChangeLog file.
(changeLogName): Work around the fact that 'getpwuid' is not available on
a pure Windows build of Perl.
* Scripts/prepare-ChangeLog:
(generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
path on Windows.
(svnUpdateCommand): Added helper function. Needed because Windows Perl does not
support using arrays for 'open' arguments.
(resolveChangeLogsPath): Ditto.
(resolveConflictedChangeLogs): Use new helper functions.
(generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
(diffCommand): Use double-quotes for paths, since Windows doesn't understand single
quotes. Unix systems are happy either way.
(statusCommand): Ditto.
* Scripts/webkitdirs.pm:
(launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2015-09-29 Brent Fulgham <bfulgham@apple.com>
[Win] Unreviewed 64-bit build fix after switch to CMake.
* Scripts/webkitdirs.pm:
(determineIsWin64FromArchitecture): Added.
2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
printing does not use minimum page zoom factor
https://bugs.webkit.org/show_bug.cgi?id=108507
Reviewed by Darin Adler.
WebKitTestRunner always takes the snapshots from the UI process
(expect for IOS), so in the case of printing, the layout in the
web view is not the expected one. When printing, we need to take
the snapshot in the web process and ensure it's rendered with a
PrintContext.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): When dumping pixels, pass
kWKSnapshotOptionsPrinting option to
WKBundlePageCreateSnapshotWithOptions() when printing.
2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
[WTR] Pixel tests generate the snapshots twice in Web and UI processes
https://bugs.webkit.org/show_bug.cgi?id=149595
Reviewed by Tim Horton.
All ports except IOS implement
PlatformWebView::windowSnapshotImage() to generate the snapshot
for the pixel tests in the UI process. But we are still generating
a snapshot for pixel tests in the Web process too, that is passed
to the UI process but ignored.
Whether a pixel result is needed or not, is only known by the web
process depending on whether the test called dumpAsText with
dumpPixels == true or not. Since the pixels are now dump in the UI
process, we need to pass that information to the UI process when
the test is done. For that we set a PixelResultIsPending bool
parameter to the Done message, and we only add the PixelResult
when UI process doesn't need to generate the pixels dump.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage): Set
m_pixelResultIsPending to false on reset.
(WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
Done message, and set the PixelResult if m_pixelResultIsPending is false.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
(WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
port.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpResults): Use either the pixel result
from the web process or generate a pixel result from the web view
if need it.
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
parameter to dumpPixelsAndCompareWithExpected, since the snapshot
is created by the caller now, but the CG implementation needs to
know if it's a Web or UI process snapshot.
* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
cairo surface for the given image.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
CGContext for the given image.
2015-09-28 Dean Johnson <dean_johnson@apple.com>
Fix JS errors on dashboard metrics page
https://bugs.webkit.org/show_bug.cgi?id=149608
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
(initPlatformsByFamily):
(updateHiddenPlatforms):
(parsePlatformFamily): Deleted.
(updateToggleButtons): Deleted.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
(updateHiddenPlatforms): Added to remove errors.
(initPlatformsByFamily): Added to remove errors.
(unhiddenQueues): Updated to use Settings.
(documentReady): Added logic to add toggle buttons to the settings menu.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
(Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
MetricsMain.js to Settings.
(Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
MetricsMain.js to Settings.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._updateHiddenState): Updated to use Settings.
2015-09-28 Aakash Jain <aakash_jain@apple.com>
Appscale query fails because of missing index
https://bugs.webkit.org/show_bug.cgi?id=149609
Reviewed by Darin Adler.
* QueueStatusServer/index.yaml: Added the required index.
2015-09-28 Brent Fulgham <bfulgham@apple.com>
[Win] Fix the 64-bit build after switch to cmake.
Reviewed by Alex Christensen.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
run a 64-bit build.
2015-09-28 Brent Fulgham <bfulgham@apple.com>
[Win] Allow Windows to run test-webkitpy without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=149602
Reviewed by Alex Christensen.
These changes mostly shift from hard-coded paths using UNIX-style
separators to Python's "os.path.join" syntax that uses the correct
path separator for each platform.
* Scripts/webkitpy/common/system/path.py:
(cygpath): Don't pass paths through Cygpath on native Windows.
* Scripts/webkitpy/port/win.py:
(WinPort._path_to_apache): Use os.path.join.
(WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
in 64-bit environments).
* Scripts/webkitpy/style/checker.py: Use os.path.join.
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
(GlobalVariablesTest.test_path_rules_specifier): Ditto.
(GlobalVariablesTest): Ditto.
(GlobalVariablesTest.test_max_reports_per_category): Ditto.
(CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
(CheckerDispatcherDispatchTest.test_js_paths): Ditto.
(CheckerDispatcherDispatchTest.test_json_paths): Ditto.
(CheckerDispatcherDispatchTest.test_python_paths): Ditto.
(CheckerDispatcherDispatchTest.test_text_paths): Ditto.
(CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
(StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
(StyleProcessor_CodeCoverageTest): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
* Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
manual string concatenation of paths.
2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
Add bugzilla addresses of committers to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=149520
Reviewed by Darin Adler.
* Scripts/webkitpy/common/config/contributors.json:
2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
validate-committer-lists -b shouldn't need edituser privileges
https://bugs.webkit.org/show_bug.cgi?id=149519
Reviewed by Darin Adler.
* Scripts/validate-committer-lists:
(CommitterListBugzillaChecker._has_invalid_bugzilla_email):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.is_invalid_bugzilla_email):
(BugzillaQueries): Deleted.
(BugzillaQueries.fetch_logins_matching_substring): Deleted.
2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Gardening: skip media stream tests failing after r190262.
* Scripts/run-gtk-tests:
(TestRunner):
2015-09-25 Alexey Proskuryakov <ap@apple.com>
[Mac] USE_INTERNAL_SDK is used undefined in tools projects
https://bugs.webkit.org/show_bug.cgi?id=149571
Reviewed by Dan Bernstein.
Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* LayoutTestRelay/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
* WebEditingTester/Configurations/Base.xcconfig:
* WebEditingTester/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/iOS.xcconfig: Removed.
2015-09-25 Eric Carlson <eric.carlson@apple.com>
Clean up user media request internal API
https://bugs.webkit.org/show_bug.cgi?id=149527
Reviewed by Tim Horton.
* TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2015-09-25 Simon Fraser <simon.fraser@apple.com>
[iOS WK2] Add viewport tests and fix runUIScript() timing issues
https://bugs.webkit.org/show_bug.cgi?id=149577
Reviewed by Tim Horton.
When calling testRunner.runUIScript() from a page load event, the script could run
in the UI process before the current remote layer tree transaction had been handled
there. This meant that runUIScript() could query state which was about to change.
Fix by delaying the execution of the UI script until a layer tree transaction has
been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
* WebKitTestRunner/TestInvocation.h:
2015-09-25 Alexey Proskuryakov <ap@apple.com>
[Mac] Media tests start to time out after a few days of bot uptime
https://bugs.webkit.org/show_bug.cgi?id=149468
Reviewed by Darin Adler.
Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
all temporary and cache files go to a custom location.
* Scripts/webkitpy/port/base.py:
* Scripts/webkitpy/port/driver.py:
* Scripts/webkitpy/port/mac.py:
* Scripts/webkitpy/port/win.py:
(WinPort._driver_tempdir_for_environment): Deleted unused function.
2015-09-25 Dan Bernstein <mitz@apple.com>
Removed MiniBrowser.entitlements.
Rubber-stamped by Anders Carlsson.
The entitlements weren’t used anyway.
* MiniBrowser/MiniBrowser.entitlements: Removed.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2015-09-24 Daniel Bates <dabates@apple.com>
Add WebKitSystemInterface for iOS 9.0
https://bugs.webkit.org/show_bug.cgi?id=149550
Rubber-stamped by Alexey Proskuryakov.
* Scripts/copy-webkitlibraries-to-product-directory:
2015-09-24 Daniel Bates <dabates@apple.com>
Support building for arbitrary architectures
https://bugs.webkit.org/show_bug.cgi?id=149539
Reviewed by Alexey Proskuryakov.
Teach buildbot to pass the architectures associated with the builder to build-webkit
when building on OS X and iOS. As a side effect of this change we now support building
universal binaries when multiples architectures are specified.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
2015-09-24 Daniel Bates <dabates@apple.com>
Fix the build after <http://trac.webkit.org/changeset/190212>
(http://trac.webkit.org/changeset/190212)
I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
* BuildSlaveSupport/built-product-archive:
(main):
2015-09-24 Daniel Bates <dabates@apple.com>
Support running unit tests on iOS Simulator test bot
https://bugs.webkit.org/show_bug.cgi?id=149536
Reviewed by Alexey Proskuryakov.
Implements support for running unit tests on a iOS test bot. At the time of writing,
the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
(TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2015-09-24 Daniel Bates <dabates@apple.com>
Add support infrastructure for OpenSource iOS builders and testers