commit 9ae32c9b27e5c13e6903c21856a403ec7067cadd
author Mark Rousskov <mark.simulacrum@gmail.com> Wed Jan 01 14:09:50 2020 -0500
committer Mark Rousskov <mark.simulacrum@gmail.com> Mon Jan 20 11:57:27 2020 -0500
tree 4ee360c3f4a356d56f86227dcc47cde9d2f1b6cd
parent 4919b96f81d9df0a7c0fe83ad5d66cef18ddfcfb

Drop args from Formatter

These are no longer used by Formatter methods.

src/libcore/fmt/mod.rs

diff --git a/src/libcore/fmt/mod.rs b/src/libcore/fmt/mod.rs
index e76a849..900ef63 100644
--- a/src/libcore/fmt/mod.rs
+++ b/src/libcore/fmt/mod.rs
@@ -233,7 +233,6 @@
     precision: Option<usize>,
 
     buf: &'a mut (dyn Write + 'a),
-    args: &'a [ArgumentV1<'a>],
 }
 
 // NB. Argument is essentially an optimized partially applied formatting function,
@@ -1041,7 +1040,6 @@
         buf: output,
         align: rt::v1::Alignment::Unknown,
         fill: ' ',
-        args: args.args,
     };
 
     let mut idx = 0;
@@ -1060,7 +1058,7 @@
             // a string piece.
             for (arg, piece) in fmt.iter().zip(args.pieces.iter()) {
                 formatter.buf.write_str(*piece)?;
-                run(&mut formatter, arg)?;
+                run(&mut formatter, arg, &args.args)?;
                 idx += 1;
             }
         }
@@ -1074,25 +1072,24 @@
     Ok(())
 }
 
-fn run(fmt: &mut Formatter<'_>, arg: &rt::v1::Argument) -> Result {
-    // Fill in the format parameters into the formatter
+fn run(fmt: &mut Formatter<'_>, arg: &rt::v1::Argument, args: &[ArgumentV1<'_>]) -> Result {
     fmt.fill = arg.format.fill;
     fmt.align = arg.format.align;
     fmt.flags = arg.format.flags;
-    fmt.width = getcount(&fmt.args, &arg.format.width);
-    fmt.precision = getcount(&fmt.args, &arg.format.precision);
+    fmt.width = getcount(args, &arg.format.width);
+    fmt.precision = getcount(args, &arg.format.precision);
 
     // Extract the correct argument
     let value = {
         #[cfg(bootstrap)]
         {
             match arg.position {
-                rt::v1::Position::At(i) => fmt.args[i],
+                rt::v1::Position::At(i) => args[i],
             }
         }
         #[cfg(not(bootstrap))]
         {
-            fmt.args[arg.position]
+            args[arg.position]
         }
     };
 
@@ -1145,10 +1142,6 @@
             align: self.align,
             width: self.width,
             precision: self.precision,
-
-            // These only exist in the struct for the `run` method,
-            // which won’t be used together with this method.
-            args: self.args,
         }
     }