commit a97065adab02e298fa72f467b8f82c54baaba68c
author Lionel Landwerlin <lionel.g.landwerlin@intel.com> Wed Oct 25 20:09:13 2023 +0300
committer Marge Bot <emma+marge@anholt.net> Wed Oct 25 19:27:23 2023 +0000
tree 39f3cc83bcf0801c292a58283be8c6a65f159861
parent 84001ea425811cdb07c94e294f51263d9a36b778

anv: fix uninitialized use of compute initialization batch

We sometimes fail initialization.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 09d12e6727 ("anv: Add support for I915_ENGINE_CLASS_COMPUTE in init_device_state()")
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25891>

src/intel/vulkan/genX_init_state.c

diff --git a/src/intel/vulkan/genX_init_state.c b/src/intel/vulkan/genX_init_state.c
index f8bab0c..c0ca960 100644
--- a/src/intel/vulkan/genX_init_state.c
+++ b/src/intel/vulkan/genX_init_state.c
@@ -599,12 +599,13 @@
 static VkResult
 init_compute_queue_state(struct anv_queue *queue)
 {
-   struct anv_batch batch;
    UNUSED const struct intel_device_info *devinfo = queue->device->info;
-
    uint32_t cmds[64];
-   batch.start = batch.next = cmds;
-   batch.end = (void *) cmds + sizeof(cmds);
+   struct anv_batch batch = {
+      .start = cmds,
+      .next = cmds,
+      .end = (void *) cmds + sizeof(cmds),
+   };
 
    genX(emit_pipeline_select)(&batch, GPGPU);