commit 8ac86900e9faa392195f0e01cb9be576b7d5cc1b
author Dongjin Kim <dongjin_.kim@samsung.com> Tue Apr 27 18:56:50 2021 +0900
committer Brett Wilson <brettw@google.com> Sun May 16 22:21:28 2021 +0000
tree 1e327b8b4cb43aab68538f7b2f600788aab6454d
parent df8a9fffacd81d6830d67c0326a9c6c4d7010bc9

[f2fs] code refactoring:
apply c++ style casting in file.cc
(comment: #421 https://fuchsia-review.googlesource.com/c/third_party/f2fs/+/520883)

Change-Id: Iafdf9095cf20abf83c3f2d2f4c8f41d691b625b9
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/f2fs/+/528903
Reviewed-by: Brett Wilson <brettw@google.com>

file.cc

diff --git a/file.cc b/file.cc
index 11f042b..654be19 100644
--- a/file.cc
+++ b/file.cc
@@ -93,7 +93,7 @@
 #endif
   nid_t pino = 0;
 
-  vnode = (VnodeF2fs *)Igrab((void *)vnode);
+  vnode = static_cast<VnodeF2fs *>(Igrab((void *)vnode));
 #if 0  // porting needed
   // dentry = d_find_any_alias(vnode);
   // if (!dentry) {
@@ -441,14 +441,14 @@
       goto out;
     }
 
-    size_t cur_len = std::min((size_t)(kF2fsBlockSize - off_in_block), left);
+    size_t cur_len = std::min(static_cast<size_t>(kF2fsBlockSize - off_in_block), left);
     if (n == npages - 1) {
       if (i_size % kF2fsBlockSize > 0)
-        cur_len = std::min(cur_len, (size_t)(i_size % kF2fsBlockSize));
+        cur_len = std::min(cur_len, static_cast<size_t>(i_size % kF2fsBlockSize));
     }
 
     data_buf = PageAddress(data_page);
-    memcpy((char *)data + off_in_buf, data_buf, cur_len);
+    memcpy(static_cast<char *>(data) + off_in_buf, data_buf, cur_len);
 
     off_in_buf += cur_len;
     left -= cur_len;
@@ -485,20 +485,20 @@
   mtx_lock(&i_mutex);
 
   for (n = blk_start; n <= blk_end; n++) {
-    size_t cur_len = std::min((size_t)(kF2fsBlockSize - off_in_block), left);
+    size_t cur_len = std::min(static_cast<size_t>(kF2fsBlockSize - off_in_block), left);
     ret = F2fsWriteBegin(n * kF2fsBlockSize + off_in_block, cur_len, &data_page);
     if (ret) {
       goto out;
     }
 
     data_buf = PageAddress(data_page);
-    memcpy((char *)data_buf + off_in_block, (char *)data + off_in_buf, cur_len);
+    memcpy(static_cast<char *>(data_buf) + off_in_block, static_cast<const char *>(data) + off_in_buf, cur_len);
 
     off_in_buf += cur_len;
     left -= cur_len;
     off_in_block = 0;
 
-    i_size = std::max((size_t)i_size, offset + off_in_buf);
+    i_size = std::max(static_cast<size_t>(i_size), offset + off_in_buf);
 #if 0  // porting needed
     // set_page_dirty(data_page, Vfs());
 #else