commit 21f45ea06a6899db7bda54d3422c1af281a85751
author Nico Weber <thakis@chromium.org> Tue Jul 27 09:56:27 2021 -0400
committer Copybara-Service <copybara-worker@google.com> Tue Jul 27 08:01:02 2021 -0700
tree df405c40070f0d43ac89324f19e8271d493e6d30
parent 626b3b8b4d99629fd2d60caf1029178dc986b0be

Fix a few -Wunreachable-code-aggressive warnings

No behavior change.

Bug: chromium:1066980
Change-Id: I1f4ce25e0848a18557d57208097c119a24c41545
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3054401
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
GitOrigin-RevId: 058c1c2d9c82993aeb0b62e614e96698163b8165

snapshot/mac/mach_o_image_annotations_reader_test.cc

diff --git a/snapshot/mac/mach_o_image_annotations_reader_test.cc b/snapshot/mac/mach_o_image_annotations_reader_test.cc
index aea885a..cddc399 100644
--- a/snapshot/mac/mach_o_image_annotations_reader_test.cc
+++ b/snapshot/mac/mach_o_image_annotations_reader_test.cc
@@ -398,7 +398,6 @@
 
       case kCrashAbort: {
         abort();
-        break;
       }
 
       case kCrashModuleInitialization: {
@@ -411,7 +410,6 @@
         // the FAIL() will fail the test.
         ASSERT_NE(dl_handle, nullptr) << dlerror();
         FAIL();
-        break;
       }
 
       case kCrashDyld: {

util/mach/child_port_handshake_test.cc

diff --git a/util/mach/child_port_handshake_test.cc b/util/mach/child_port_handshake_test.cc
index fa7ab09..44139b1 100644
--- a/util/mach/child_port_handshake_test.cc
+++ b/util/mach/child_port_handshake_test.cc
@@ -130,7 +130,6 @@
       case TestType::kServerDies:
         // This was special-cased as an early return above.
         FAIL();
-        break;
     }
   }
 

util/posix/signals_test.cc

diff --git a/util/posix/signals_test.cc b/util/posix/signals_test.cc
index 25295ff..3538cf2 100644
--- a/util/posix/signals_test.cc
+++ b/util/posix/signals_test.cc
@@ -68,7 +68,6 @@
   switch (sig) {
     case SIGABRT: {
       abort();
-      break;
     }
 
     case SIGALRM: {
@@ -114,7 +113,6 @@
       *mapped_file.addr_as<char*>() = 0;
 
       _exit(kUnexpectedExitStatus);
-      break;
     }
 
 #if !defined(ARCH_CPU_ARM64)
@@ -143,7 +141,6 @@
     case SIGILL: {
       // __builtin_trap() causes SIGTRAP on arm64 on Android.
       __builtin_trap();
-      break;
     }
 #endif  // defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL)
 
@@ -208,7 +205,6 @@
     default: {
       LOG(ERROR) << "unexpected signal " << sig;
       _exit(kUnexpectedExitStatus);
-      break;
     }
   }
 }