commit cce357cfe98ec1737a747188c0034abd62b324c7
author Ross Wang <rosswang@google.com> Fri Oct 20 17:21:49 2017 -0700
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Sat Oct 21 02:33:43 2017 +0000
tree d8ba5dd47f933e3166808a713453f33a7d18f70e
parent 97d219556b012e2d79a66025c0849d3624140bb8

[maxwell][suggestion engine] Ranking adjustments

Adding ranking logging, and zeroing out the query-matching feature.

Change-Id: I3d60ab316f031fef657f46937c31184e3e32b8e4

bin/suggestion_engine/ranked_suggestions.cc

diff --git a/bin/suggestion_engine/ranked_suggestions.cc b/bin/suggestion_engine/ranked_suggestions.cc
index 11459e9..5684b72 100644
--- a/bin/suggestion_engine/ranked_suggestions.cc
+++ b/bin/suggestion_engine/ranked_suggestions.cc
@@ -65,6 +65,11 @@
     // zero to guarantee final confidence values stay within the 0-1 range.
     FXL_CHECK(normalization_factor_ > 0.0);
     suggestion->confidence = std::max(confidence, 0.0) / normalization_factor_;
+    FXL_LOG(INFO) << "Proposal "
+                  << suggestion->prototype->proposal->display->headline
+                  << " confidence "
+                  << suggestion->prototype->proposal->confidence << " => "
+                  << suggestion->confidence;
   }
   DoStableSort();
   channel_->DispatchInvalidate();

bin/suggestion_engine/suggestion_engine_impl.cc

diff --git a/bin/suggestion_engine/suggestion_engine_impl.cc b/bin/suggestion_engine/suggestion_engine_impl.cc
index 4b4b663..77d36c8 100644
--- a/bin/suggestion_engine/suggestion_engine_impl.cc
+++ b/bin/suggestion_engine/suggestion_engine_impl.cc
@@ -79,13 +79,13 @@
 
   // Set up the next ranking features
   next_suggestions_->AddRankingFeature(1.0, proposal_hint_feature);
-  next_suggestions_->AddRankingFeature(-0.2, kronk_feature);
+  next_suggestions_->AddRankingFeature(-0.1, kronk_feature);
 
   // Set up the query ranking features
   ask_suggestions_->AddRankingFeature(1.0, proposal_hint_feature);
-  ask_suggestions_->AddRankingFeature(-0.2, kronk_feature);
+  ask_suggestions_->AddRankingFeature(-0.1, kronk_feature);
   ask_suggestions_->AddRankingFeature(
-      1.0, std::make_shared<QueryMatchRankingFeature>());
+      0, std::make_shared<QueryMatchRankingFeature>());
 }
 
 void SuggestionEngineImpl::AddNextProposal(ProposalPublisherImpl* source,