commit ca5ffff6f90d53742e346e226a49460058e3606d
author Gabriel Schine <thatguy@google.com> Thu Jan 03 10:36:59 2019 -0800
committer Gabe Schine <thatguy@google.com> Thu Jan 03 23:56:04 2019 +0000
tree 649172dd2f4fa74740116bc308944bbc57504908
parent 11721e798c13394eeb5164da2ae18c41f2fb6731

[modular][sessionctl] Look for the component-version of basemgr.

Also:
* Print a nicer error when we can't find a basemgr instance in the first
place.

TEST=manual
MF-158 #done
MF-158 #comment [modular][sessionctl] Look for the component-version of basemgr.

Change-Id: I52aaa91fe6e6aa8f25dc7af588f7d1b1c4e502e4

bin/sessionctl/main.cc

diff --git a/bin/sessionctl/main.cc b/bin/sessionctl/main.cc
index 4ee5456..ffa5a3d 100644
--- a/bin/sessionctl/main.cc
+++ b/bin/sessionctl/main.cc
@@ -148,9 +148,12 @@
   auto request = basemgr.NewRequest().TakeChannel();
 
   std::vector<DebugService> services;
-  FindDebugServicesForPath("/hub/c/basemgr/*/out/debug/basemgr", "basemgr",
-                           &services);
-  // There should only be one basemgr
+  FindDebugServicesForPath("/hub/c/basemgr.cmx/*/out/debug/basemgr",
+                           "basemgr.cmx", &services);
+
+  if (services.empty()) {
+    return nullptr;
+  }
   FXL_CHECK(services.size() == 1);
 
   std::string service_path = services[0].service_path;
@@ -172,8 +175,14 @@
 
   const modular::Logger logger(
       command_line.HasOption(modular::kJsonOutFlagString));
-  auto sessions = FindAllSessions();
 
+  auto basemgr = ConnectToBasemgr();
+  if (!basemgr) {
+    logger.LogError(cmd, "Could not find a running basemgr. Is it running?");
+    return 1;
+  }
+
+  auto sessions = FindAllSessions();
   if (sessions.empty()) {
     logger.LogError(
         cmd, "Could not find a running sessionmgr. Is the user logged in?");
@@ -189,8 +198,6 @@
     std::cout << std::endl;
   }
 
-  auto basemgr = ConnectToBasemgr();
-
   // To get a PuppetMaster service for a session, use the following code:
   PuppetMasterPtr puppet_master = ConnectToPuppetMaster(sessions[0]);