[benchmarks] Bring number of page requests in add_new_page back to 500.
Now that LE-425 is closed, we can run this benchmark with a bigger
ammount of requests.
Note: that will create some friction on the dashboard as the name of the
measurement will change from get_page_samples_1_to_49 to
get_page_samples_1_to_499.
TEST=On CQ (peridot-x64-perf-dawson_canyon)
Change-Id: I0d49d70ac8d842939248e841e77893963b2a8062
diff --git a/bin/ledger/tests/benchmark/BUILD.gn b/bin/ledger/tests/benchmark/BUILD.gn
index 8cf9355..34ed4dd 100644
--- a/bin/ledger/tests/benchmark/BUILD.gn
+++ b/bin/ledger/tests/benchmark/BUILD.gn
@@ -106,11 +106,6 @@
},
{
- path = rebase_path("get_page/add_many_pages.tspec")
- dest = "add_many_pages.tspec"
- },
-
- {
path = rebase_path("get_page/add_new_page_precached.tspec")
dest = "add_new_page_precached.tspec"
},
diff --git a/bin/ledger/tests/benchmark/README.md b/bin/ledger/tests/benchmark/README.md
index 48b6911..d8bf09b 100644
--- a/bin/ledger/tests/benchmark/README.md
+++ b/bin/ledger/tests/benchmark/README.md
@@ -88,8 +88,6 @@
ID.
* `add_new_page_precached.tspec`: same as above, but waits for a precached
Ledger Page to be ready before each request.
- * `add_many_pages.tspec`: same as `add_new_page`, but with a bigger number
- of requests.
* `get_same_page.tspec`: several connections to the same page
* `get_page_id.tspec`: how long does the GetId() call takes on a newly
created page?
diff --git a/bin/ledger/tests/benchmark/get_page/add_many_pages.tspec b/bin/ledger/tests/benchmark/get_page/add_many_pages.tspec
deleted file mode 100644
index aa2e65d..0000000
--- a/bin/ledger/tests/benchmark/get_page/add_many_pages.tspec
+++ /dev/null
@@ -1,17 +0,0 @@
-{
- "test_suite_name": "fuchsia.ledger.add_page",
- "app": "fuchsia-pkg://fuchsia.com/ledger_benchmarks#meta/get_page.cmx",
- "args": ["--requests-count=500"],
- "categories": ["benchmark", "ledger"],
- "duration": 120,
- "measure": [
- {
- "type": "duration",
- "output_test_name": "many_new_pages/get_page",
- "event_name": "get page",
- "event_category": "benchmark",
- "expected_sample_count": 500,
- "split_first": true
- }
- ]
-}
diff --git a/bin/ledger/tests/benchmark/get_page/add_new_page.tspec b/bin/ledger/tests/benchmark/get_page/add_new_page.tspec
index e9f6d68..d8a747a 100644
--- a/bin/ledger/tests/benchmark/get_page/add_new_page.tspec
+++ b/bin/ledger/tests/benchmark/get_page/add_new_page.tspec
@@ -1,7 +1,7 @@
{
"test_suite_name": "fuchsia.ledger.get_page",
"app": "fuchsia-pkg://fuchsia.com/ledger_benchmarks#meta/get_page.cmx",
- "args": ["--requests-count=50"],
+ "args": ["--requests-count=500"],
"categories": ["benchmark", "ledger"],
"duration": 120,
"measure": [
@@ -10,7 +10,7 @@
"output_test_name": "new_page/get_page",
"event_name": "get page",
"event_category": "benchmark",
- "expected_sample_count": 50,
+ "expected_sample_count": 500,
"split_first": true
},
{
@@ -18,7 +18,7 @@
"output_test_name": "new_page/precache_db",
"event_name": "prepare_cached_db",
"event_category": "ledger",
- "expected_sample_count": 50,
+ "expected_sample_count": 500,
"split_first": true
}
]
diff --git a/tests/benchmarks/benchmarks.sh b/tests/benchmarks/benchmarks.sh
index 7919a75..a4d6578 100644
--- a/tests/benchmarks/benchmarks.sh
+++ b/tests/benchmarks/benchmarks.sh
@@ -16,12 +16,6 @@
# Run "local" Ledger benchmarks. These don't need external services to function
# properly.
-# TODO(LE-425): Fix & re-enable this test.
-# runbench_exec "${OUT_DIR}/ledger.add_many_pages.json" \
-# trace record \
-# --spec-file=/pkgfs/packages/ledger_benchmarks/0/data/DISABLED_add_many_pages.tspec \
-# --benchmark-results-file="${OUT_DIR}/ledger.add_many_pages.json"
-
runbench_exec "${OUT_DIR}/ledger.add_new_page_precached.json" \
trace record \
--spec-file=/pkgfs/packages/ledger_benchmarks/0/data/add_new_page_precached.tspec \
