[media][codecs] Typo fixes.
TEST: No behavior change
Change-Id: I2ca607d0c144205676ce7c90336daca5ffe4fb83
diff --git a/bin/media/codec_factory/codec_factory_app.h b/bin/media/codec_factory/codec_factory_app.h
index e241ce4..4f52ac9 100644
--- a/bin/media/codec_factory/codec_factory_app.h
+++ b/bin/media/codec_factory/codec_factory_app.h
@@ -65,7 +65,7 @@
// binding, which will close the channel and delete the CodecFactory.
// This is true despite comments in the binding code that constantly say how
// ImplPtr isn't taking ownership; as long as we use std::unique_ptr as
- // ImplPtr it actaully willl take ownership.
+ // ImplPtr it actually will take ownership.
//
// We create a new instance of CodecFactory for each interface request,
// because CodecFactory's implementation isn't stateless, by design, for
diff --git a/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.cc b/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.cc
index 075a272..f0d54af 100644
--- a/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.cc
+++ b/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.cc
@@ -262,7 +262,7 @@
}
} else {
assert(i == 2);
- // Avoid caring which specific error is reutrn for port index 2, but it
+ // Avoid caring which specific error is return for port index 2, but it
// shouldn't succeed.
if (omx_result == OMX_ErrorNone) {
// For now, bail out if we don't find exactly two ports. There might
@@ -512,7 +512,7 @@
// default_settings
//
- // Inititial input buffer_lifetime_ordinal of 1 is ok. It's also
+ // Initial input buffer_lifetime_ordinal of 1 is ok. It's also
// ok if it's any larger odd number, but 1 is the best choice.
.default_settings.buffer_lifetime_ordinal =
kBestFirstBufferLifetimeOrdinal,
@@ -939,7 +939,7 @@
} break;
case OMX_AUDIO_CodingAAC:
// TODO(dustingreen): implement, at least for AAC encode
- // fallthough for now
+ // fallthrough for now
default:
Exit("unhandled OMX output format - value: %d",
omx_audio_param_port_format.eEncoding);
@@ -966,7 +966,7 @@
// intentional copy
//
// We're stashing this structure from here because this method happens to be
- // the common code path invovled in all OMX updates of the output port
+ // the common code path involved in all OMX updates of the output port
// definition where constraints might change which we need to pay attention
// to later. Mainly we care about nBufferSize.
omx_port_def_[kOutput] = result->definition;
@@ -1272,7 +1272,7 @@
//
// We (in general) lie to OMX about the size being at least
// OMX_PARAM_PORTDEFINITIONTYPE.nBufferSize when allocating an OMX
- // buffer for this packet, then we don't actaully fill beyond
+ // buffer for this packet, then we don't actually fill beyond
// kMaxCodecOobBytesSize.
//
// We don't really care about OMX_PARAM_PORTDEFINITIONTYPE.nBufferSize
@@ -2719,7 +2719,7 @@
// This is what starts the interval during which
// OmxTryRecycleOutputPacketLocked() won't call OMX, and the interval during
- // which we'll ingore any in-progress client output config until the client
+ // which we'll ignore any in-progress client output config until the client
// catches up.
StartIgnoringClientOldOutputConfigLocked();
@@ -2848,7 +2848,7 @@
void OmxCodecRunner::OmxWaitForOutputBuffersDoneReturning(
std::unique_lock<std::mutex>& lock) {
- // We only actaully call this when !omx_output_enabled_desired_, but there
+ // We only actually call this when !omx_output_enabled_desired_, but there
// wouldn't be any harm in calling it during move out of executing, so allow
// that.
assert(!omx_output_enabled_desired_ ||
@@ -3202,7 +3202,7 @@
// This method can be called on input only if there's no current stream.
//
// On output, this method can be called if there's no current stream or if
- // we're in the middle of an ouput config change.
+ // we're in the middle of an output config change.
//
// On input, this can only be called on stream_control_thread_.
//
diff --git a/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.h b/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.h
index 2f015d0..c91f189 100644
--- a/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.h
+++ b/bin/media/codecs/sw/omx/codec_runner_sw_omx/omx_codec_runner.h
@@ -83,7 +83,7 @@
// responsiveness benefits to queueing state change work to a separate
// state-driving thread, to do with being able to notice that
// previously-dequeued messages can be safely ignored/skipped, but at the
-// moment any such benefits seem unlikely to be signficant enough to justify
+// moment any such benefits seem unlikely to be significant enough to justify
// the complexity increase that would imply.
// * "OMX thread" - The OMX codec has its own primary thread. Calls to
// EventHandler() method of this class can come from the OMX thread or from
@@ -103,7 +103,7 @@
// OmxCodecRunner.
//
// Queueing of input data and output data helps pipeline and avoids stalling
-// data processing thread(s) unecessarily. Input packets arrive ordered on the
+// data processing thread(s) unnecessarily. Input packets arrive ordered on the
// channel and we call the OMX codec directly from there to queue those input
// packets over to the OMX primary thread. Output data is emitted in order from
// the OMX codec using the OMX primary thread - we queue first to the async_t
@@ -408,7 +408,7 @@
bool future_discarded_ = false;
bool future_flush_end_of_stream_ = false;
// Starts as nullptr for each new stream with implicit fallback to
- // initial_input_format_details_, but can be overriden on a per-stream basis
+ // initial_input_format_details_, but can be overridden on a per-stream basis
// with QueueInputFormatDetails().
std::unique_ptr<fuchsia::mediacodec::CodecFormatDetails>
input_format_details_;
@@ -486,7 +486,7 @@
// If we find ourselves trying to get rid of as many thread switches as
// possible, we could refactor this class's implementation of the
// StreamControl ordering domain to not always use a separate thread (some
- // complexity cost), or even to never use a separate thread (more complextiy
+ // complexity cost), or even to never use a separate thread (more complexity
// cost).
//
// We also handle OMX_EventPortSettingsChanged on the stream_control_ thread
@@ -582,7 +582,7 @@
std::unique_ptr<fuchsia::mediacodec::CodecFormatDetails>
initial_input_format_details_;
- // This is the most recent settings recieved from the client and accepted,
+ // This is the most recent settings received from the client and accepted,
// received via SetInputBufferSettings() or SetOutputBufferSettings(). The
// settings are as-received from the client.
std::unique_ptr<const fuchsia::mediacodec::CodecPortBufferSettings>
@@ -601,7 +601,7 @@
// OnOutputConfig() based on current OMX output config. We do this at next
// stream start rather than between streams so the client is forced to pay
// attention to the OnOutputConfig(). The client might de-configure and
- // re-configure a few times based on the most recent OnOuputConfig(), so we
+ // re-configure a few times based on the most recent OnOutputConfig(), so we
// need to associate this with the buffer_constraints_ordinal that OMX said
// meh to.
//
@@ -626,7 +626,7 @@
uint64_t next_output_format_details_version_ordinal_ = 1;
// Separately from ordinal allocation, we track the most recent ordinal that
- // we've actually sent to the client, to allow tigher protocol enforcement in
+ // we've actually sent to the client, to allow tighter protocol enforcement in
// case of a hostile client.
uint64_t sent_buffer_constraints_version_ordinal_[kPortCount] = {0};
uint64_t sent_format_details_version_ordinal_[kPortCount] = {0};
diff --git a/bin/media/codecs/sw/omx/common/omx_android_pal/BUILD.gn b/bin/media/codecs/sw/omx/common/omx_android_pal/BUILD.gn
index 6a1feea..197ec61 100644
--- a/bin/media/codecs/sw/omx/common/omx_android_pal/BUILD.gn
+++ b/bin/media/codecs/sw/omx/common/omx_android_pal/BUILD.gn
@@ -30,7 +30,7 @@
source_set("android_non_media_headers_source_set") {
visibility = [ ":*" ]
- # Not sure if this actaully limits included headers to only this list, but
+ # Not sure if this actually limits included headers to only this list, but
# that's the intent.
public = [
"//third_party/android/platform/system/core/libutils/include/utils/RefBase.h",
diff --git a/drivers/video/amlogic-decoder/codec_adapter_h264.cc b/drivers/video/amlogic-decoder/codec_adapter_h264.cc
index a821259..6254718 100644
--- a/drivers/video/amlogic-decoder/codec_adapter_h264.cc
+++ b/drivers/video/amlogic-decoder/codec_adapter_h264.cc
@@ -33,7 +33,7 @@
// partial input packets to permit large input packets with many AUs in
// them.
// * At least when promise_separate_access_units_on_input is set, propagate
-// timstamp_ish values from input AU to correct output video frame (using
+// timestamp_ish values from input AU to correct output video frame (using
// PtsManager).
// * Consider if there's a way to get AmlogicVideo to re-use buffers across
// a stream switch without over-writing buffers that are still in-use
@@ -353,7 +353,7 @@
// TODO(dustingreen): Use scrambled free_packet_list_ like for VP9, and put
// packet back on the free list here (and update comment above re. when re-use
- // of the paket can happen). For now for this codec we let packet_index ==
+ // of the packet can happen). For now for this codec we let packet_index ==
// buffer_index to split the separation of buffer_index from packet_index into
// smaller changes.
diff --git a/drivers/video/amlogic-decoder/device_fidl.h b/drivers/video/amlogic-decoder/device_fidl.h
index e48cc9e..833ec6b 100644
--- a/drivers/video/amlogic-decoder/device_fidl.h
+++ b/drivers/video/amlogic-decoder/device_fidl.h
@@ -56,7 +56,7 @@
// LocalCodecFactory. That removal happens on shared_fidl_thread(), as does
// other LocalCodecFactory work.
//
- // We allow more than 1 in this set at least to accomodate races if the main
+ // We allow more than 1 in this set at least to accommodate races if the main
// CodecFactory restarts. It's also fine if the main CodecFactory wants to
// use more than one for convenience and/or to get more coverage on the
// >1 case here.
diff --git a/drivers/video/amlogic-decoder/driver_ctx.cc b/drivers/video/amlogic-decoder/driver_ctx.cc
index 6d89696..4abfa35 100644
--- a/drivers/video/amlogic-decoder/driver_ctx.cc
+++ b/drivers/video/amlogic-decoder/driver_ctx.cc
@@ -70,7 +70,7 @@
DriverCtx::DriverCtx() {
// We use kAsyncLoopConfigNoAttachToThread here, because we don't really want
- // to be setting the default async_t for the the thread that creates the
+ // to be setting the default async_t for the thread that creates the
// DriverCtx. We'll plumb async_t(s) explicitly instead.
shared_fidl_loop_ =
std::make_unique<async::Loop>(&kAsyncLoopConfigNoAttachToThread);
diff --git a/drivers/video/amlogic-decoder/local_codec_factory.cc b/drivers/video/amlogic-decoder/local_codec_factory.cc
index c0cc14e..22fee1b 100644
--- a/drivers/video/amlogic-decoder/local_codec_factory.cc
+++ b/drivers/video/amlogic-decoder/local_codec_factory.cc
@@ -30,7 +30,7 @@
};
// TODO(dustingreen): Fix up this list to correspond to what
-// CodecImpl+AmlogicVideo can actaully handle so far, once there's at least one
+// CodecImpl+AmlogicVideo can actually handle so far, once there's at least one
// format in that list. For now this list is here to allow covering some
// LocalCodecFactory code.
const CodecAdapterFactory kCodecFactories[] = {
diff --git a/drivers/video/amlogic-decoder/tests/manual/test_amlogic_codec_factory.cc b/drivers/video/amlogic-decoder/tests/manual/test_amlogic_codec_factory.cc
index 26bd369..d4222a3 100644
--- a/drivers/video/amlogic-decoder/tests/manual/test_amlogic_codec_factory.cc
+++ b/drivers/video/amlogic-decoder/tests/manual/test_amlogic_codec_factory.cc
@@ -26,7 +26,7 @@
}
void test_factory() {
- // We don't just use Sync FIDL proxies because we might need to recieve events
+ // We don't just use Sync FIDL proxies because we might need to receive events
// before long.
async::Loop fidl_loop(&kAsyncLoopConfigNoAttachToThread);
diff --git a/drivers/video/amlogic-decoder/vp9_decoder.cc b/drivers/video/amlogic-decoder/vp9_decoder.cc
index acf112f..9adfe6a 100644
--- a/drivers/video/amlogic-decoder/vp9_decoder.cc
+++ b/drivers/video/amlogic-decoder/vp9_decoder.cc
@@ -538,7 +538,7 @@
// signals that the previous frame finished decoding.
kProcessedHeader = 0xf0,
- // Sent from the host to the device to say that the last interupt has been
+ // Sent from the host to the device to say that the last interrupt has been
// processed.
kVp9ActionDone = 0xff,
};
diff --git a/lib/media/codec_impl/codec_impl.cc b/lib/media/codec_impl/codec_impl.cc
index 0aa105b..fb3bc5b 100644
--- a/lib/media/codec_impl/codec_impl.cc
+++ b/lib/media/codec_impl/codec_impl.cc
@@ -12,8 +12,8 @@
#include <threads.h>
-// "is_bound_checks" - In serveral lamdas that just send a message, we check
-// is_bound() first, only becaues of ZX_POL_BAD_HANDLE ZX_POL_ACTION_EXCEPTION.
+// "is_bound_checks" - In several lambdas that just send a message, we check
+// is_bound() first, only because of ZX_POL_BAD_HANDLE ZX_POL_ACTION_EXCEPTION.
// If it weren't for that, we really wouldn't care about passing
// ZX_HANDLE_INVALID to zx_channel_write(), since the channel error handling is
// async (we Unbind(), sweep the in-proc send queue, and only then delete the
@@ -212,7 +212,7 @@
"StreamControl_loop", &stream_control_thread_);
if (start_thread_result != ZX_OK) {
// Handle the error async, to be consistent with later errors that must
- // occur async anyway. Inability to start StreamControl is tne only case
+ // occur async anyway. Inability to start StreamControl is the only case
// where we just allow the owner to "delete this" without using
// UnbindLocked(), since UnbindLocked() relies on StreamControl.
PostToSharedFidl(std::move(error_handler));
@@ -595,7 +595,7 @@
// Before handing the packet to the core codec, clear some fields that the
// core codec is expected to set (or optionally set in the case of
- // timstamp_ish). In addition to these parameters, a core codec can emit
+ // timestamp_ish). In addition to these parameters, a core codec can emit
// output config changes via onCoreCodecMidStreamOutputConfigChange().
packet = all_packets_[kOutputPort][packet_index].get();
packet->ClearStartOffset();
@@ -925,7 +925,7 @@
// Regardless of what thread UnbindLocked() is called on, "this" will remain
// allocated at least until the caller of UnbindLocked() releases lock_.
//
- // The shutdown sequence here is meant to be general enough to accomodate code
+ // The shutdown sequence here is meant to be general enough to accommodate code
// changes without being super brittle. Not all the potential cases accounted
// for in this sequence can necessarily happen currently, but it seems good to
// stop all activity in a way that'll hold up even if a change posts another
@@ -1041,7 +1041,7 @@
//
// For example, any lambdas previously posted to send a message via
// this->binding_ (which is soon to be deleted) will run before the lambda
- // postead here.
+ // posted here.
//
// This relies on other previously-posted _lambdas_ running on
// fidl_thread() re. this CodecImpl to not re-post to the fidl_thread().
@@ -1159,7 +1159,7 @@
// This method can be called on input only if there's no current stream.
//
// On output, this method can be called if there's no current stream or if
- // we're in the middle of an ouput config change.
+ // we're in the middle of an output config change.
//
// On input, this can only be called on stream_control_thread_.
//
@@ -1178,7 +1178,7 @@
// For mid-stream output config change, the caller is responsible for ensuring
// that buffers are not with the HW first.
//
- // TODO(dustingreen): Check anything relelvant to buffers not presently being
+ // TODO(dustingreen): Check anything relevant to buffers not presently being
// with the HW.
// ZX_DEBUG_ASSERT(all_packets_[port].empty() ||
// !all_packets_[port][0]->is_with_hw());
@@ -1452,7 +1452,7 @@
// Given the above, our *main concern* here is that we get to a state where we
// *know* the client isn't trying to re-configure output during format
// detection, which at best would be confusing to allow, so we avoid that
- // possiblity here by forcing a client to catch up with the server, if there's
+ // possibility here by forcing a client to catch up with the server, if there's
// *any possibility* that the client might still be working on catching up
// with the server.
//
@@ -1602,7 +1602,7 @@
//
// More complete protocol validation happens on StreamControl ordering domain.
// The validation here is just to validate to degree needed to not break our
-// stream_queue_ and future_stream_lifetime_ordainal_.
+// stream_queue_ and future_stream_lifetime_ordinal_.
bool CodecImpl::EnsureFutureStreamSeenLocked(uint64_t stream_lifetime_ordinal) {
if (future_stream_lifetime_ordinal_ == stream_lifetime_ordinal) {
return true;
@@ -1634,7 +1634,7 @@
//
// More complete protocol validation happens on StreamControl ordering domain.
// The validation here is just to validate to degree needed to not break our
-// stream_queue_ and future_stream_lifetime_ordainal_.
+// stream_queue_ and future_stream_lifetime_ordinal_.
bool CodecImpl::EnsureFutureStreamCloseSeenLocked(
uint64_t stream_lifetime_ordinal) {
if (future_stream_lifetime_ordinal_ % 2 == 0) {
@@ -1675,7 +1675,7 @@
//
// More complete protocol validation happens on StreamControl ordering domain.
// The validation here is just to validate to degree needed to not break our
-// stream_queue_ and future_stream_lifetime_ordainal_.
+// stream_queue_ and future_stream_lifetime_ordinal_.
bool CodecImpl::EnsureFutureStreamFlushSeenLocked(
uint64_t stream_lifetime_ordinal) {
if (stream_lifetime_ordinal != future_stream_lifetime_ordinal_) {
@@ -1879,7 +1879,7 @@
// This is what starts the interval during which
// OmxTryRecycleOutputPacketLocked() won't call OMX, and the interval during
- // which we'll ingore any in-progress client output config until the client
+ // which we'll ignore any in-progress client output config until the client
// catches up.
StartIgnoringClientOldOutputConfig(lock);
@@ -2120,7 +2120,7 @@
if (stream_->output_end_of_stream()) {
// Tolerate a CodecAdapter failing the stream after output EndOfStream
- // seen, and avoid notifying the cient of a stream failure that's too late
+ // seen, and avoid notifying the client of a stream failure that's too late
// to matter.
return;
}
diff --git a/lib/media/codec_impl/codec_packet.cc b/lib/media/codec_impl/codec_packet.cc
index b68aa27..799f040 100644
--- a/lib/media/codec_impl/codec_packet.cc
+++ b/lib/media/codec_impl/codec_packet.cc
@@ -55,7 +55,7 @@
}
// 0 is a valid value - it's !has_timestamp_ish_ that actually matters here.
-// However, set timstamp_ish_ to 0 anyway just to make it a little more obvious
+// However, set timestamp_ish_ to 0 anyway just to make it a little more obvious
// that !has_timestamp_ish_.
void CodecPacket::ClearTimestampIsh() {
has_timestamp_ish_ = false;
diff --git a/lib/media/codec_impl/include/lib/media/codec_impl/codec_adapter.h b/lib/media/codec_impl/include/lib/media/codec_impl/codec_adapter.h
index 1ba46a8..e16e0e3 100644
--- a/lib/media/codec_impl/include/lib/media/codec_impl/codec_adapter.h
+++ b/lib/media/codec_impl/include/lib/media/codec_impl/codec_adapter.h
@@ -73,7 +73,7 @@
// different input formats that are better to think of as a completely
// different Codec.
//
- // A client that's using different CodecFormatDetails than the inital
+ // A client that's using different CodecFormatDetails than the initial
// CodecFormatDetails (to any degree) should try one more time with a fresh
// Codec before giving up (giving up immediately only if the format details at
// time of failure match the initial format details specified during Codec
@@ -120,11 +120,11 @@
// The parameter includes the codec_oob_bytes. The core codec is free to call
// onCoreCodecFailCodec() (immediately on this stack or async) if the
- // override input format details can't be accomodated (even in situations
+ // override input format details can't be accommodated (even in situations
// where the override input format details would be ok as initial input format
// details, such as when new input buffer config is needed).
//
- // That said, the core codec should try to accomodate the change, especially
+ // That said, the core codec should try to accommodate the change, especially
// if the client has configured adequate input buffers, and the basic type of
// the input data hasn't changed.
//
@@ -240,14 +240,14 @@
// output buffers (considering separately, width, height, and any other
// similar parameter like color depth) are already large enough for both the
// before format and after format. If this is not the case, a codec is
- // permitted, but not encouranged, to discard some output frames. A codec is
- // also permitted to achive a more seamless format switch despite output
+ // permitted, but not encouraged, to discard some output frames. A codec is
+ // also permitted to achieve a more seamless format switch despite output
// buffer re-config by retaining references to old-format low-level buffers,
// copying into temporary buffers and back out, or similar. However, core
// codec implementers should note that the process of re-configuring output
// buffers is not likely to be super-quick, and other parts of the system may
// not go to so much effort to achieve seamless-ness across an output buffer
- // re-config, so ... it's probably best not to spend time trying to achive
+ // re-config, so ... it's probably best not to spend time trying to achieve
// seamless-ness for a situation which for other reasons might end up being
// non-seamless at least in terms of timing consistency in any case.
//
diff --git a/lib/media/codec_impl/include/lib/media/codec_impl/codec_impl.h b/lib/media/codec_impl/include/lib/media/codec_impl/codec_impl.h
index cdd6805..84e377d 100644
--- a/lib/media/codec_impl/include/lib/media/codec_impl/codec_impl.h
+++ b/lib/media/codec_impl/include/lib/media/codec_impl/codec_impl.h
@@ -83,7 +83,7 @@
// format change it wants to reject. Before giving up, a client that uses
// per-stream input format overrides should go around one more time with a
// freshly created Codec created directly with the new format if the client
- // gets a Codec failure having overriden the input format on a stream of a
+ // gets a Codec failure having overridden the input format on a stream of a
// Codec such that the stream's input format doesn't exactly match the Codec's
// input format (at least for now).
void SetCoreCodecAdapter(std::unique_ptr<CodecAdapter> codec_adapter);
@@ -218,7 +218,7 @@
bool future_discarded_ = false;
bool future_flush_end_of_stream_ = false;
// Starts as nullptr for each new stream with implicit fallback to
- // initial_input_format_details_, but can be overriden on a per-stream basis
+ // initial_input_format_details_, but can be overridden on a per-stream basis
// with QueueInputFormatDetails().
std::unique_ptr<fuchsia::mediacodec::CodecFormatDetails>
input_format_details_;
@@ -436,7 +436,7 @@
std::unique_ptr<const fuchsia::mediacodec::CodecBufferConstraints>
input_constraints_;
- // This is the most recent settings recieved from the client and accepted,
+ // This is the most recent settings received from the client and accepted,
// received via SetInputBufferSettings() or SetOutputBufferSettings(). The
// settings are as-received from the client.
std::unique_ptr<const fuchsia::mediacodec::CodecPortBufferSettings>
@@ -499,7 +499,7 @@
uint64_t next_output_format_details_version_ordinal_ = 1;
// Separately from ordinal allocation, we track the most recent ordinal that
- // we've actually sent to the client, to allow tigher protocol enforcement in
+ // we've actually sent to the client, to allow tighter protocol enforcement in
// case of a hostile client.
uint64_t sent_buffer_constraints_version_ordinal_[kPortCount] = {};
uint64_t sent_format_details_version_ordinal_[kPortCount] = {};
@@ -539,7 +539,7 @@
//
// More complete protocol validation happens on StreamControl ordering domain.
// The validation here is just to validate to degree needed to not break our
- // stream_queue_ and future_stream_lifetime_ordainal_.
+ // stream_queue_ and future_stream_lifetime_ordinal_.
//
// Returns true if it worked. Returns false if FailLocked() has already been
// called, in which case the caller probably wants to just return.
@@ -551,7 +551,7 @@
//
// More complete protocol validation happens on StreamControl ordering domain.
// The validation here is just to validate to degree needed to not break our
- // stream_queue_ and future_stream_lifetime_ordainal_.
+ // stream_queue_ and future_stream_lifetime_ordinal_.
//
// Returns true if it worked. Returns false if FailLocked() has already been
// called, in which case the caller probably wants to just return.
@@ -670,7 +670,7 @@
// "Mid-stream" can mean at the start of a stream also - it's just required
// that a stream be active currently. The core codec must ensure that this
- // call is propertly ordered with respect to onCoreCodecOutputPacket() and
+ // call is properly ordered with respect to onCoreCodecOutputPacket() and
// onCoreCodecOutputEndOfStream() calls.
//
// A call to onCoreCodecMidStreamOutputConfigChange(true) must not be
diff --git a/public/fidl/fuchsia.mediacodec/codec.fidl b/public/fidl/fuchsia.mediacodec/codec.fidl
index 0575029..7afaf8d 100644
--- a/public/fidl/fuchsia.mediacodec/codec.fidl
+++ b/public/fidl/fuchsia.mediacodec/codec.fidl
@@ -62,7 +62,7 @@
//
// A buffer_constraints_version_ordinal of 0 is not permitted, to simplify
// initial state handling. Other than 0, both odd and even version ordinals
- // are allowed (in constrast to the stream_lifetime_ordinal, neither the
+ // are allowed (in contrast to the stream_lifetime_ordinal, neither the
// client nor server ever has a reason to consider the latest version to be
// stale, so there would be no benefit to disallowing even values).
uint64 buffer_constraints_version_ordinal;
@@ -99,7 +99,7 @@
// CodecPortBufferSettings.buffer_lifetime_ordinal.
CodecPortBufferSettings default_settings;
- // For uncompresesd video, separate and complete frames, each in its own
+ // For uncompressed video, separate and complete frames, each in its own
// separate buffer (buffer-per-packet mode), is always a requirement.
// per_packet_buffer_bytes.*:
@@ -168,7 +168,7 @@
// This can be the same as packet_count_for_codec_max or can be lower.
// Values above this value and <= packet_count_for_codec_max are not
- // recommended by the codec, but should still work given sufficient resoures
+ // recommended by the codec, but should still work given sufficient resources
// available to both the client and the codec.
uint32 packet_count_for_codec_recommended_max;
@@ -244,9 +244,9 @@
// hopefully. It's stuff the codec gets to control, not the client. It's
// different than output buffer settings, which the client does get to control
// to some extent. It's different than any configurable output settings the
-// client might specifiy for output of an encoder.
+// client might specify for output of an encoder.
struct CodecOutputConfig {
- // A client which always immediately re-configures output buffers on reciept
+ // A client which always immediately re-configures output buffers on receipt
// of OnOutputConfig() with buffer_constraints_action_required true can safely
// ignore this field.
//
@@ -256,7 +256,7 @@
// stream_lifetime_ordinal or if this stream_lifetime_ordinal field is set to
// 0. The server is required to re-send needed output config via
// OnOutputConfig() with new stream_lifetime_ordinal and
- // buffer_constraints_action_required true, if the the most recent completed
+ // buffer_constraints_action_required true, if the most recent completed
// server-side output config isn't what the server wants/needs yet for the
// new stream.
uint64 stream_lifetime_ordinal;
@@ -276,7 +276,7 @@
// buffer_constraints_version_ordinal.
//
// For each configuration, a client must use new buffers, never buffers that
- // were prevoiusly used for anything else, and never buffers previously used
+ // were previously used for anything else, and never buffers previously used
// for any other Codec purposes. This rule exists for multiple good reasons,
// relevant to both mid-stream changes, and changes on stream boundaries.
// A client should just use new buffers each time.
@@ -415,7 +415,7 @@
// only increase (increasing by more than 2 is permitted).
//
// A buffer_lifetime_ordinal lifetime starts at SetInputBufferSettings() or
- // SetOutputBufferSettings(), and ends at the the earlier of
+ // SetOutputBufferSettings(), and ends at the earlier of
// CloseCurrentStream() with release_input_buffers/release_output_buffers set
// or SetOutputBufferSettings() with new buffer_lifetime_ordinal in the case
// of mid-stream output config change.
@@ -446,7 +446,7 @@
// how many packets are allocated for the server to hold onto for whatever
// reason.
//
- // Extra packets to provide slack for peformance reasons can be in either
+ // Extra packets to provide slack for performance reasons can be in either
// category, but typically packet_count_for_codec_recommended will already
// include any performance-relevant slack for the server's benefit.
@@ -489,7 +489,7 @@
// parts of the overall system that will be holding onto packets for any
// reason. Those parts of the system should have a documented and possibly
// queryable defined value to help determine this number. Setting this value
- // lower than it actaully needs to be can result in the codec not making
+ // lower than it actually needs to be can result in the codec not making
// progress as it sits waiting for packets, with the client unable to recycle
// any more packets to the codec. That situation can be difficult to
// diagnose, while excessively-large values here are wasteful, so care is
@@ -622,7 +622,7 @@
// For QueueInputPacket(), a server receiving a buffer_lifetime_ordinal that
// isn't the current input buffer_lifetime_ordinal will close the channel.
//
- // For OnFreeInputPacket() and RecycleOutputPacket(), the reciever (client or
+ // For OnFreeInputPacket() and RecycleOutputPacket(), the receiver (client or
// server) must ignore a message with stale buffer_lifetime_ordinal.
uint64 buffer_lifetime_ordinal;
@@ -698,7 +698,7 @@
//
// For compressed formats and uncompressed audio, the data in
// [start_offset, start_offset + valid_length_bytes) is the contiguously valid
- // data refered to by this packet.
+ // data referred to by this packet.
//
// For uncompressed video frames, CodecFormatDetails is the primary means of
// determining which bytes are relevant. The offsets in CodecFormatDetails
@@ -761,7 +761,7 @@
// any output packet - depending on the characteristics of the input and
// output formats, and whether a decoder is willing to join mid-stream, etc
// this can be more or less likely to occur, but clients should be written
- // to accomodate timestamp_ish values that are fed on input but never show
+ // to accommodate timestamp_ish values that are fed on input but never show
// up on output, at least to a reasonable degree (not crashing, not
// treating as an error).
//
@@ -802,7 +802,7 @@
// Codec
//
// The Codec interface exists to anchor the configuration of input and output
-// buffers, and depending on Codec server hosting strategy, the Codec inteface
+// buffers, and depending on Codec server hosting strategy, the Codec interface
// can, in some configurations, be 1:1 with a codec isolate (process),
// especially when using SW codecs. The Codec can be used to process up to one
// stream at a time.
@@ -906,7 +906,7 @@
// during or shortly after Codec creation. Clients should not depend on this
// being the very first message to arrive at the client. OnOutputConfig()
// may be sent first by some codecs that already know their initial output
- // config without any input data, to encourage (but not stictly require) the
+ // config without any input data, to encourage (but not strictly require) the
// client to configure output buffers before feeding the first input, to
// avoid a wasteful OnOutputConfig() being generated for that first stream if
// the client has started configuring output but isn't done configuring
@@ -1091,7 +1091,7 @@
// allocates new buffers and re-sets-up input and/or output buffers. This
// de-overlapping of resource usage can be worthwhile for media buffers which
// can consume resource types whose overall pools aren't necessarily vast in
- // comparsion to resources consumed. Especially if a client is reconfiguring
+ // comparison to resources consumed. Especially if a client is reconfiguring
// buffers multiple times.
//
// Note that Sync() prior to allocating new media buffers is not alone
diff --git a/public/fidl/fuchsia.mediacodec/codec_common.fidl b/public/fidl/fuchsia.mediacodec/codec_common.fidl
index 8ff3d5d..492e660 100644
--- a/public/fidl/fuchsia.mediacodec/codec_common.fidl
+++ b/public/fidl/fuchsia.mediacodec/codec_common.fidl
@@ -324,7 +324,7 @@
uint32 primary_width_pixels;
uint32 primary_height_pixels;
- // For formats where the seconary planes are the same resolution, these fields
+ // For formats where the secondary planes are the same resolution, these fields
// will be the same as primary_width_pixels and primary_height_pixels. For
// formats with smaller secondary resolutions, these indicate that resolution.
uint32 secondary_width_pixels;
diff --git a/public/fidl/fuchsia.mediacodec/codec_factory.fidl b/public/fidl/fuchsia.mediacodec/codec_factory.fidl
index 59c1242..b319396 100644
--- a/public/fidl/fuchsia.mediacodec/codec_factory.fidl
+++ b/public/fidl/fuchsia.mediacodec/codec_factory.fidl
@@ -120,8 +120,8 @@
// discard damaged data vs. producing corresponding damaged output. Only that
// the codec will set error_detected_* bools to true when appropriate.
//
- // Regardless of this setting, not all timstamp_ish values provided on input
- // are guaranteed to show up on ouput.
+ // Regardless of this setting, not all timestamp_ish values provided on input
+ // are guaranteed to show up on output.
bool require_report_all_detected_errors = false;
// If true, require that the returned codec is HW-accelerated.