commit d0fd0ce767d799d6995a6edc58d2dae412017845
author Zach Bush <zmbush@google.com> Tue Jan 21 16:12:05 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jan 21 16:12:05 2020 +0000
tree 59da2d072accbfed97424813ed2f6ccb4d6c588d
parent f993a3a28cc31db8d077fc099c0dc49c18e8128e

[cobalt] Never return '' from ReadBuildInfo

Return more details if the file can't be read, or if the file is empty.

Bug: 35182
Change-Id: I9ef968839162b4f90e6cb4100528a888976d01ab

src/cobalt/bin/app/cobalt_main.cc

diff --git a/src/cobalt/bin/app/cobalt_main.cc b/src/cobalt/bin/app/cobalt_main.cc
index 4e6a40a..2309d13 100644
--- a/src/cobalt/bin/app/cobalt_main.cc
+++ b/src/cobalt/bin/app/cobalt_main.cc
@@ -107,9 +107,13 @@
   if (file.is_open()) {
     std::stringstream buffer;
     buffer << file.rdbuf();
-    return buffer.str();
+    auto val = buffer.str();
+    if (val == "") {
+      return "<" + value + " not specified>";
+    }
+    return val;
   } else {
-    return "";
+    return "<" + value + " read failed>";
   }
 }