commit ca4ed54243785bea38841ccaf5f590eab767c935
author Braden Kell <bradenkell@google.com> Mon Jul 26 21:53:27 2021 +0000
committer CQ Bot <commit-bot@chromium.org> Mon Jul 26 21:53:27 2021 +0000
tree c06f500cfb6042cee469eed08c4f7d0ff8dca1c9
parent bdb94ad86e0a26fc10b7a246f30b89cfc3e4fdee

[i2c][amlogic] Don't log errors for NACKs

According to the I2C spec there are valid reasons for devices to NACK
bytes from the host. For example, the SHTV3 sensor on Nelson NACKs
requests to read temperature data when a measurement is in progress.
Remove the error message in the Amlogic I2C driver to eliminate log spam
in these cases, and instead rely on client drivers to log when
unexpected errors occur.

Fixed: 81383
Test: No more I2C error messages on Nelson
Change-Id: Ia670918f0b5f25af549d194123533ae9c1716d99
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/560367
Reviewed-by: Eric Holland <hollande@google.com>
Reviewed-by: Andres Oportus <andresoportus@google.com>
Commit-Queue: Braden Kell <bradenkell@google.com>

src/devices/i2c/drivers/aml-i2c/aml-i2c.c

diff --git a/src/devices/i2c/drivers/aml-i2c/aml-i2c.c b/src/devices/i2c/drivers/aml-i2c/aml-i2c.c
index c9e5de8..854a469 100644
--- a/src/devices/i2c/drivers/aml-i2c/aml-i2c.c
+++ b/src/devices/i2c/drivers/aml-i2c/aml-i2c.c
@@ -101,7 +101,6 @@
     uint32_t reg = MmioRead32(&dev->virt_regs->control);
     if (reg & AML_I2C_CONTROL_REG_ERR) {
       zx_object_signal(dev->event, 0, I2C_ERROR_SIGNAL);
-      zxlogf(ERROR, "i2c: error on bus");
     } else {
       zx_object_signal(dev->event, 0, I2C_TXN_COMPLETE_SIGNAL);
     }