| commit | bf0148a6246b2797d24389c17022ccc2433d972b | [log] [tgz] |
|---|---|---|
| author | Dan Johnson <computerdruid@google.com> | Thu Jun 23 23:40:57 2022 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 23 23:40:57 2022 +0000 |
| tree | 6d7a761e67a0502325369e20ee4dbf1a2167d0b8 | |
| parent | 0be02c3a52037018ca03c5a1fbaecb89f0ee8ccd [diff] |
[overnet] re-enable clippy Switching from `.find(..).is_some()` to `.any(..)` works around the bug in the clippy diagnostic. (Which I believe is trying to suggest doing just that) Also fixed a `.write()` -> `.write_all()` bug which clippy pointed out. Fixed: 91347 Change-Id: I31adda0479f5891ef396f218bb32bf9c02a2aaae Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/693607 Fuchsia-Auto-Submit: Dan Johnson <computerdruid@google.com> Reviewed-by: Casey Dahlin <sadmac@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
diff --git a/src/connectivity/overnet/tests/integration/BUILD.gn b/src/connectivity/overnet/tests/integration/BUILD.gn index d2f06ae0..466661e 100644 --- a/src/connectivity/overnet/tests/integration/BUILD.gn +++ b/src/connectivity/overnet/tests/integration/BUILD.gn
@@ -9,7 +9,6 @@ rustc_test("integration") { edition = "2018" output_name = "overnet_integration_tests" - disable_clippy = true # TODO: debug ICE (fxbug.dev/91347) deps = [ ":triangle-rustc", "//sdk/fidl/fuchsia.overnet:fuchsia.overnet-rustc",
diff --git a/src/connectivity/overnet/tests/integration/src/lib.rs b/src/connectivity/overnet/tests/integration/src/lib.rs index 34a2d74..35b50c7 100644 --- a/src/connectivity/overnet/tests/integration/src/lib.rs +++ b/src/connectivity/overnet/tests/integration/src/lib.rs
@@ -261,7 +261,7 @@ return Ok(()); } let write = mutator(Vec::from(&buf[0..n])); - tx.write(&write).await?; + tx.write_all(&write).await?; } }
diff --git a/src/connectivity/overnet/tests/integration/src/triangle.rs b/src/connectivity/overnet/tests/integration/src/triangle.rs index 7a64872..ed46fe5 100644 --- a/src/connectivity/overnet/tests/integration/src/triangle.rs +++ b/src/connectivity/overnet/tests/integration/src/triangle.rs
@@ -160,10 +160,9 @@ .as_ref() .unwrap() .iter() - .find(|name| *name == triangle::ConscriptMarker::PROTOCOL_NAME) - .is_some() + .any(|name| *name == triangle::ConscriptMarker::PROTOCOL_NAME) }; - peers.iter().find(|p| is_peer_ready(p)).is_some() + peers.iter().any(|p| is_peer_ready(p)) } fn connect_peer(