tools/sdk-tools/sdkcommon/sdkcommon_test.go

// Copyright 2020 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package sdkcommon

import (
	"context"
	"encoding/json"
	"fmt"
	"io"
	"os"
	"os/exec"
	"path/filepath"
	"regexp"
	"strings"
	"testing"

	"github.com/google/go-cmp/cmp"
	"github.com/google/go-cmp/cmp/cmpopts"
)

const (
	resolvedAddr        = "fe80::c0ff:eee:fe00:4444%en0"
	getSSHAddressOutput = "[fe80::9ded:df4f:5ee8:605f]:8022"
)

var (
	defaultTargetJSONOutput = fmt.Sprintf(`[{
	"nodename":"test-device",
	"rcs_state":"Y",
	"serial":"<unknown>",
	"target_type":"Unknown",
	"target_state":"Product",
	"addresses":["%v"]
},{
	"nodename":"another-test-device",
	"rcs_state":"N",
	"serial":"<unknown>",
	"target_type":"Unknown",
	"target_state":"Product",
	"addresses":["fe80::9ded:df4f:5ee8:605f", "123-123-123"]
}]`, resolvedAddr)
	sshAddresses = map[string]string{
		"test-device":                "127.0.0.1:22",
		"another-test-device":        "[fe80::9ded:df4f:5ee8:605f]:8022",
		"test-device-ipv4":           "127.0.0.1:2022",
		"another-target-device-name": fmt.Sprintf("[%s]:22", resolvedAddr),
		"remote-target-name":         "[::1]:22",
	}

	allSSHOptions = []string{
		"FSERVE_TEST_USE_CUSTOM_SSH_CONFIG",
		"FSERVE_TEST_USE_PRIVATE_KEY",
		"FSERVE_TEST_USE_CUSTOM_SSH_PORT",
		"SFTP_TO_TARGET",
	}
)

// See exec_test.go for details, but effectively this runs the function called TestHelperProcess passing
// the args.
func helperCommandForSDKCommon(command string, s ...string) (cmd *exec.Cmd) {
	//testenv.MustHaveExec(t)

	cs := []string{"-test.run=TestFakeSDKCommon", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the enviroment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	return cmd
}

// See exec_test.go for details, but effectively this runs the function called TestHelperProcess passing
// the args.
func helperCommandContextForSDKCommon(_ context.Context, command string, s ...string) (cmd *exec.Cmd) {
	return helperCommandForSDKCommon(command, s...)
}

func TestNewSDK(t *testing.T) {
	tempDir := t.TempDir()
	homeDir := filepath.Join(tempDir, "_TEMP_HOME")
	if err := os.MkdirAll(homeDir, 0o700); err != nil {
		t.Fatal(err)
	}
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	GetUserHomeDir = mockedUserProperty(homeDir)
	GetUsername = mockedUserProperty("testuser")
	GetHostname = mockedUserProperty("test-host")
	defer clearTestEnv()
	testSDK, err := NewWithDataPath(tempDir)
	if err != nil {
		t.Fatal(err)
	}
	expectedPath := tempDir
	if testSDK.GetSDKDataPath() != expectedPath {
		t.Fatalf("NewWithDataPath datapath mismatch: expected: %v actual: %v",
			expectedPath, testSDK.GetSDKDataPath())
	}

	testSDK, err = New()
	if err != nil {
		t.Fatal(err)
	}
	expectedPath = tempDir + "/_TEMP_HOME/.fuchsia"
	if testSDK.GetSDKDataPath() != expectedPath {
		t.Fatalf("New datapath mismatch: expected: %v actual: %v",
			expectedPath, testSDK.GetSDKDataPath())
	}
}

func TestGetAvailableImages(t *testing.T) {
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	ExecLookPath = func(cmd string) (string, error) { return filepath.Join("mocked", cmd), nil }
	defer clearTestEnv()
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}
	version := "test-version"
	bucket := ""

	images, err := testSDK.GetAvailableImages(version, bucket)
	if err != nil {
		t.Fatal(err)
	}
	if len(images) != 2 {
		t.Fatalf("Expected 2 images, got %v: %v", len(images), images)
	}

	bucket = "private-bucket"
	images, err = testSDK.GetAvailableImages(version, bucket)
	if err != nil {
		t.Fatal(err)
	}
	if len(images) != 4 {
		t.Fatalf("Expected 4 images, got %v: %v", len(images), images)
	}

	bucket = "new"
	version = "non_default**"
	images, err = testSDK.GetAvailableImages(version, bucket)
	if err != nil {
		t.Fatal(err)
	}
	if len(images) != 2 {
		t.Fatalf("Expected 2 images, got %v: %v", len(images), images)
	}
	expectedImages := []GCSImage{
		{
			Bucket:  "new",
			Version: "non_default1",
			Name:    "priv-image1",
		}, {
			Bucket:  "new",
			Version: "non_default2",
			Name:    "priv-image1",
		},
	}
	if diff := cmp.Diff(expectedImages, images, cmpopts.SortSlices(func(a, b GCSImage) bool {
		return a.Bucket == b.Bucket && a.Version == b.Version && a.Name == b.Name
	})); diff != "" {
		t.Errorf("GetAvailableImages() mismatch (-want +got):\n%s", diff)
	}

	bucket = "new"
	version = "multi-version**"
	images, err = testSDK.GetAvailableImages(version, bucket)
	if err != nil {
		t.Fatal(err)
	}
	if len(images) != 4 {
		t.Fatalf("Expected 4 images, got %v: %v", len(images), images)
	}
	expectedImages = []GCSImage{
		{
			Bucket:  "new",
			Version: "multi-version1",
			Name:    "priv-image1",
		}, {
			Bucket:  "new",
			Version: "multi-version2",
			Name:    "priv-image1",
		},
		{
			Bucket:  "fuchsia",
			Version: "multi-version1",
			Name:    "image1",
		}, {
			Bucket:  "fuchsia",
			Version: "multi-version2",
			Name:    "image1",
		},
	}
	if diff := cmp.Diff(expectedImages, images, cmpopts.SortSlices(func(a, b GCSImage) bool {
		return a.Bucket == b.Bucket && a.Version == b.Version && a.Name == b.Name
	})); diff != "" {
		t.Errorf("GetAvailableImages() mismatch (-want +got):\n%s", diff)
	}

	bucket = ""
	version = "unknown"
	images, err = testSDK.GetAvailableImages(version, bucket)
	if err != nil {
		expected := "CommandException: One or more URLs matched no objects.: exit status 2"
		actual := fmt.Sprintf("%v", err)
		if actual != expected {
			t.Fatalf("Expected exception [%v] got [%v]", expected, actual)
		}
	} else {
		t.Fatal("Expected exception, but did not get one")
	}
}

func compareFuchsiaDevices(f1, f2 *FuchsiaDevice) bool {
	return cmp.Equal(f1.SSHAddr, f2.SSHAddr) && cmp.Equal(f1.Name, f2.Name)
}

func TestDeviceString(t *testing.T) {
	device := &FuchsiaDevice{
		SSHAddr: "123-123-123-123",
		Name:    "test-device",
	}
	expectedOutput := "123-123-123-123 test-device"
	actual := device.String()
	if actual != expectedOutput {
		t.Errorf("Expected String [%v] got [%v]", expectedOutput, actual)
	}
}

func TestListDevicesFfx(t *testing.T) {
	defer clearTestEnv()

	tests := []struct {
		ffxTargetListOutput   string
		expectedFuchsiaDevice []*FuchsiaDevice
	}{
		{
			ffxTargetListOutput: `[{"nodename":"another-test-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["ac80::9ded:df4f:5ee8:605f", "fe80::9ded:df4f:5ee8:605f"]}]`,
			expectedFuchsiaDevice: []*FuchsiaDevice{
				{
					SSHAddr: "[fe80::9ded:df4f:5ee8:605f]:8022",
					Name:    "another-test-device",
				},
			},
		},
		{
			ffxTargetListOutput: `[{"nodename":"test-device-ipv4",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown","target_state":"Product",
			"addresses":["127.0.0.1"]}]`,
			expectedFuchsiaDevice: []*FuchsiaDevice{
				{
					SSHAddr: "127.0.0.1:2022",
					Name:    "test-device-ipv4",
				},
			},
		},
		{
			ffxTargetListOutput: `[{"nodename":"another-test-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["ac80::9ded:df4f:5ee8:605f"]},
			{"nodename":"test-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["ac80::9ded:df4f:5ee8:605f", "127.0.0.1"]}]`,
			expectedFuchsiaDevice: []*FuchsiaDevice{
				{
					SSHAddr: "[fe80::9ded:df4f:5ee8:605f]:8022",
					Name:    "another-test-device",
				},
				{
					SSHAddr: "127.0.0.1:22",
					Name:    "test-device",
				},
			},
		},
	}
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}
	for _, test := range tests {
		clearTestEnv()
		ExecCommand = helperCommandForSDKCommon
		ExecCommandContext = helperCommandContextForSDKCommon
		os.Setenv("TEST_FFX_TARGET_LIST_OUTPUT", test.ffxTargetListOutput)
		os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
		output, err := testSDK.listDevices()
		if err != nil {
			t.Fatalf("Unexpected error: %v", err)
		}
		if d := cmp.Diff(test.expectedFuchsiaDevice, output, cmp.Comparer(compareFuchsiaDevices)); d != "" {
			t.Fatalf("listDevices mismatch: (-want +got):\n%s", d)
		}
	}
}

func TestRunSSHCommand(t *testing.T) {
	tempDir := t.TempDir()
	homeDir := filepath.Join(tempDir, "_TEMP_HOME")
	if err := os.MkdirAll(homeDir, 0o700); err != nil {
		t.Fatal(err)
	}
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	GetUserHomeDir = mockedUserProperty(homeDir)
	GetUsername = mockedUserProperty("testuser")
	GetHostname = mockedUserProperty("test-host")
	defer func() {
		for _, option := range allSSHOptions {
			os.Setenv(option, "")
		}
	}()
	defer clearTestEnv()
	testSDK, err := NewWithDataPath(t.TempDir())
	if err != nil {
		t.Fatal(err)
	}

	tests := []struct {
		customSSHConfig string
		privateKey      string
		sshPort         string
		verbose         bool
		args            []string
		options         map[string]string
	}{
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "",
			verbose:         false,
			args:            []string{"echo", "$SSH_CONNECTION"},
		},
		{
			customSSHConfig: "custom-sshconfig",
			privateKey:      "",
			sshPort:         "",
			verbose:         false,
			args:            []string{"echo", "$SSH_CONNECTION"},
			options:         map[string]string{"FSERVE_TEST_USE_CUSTOM_SSH_CONFIG": "1"},
		},
		{
			customSSHConfig: "",
			privateKey:      "private-key",
			sshPort:         "",
			verbose:         false,
			args:            []string{"echo", "$SSH_CONNECTION"},
			options:         map[string]string{"FSERVE_TEST_USE_PRIVATE_KEY": "1"},
		},
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "",
			verbose:         false,
			args:            []string{"echo", "$SSH_CONNECTION"},
		},
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "1022",
			verbose:         false,
			args:            []string{"echo", "$SSH_CONNECTION"},
			options:         map[string]string{"FSERVE_TEST_USE_CUSTOM_SSH_PORT": "1"},
		},
	}

	targetAddress := resolvedAddr
	for i, test := range tests {
		for _, option := range allSSHOptions {
			os.Setenv(option, "")
		}
		for option, value := range test.options {
			os.Setenv(option, value)
		}
		if err := testSDK.RunSSHShell(targetAddress, test.customSSHConfig, test.privateKey, test.sshPort, test.verbose, test.args); err != nil {
			t.Errorf("TestRunSSHShell (using port) %d error: %v", i, err)
		}
		if _, err := testSDK.RunSSHCommand(targetAddress, test.customSSHConfig, test.privateKey, test.sshPort, test.verbose, test.args); err != nil {
			t.Errorf("TestRunSSHCommand %d error: %v", i, err)
		}
	}
}

func TestRunRunSFTPCommand(t *testing.T) {
	tempDir := t.TempDir()
	homeDir := filepath.Join(tempDir, "_TEMP_HOME")
	if err := os.MkdirAll(homeDir, 0o700); err != nil {
		t.Fatal(err)
	}
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	GetUserHomeDir = mockedUserProperty(homeDir)
	GetUsername = mockedUserProperty("testuser")
	GetHostname = mockedUserProperty("test-host")
	defer func() {
		for _, option := range allSSHOptions {
			os.Setenv(option, "")
		}
	}()
	defer clearTestEnv()
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}

	tests := []struct {
		customSSHConfig string
		privateKey      string
		sshPort         string
		to_target       bool
		options         map[string]string
	}{
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "",
			to_target:       false,
		},
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "",
			to_target:       true,
			options:         map[string]string{"SFTP_TO_TARGET": "1"},
		},
		{
			customSSHConfig: "custom-sshconfig",
			privateKey:      "",
			sshPort:         "",
			to_target:       false,
			options:         map[string]string{"FSERVE_TEST_USE_CUSTOM_SSH_CONFIG": "1"},
		},
		{
			customSSHConfig: "",
			privateKey:      "private-key",
			sshPort:         "",
			to_target:       true,
			options: map[string]string{
				"SFTP_TO_TARGET":              "1",
				"FSERVE_TEST_USE_PRIVATE_KEY": "1",
			},
		},
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "",
			to_target:       false,
		},
		{
			customSSHConfig: "",
			privateKey:      "",
			sshPort:         "1022",
			to_target:       false,
			options:         map[string]string{"FSERVE_TEST_USE_CUSTOM_SSH_PORT": "1"},
		},
	}
	targetAddress := resolvedAddr
	src := "/some/src/file"
	dst := "/dst/file"

	for i, test := range tests {
		for _, option := range allSSHOptions {
			os.Setenv(option, "")
		}
		for option, value := range test.options {
			os.Setenv(option, value)
		}
		if err := testSDK.RunSFTPCommand(targetAddress, test.customSSHConfig, test.privateKey, test.sshPort, test.to_target, src, dst); err != nil {
			t.Errorf("TestRunSSHShell (using port) %d error: %v", i, err)
		}
	}
}

func TestCheckSSHConfig(t *testing.T) {
	tempDir := t.TempDir()
	homeDir := filepath.Join(tempDir, "_TEMP_HOME")
	if err := os.MkdirAll(homeDir, 0o700); err != nil {
		t.Fatal(err)
	}
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	GetUserHomeDir = mockedUserProperty(homeDir)
	GetUsername = mockedUserProperty("testuser")
	GetHostname = mockedUserProperty("test-host")
	defer clearTestEnv()
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}
	if err := checkSSHConfig(testSDK); err != nil {
		t.Fatal(err)
	}
}

func TestCheckSSHConfigExistingFiles(t *testing.T) {
	tempDir := t.TempDir()
	homeDir := filepath.Join(tempDir, "_TEMP_HOME")
	if err := os.MkdirAll(homeDir, 0o700); err != nil {
		t.Fatal(err)
	}
	ExecCommand = helperCommandForSDKCommon
	ExecCommandContext = helperCommandContextForSDKCommon
	GetUserHomeDir = mockedUserProperty(homeDir)
	GetUsername = mockedUserProperty("testuser")
	GetHostname = mockedUserProperty("test-host")
	defer clearTestEnv()
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}

	// Write out SSH keys and config
	data := []byte("Test SSH Key\n")
	sshDir := filepath.Join(homeDir, ".ssh")
	authFile := filepath.Join(sshDir, "fuchsia_authorized_keys")
	keyFile := filepath.Join(sshDir, "fuchsia_ed25519")
	sshConfigFile := getFuchsiaSSHConfigFile(testSDK)
	if err := os.MkdirAll(sshDir, 0o700); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(authFile, data, 0o600); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(keyFile, data, 0o600); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(sshConfigFile, []byte(sshConfigTag), 0o600); err != nil {
		t.Fatal(err)
	}

	if err := checkSSHConfig(testSDK); err != nil {
		t.Fatal(err)
	}

	// Make sure they have not changed
	content, err := os.ReadFile(authFile)
	if err != nil {
		t.Fatal(err)
	}
	if string(content) != string(data) {
		t.Fatalf("Expected test auth file to contain [%v], but contains [%v]", string(data), string(content))
	}
	content, err = os.ReadFile(keyFile)
	if err != nil {
		t.Fatal(err)
	}
	if string(content) != string(data) {
		t.Fatalf("Expected test key file to contain [%v], but contains [%v]", string(data), string(content))
	}
	content, err = os.ReadFile(sshConfigFile)
	if err != nil {
		t.Fatal(err)
	}
	if string(content) != sshConfigTag {
		t.Fatalf("Expected sshConfig file to contain [%v], but contains [%v]", string(data), string(content))
	}
}

func mockedUserProperty(value string) func() (string, error) {
	return func() (string, error) {
		return value, nil
	}
}

func TestGetFuchsiaProperty(t *testing.T) {
	sdk := SDKProperties{}

	ExecCommand = helperCommandForGetFuchsiaProperty
	ExecCommandContext = helperCommandContextForGetFuchsiaProperty
	defer clearTestEnv()

	testData := []struct {
		device, property, expected, errString string
	}{
		{"", "device-name", "fake-target-device-name", ""},
		{"some-other-device", "device-name", "some-other-device", ""},
		{"some-other-device", "random-property", "", "Could not find property some-other-device.random-property"},
		{"", "random-property", "", "Could not find property fake-target-device-name.random-property"},
		{"", PackageRepoKey, "fake-target-device-name/packages/amber-files", ""},
		{"another-target-device-name", PackageRepoKey, "another-target-device-name/packages/amber-files", ""},
		{"unknown-device-name", PackageRepoKey, "unknown-device-name/packages/amber-files", ""},
	}

	for i, data := range testData {
		t.Run(fmt.Sprintf("TestGetFuchsiaProperty.%d", i), func(t *testing.T) {
			os.Setenv("TEST_FFX_TARGET_DEFAULT_GET", "fake-target-device-name")
			os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
			val, err := sdk.GetFuchsiaProperty(data.device, data.property)
			if err != nil {
				if data.errString == "" {
					t.Fatalf("Unexpected error getting property %s.%s: %v", data.device, data.property, err)
				} else if !strings.Contains(fmt.Sprintf("%v", err), data.errString) {
					t.Errorf("Expected error message %v not found in error %v", data.errString, err)
				}
			} else {
				if val != data.expected {
					t.Errorf("GetFuchsiaProperyFailed %s.%s = %s, expected %s", data.device, data.property, val, data.expected)
				}
				if data.errString != "" {
					t.Errorf("Expected error %v, but got no error", data.errString)
				}
			}
		})
	}
}

func TestGetDeviceConfigurations(t *testing.T) {
	sdk := SDKProperties{}

	ExecCommand = helperCommandForGetFuchsiaProperty
	ExecCommandContext = helperCommandContextForGetFuchsiaProperty
	defer clearTestEnv()

	tests := []struct {
		ffxTargetListOutput string
		expectedLen         int
	}{
		{
			expectedLen: 4,
		},
		{
			ffxTargetListOutput: "[]",
			expectedLen:         3,
		},
	}

	for _, test := range tests {
		os.Setenv("TEST_FFX_TARGET_LIST_OUTPUT", test.ffxTargetListOutput)
		os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
		val, err := sdk.GetDeviceConfigurations()
		if err != nil {
			t.Errorf("unexpected err %v", err)
		}
		if len(val) != test.expectedLen {
			t.Errorf("TestGetDeviceConfigurations got length: %v, expected %v", len(val), test.expectedLen)
		}
	}
}

func TestMigrateGlobalData(t *testing.T) {
	sdk := SDKProperties{}
	defer clearTestEnv()

	tests := []struct {
		name                   string
		expectedValues         map[string]string
		newDeviceAlreadyExists string
	}{
		{
			name: "Migrating a device from global to user",
			expectedValues: map[string]string{
				"device_config.new-device-name.image":        "release",
				"device_config.new-device-name.bucket":       "fuchsia-bucket",
				"device_config.new-device-name.package-port": "7033",
			},
		},
		{
			name:                   "Device isn't migrated if it already exists in user config",
			newDeviceAlreadyExists: "1",
		},
	}
	for _, test := range tests {
		clearTestEnv()
		ExecCommand = helperCommandForSetTesting
		ExecCommandContext = helperCommandContextForSDKCommon
		t.Run(test.name, func(t *testing.T) {
			expectedData, err := json.Marshal(test.expectedValues)
			if err != nil {
				t.Fatalf("json.Marshal(): unexpected err %v", err)
			}
			os.Setenv("TEST_EXPECTED_SET_DATA", string(expectedData))
			os.Setenv("FFX_HAS_NEW_DEVICE", test.newDeviceAlreadyExists)
			os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
			if err = sdk.MigrateGlobalData(); err != nil {
				t.Errorf("MigrateGlobalData(): unexpected err %s", err)
			}
		})
	}
}

func TestGetDeviceConfiguration(t *testing.T) {
	sdk := SDKProperties{}
	ExecCommand = helperCommandForGetFuchsiaProperty
	ExecCommandContext = helperCommandContextForGetFuchsiaProperty
	defer clearTestEnv()

	tests := []struct {
		deviceName           string
		expectedDeviceConfig DeviceConfig
	}{
		{
			deviceName: "another-target-device-name",
			expectedDeviceConfig: DeviceConfig{
				DeviceName:  "another-target-device-name",
				Bucket:      "fuchsia-bucket",
				Image:       "release",
				SSHPort:     "22",
				PackageRepo: "another-target-device-name/packages/amber-files",
				PackagePort: "8083",
			},
		},
		{
			deviceName: "unknown-device",
			expectedDeviceConfig: DeviceConfig{
				DeviceName:  "unknown-device",
				Bucket:      "fuchsia",
				Image:       "",
				SSHPort:     "22",
				PackageRepo: "unknown-device/packages/amber-files",
				PackagePort: "8083",
			},
		},
	}
	for _, test := range tests {
		os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
		deviceConfig, err := sdk.GetDeviceConfiguration(test.deviceName)
		if err != nil {
			t.Fatalf("unexpected err %v", err)
		}
		if deviceConfig != test.expectedDeviceConfig {
			t.Fatalf("TestGetDeviceConfiguration failed. Wanted configuration %v: got %v", test.expectedDeviceConfig, deviceConfig)
		}
	}
}

func TestSaveDeviceConfiguration(t *testing.T) {
	sdk := SDKProperties{}
	defer clearTestEnv()

	tests := []struct {
		name           string
		currentDevice  DeviceConfig
		newDevice      DeviceConfig
		expectedValues map[string]string
	}{
		{
			name: "Saving a new device with non-default values",
			newDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "image-name",
				Bucket:      "buck-name",
				PackagePort: "8000",
				PackageRepo: "new/device/repo",
			},
			expectedValues: map[string]string{
				"device_config.new-device-name.image":        "image-name",
				"device_config.new-device-name.bucket":       "buck-name",
				"device_config.new-device-name.package-port": "8000",
				"device_config.new-device-name.package-repo": "new/device/repo",
			},
		},
		{
			name: "Saving an existing device with non-default values all being the same",
			currentDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "image-name",
				Bucket:      "buck-name",
				PackagePort: "8000",
				PackageRepo: "existing/repo",
			},
			newDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "image-name",
				Bucket:      "buck-name",
				PackagePort: "8000",
				PackageRepo: "existing/repo",
			},
		},
		{
			name: "Overriding an existing device that has default values with non-default values",
			currentDevice: DeviceConfig{
				DeviceName: "new-device-name",
			},
			newDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "custom-image",
				Bucket:      "buck",
				PackagePort: "8000",
				PackageRepo: "/some/new/device",
			},
			expectedValues: map[string]string{
				"device_config.new-device-name.bucket":       "buck",
				"device_config.new-device-name.image":        "custom-image",
				"device_config.new-device-name.package-port": "8000",
				"device_config.new-device-name.package-repo": "/some/new/device",
			},
		},
		{
			name: "Overriding an existing device with new configurations",
			currentDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "image-name",
				Bucket:      "buck-name",
				PackagePort: "8000",
				PackageRepo: "/usr/some/new/device",
			},
			newDevice: DeviceConfig{
				DeviceName:  "new-device-name",
				Image:       "custom-image",
				Bucket:      "",
				PackagePort: "8000",
				PackageRepo: "/usr/some/new/device",
			},
			expectedValues: map[string]string{
				"device_config.new-device-name.bucket":       "",
				"device_config.new-device-name.image":        "custom-image",
				"device_config.new-device-name.package-repo": "/usr/some/new/device",
			},
		},
	}
	for _, test := range tests {
		clearTestEnv()
		ExecCommand = helperCommandForSetTesting
		ExecCommandContext = helperCommandContextForSDKCommon
		t.Run(test.name, func(t *testing.T) {
			expectedData, err := json.Marshal(test.expectedValues)
			if err != nil {
				t.Fatalf("unexpected err %v", err)
			}
			currentData, err := json.Marshal(test.currentDevice)
			if err != nil {
				t.Fatalf("unexpected err %v", err)
			}
			os.Setenv("TEST_EXPECTED_SET_DATA", string(expectedData))
			os.Setenv("TEST_CURRENT_DEVICE_DATA", string(currentData))
			os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
			err = sdk.SaveDeviceConfiguration(test.newDevice)
			if err != nil {
				t.Fatalf("unexpected err %v", err)
			}
		})
	}
}

func TestResolveTargetAddress(t *testing.T) {
	sdk := SDKProperties{}

	ExecCommand = nil
	defer clearTestEnv()

	tests := []struct {
		name                         string
		deviceIP                     string
		deviceName                   string
		ffxTargetListOutput          string
		ffxTargetDefaultGetOutput    string
		ffxTargetGetSSHAddressOutput string
		expectedConfig               DeviceConfig
		expectedError                string
		execHelper                   func(command string, s ...string) (cmd *exec.Cmd)
		execContextHelper            func(ctx context.Context, command string, s ...string) (cmd *exec.Cmd)
	}{
		{
			name:     "IP address passed in",
			deviceIP: resolvedAddr,
			expectedConfig: DeviceConfig{
				Bucket:      "fuchsia",
				DeviceIP:    resolvedAddr,
				SSHPort:     "22",
				PackageRepo: "packages/amber-files",
				PackagePort: "8083",
			},
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name:       "Device name passed in",
			deviceName: "test-device",
			expectedConfig: DeviceConfig{
				DeviceName:   "test-device",
				Bucket:       "fuchsia",
				DeviceIP:     "127.0.0.1",
				SSHPort:      "22",
				PackageRepo:  "test-device/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    false,
				Discoverable: true,
			},
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name:       "Device name passed in but is not discoverable and is not set in ffx",
			deviceName: "some-unknown-device",
			expectedError: `Cannot get target address for some-unknown-device.
		Try running 'ffx target list'.`,
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name:                      "Gets the default device when there are multiple devices in ffx target list",
			ffxTargetDefaultGetOutput: "another-target-device-name",
			ffxTargetListOutput: fmt.Sprintf(`[{"nodename":"another-target-device-name",
			"rcs_state":"Y",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["%v"]
		},{
			"nodename":"another-test-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["fe80::9ded:df4f:5ee8:605f", "123-123-123"]}]`, resolvedAddr),
			expectedConfig: DeviceConfig{
				DeviceName:   "another-target-device-name",
				Bucket:       "fuchsia-bucket",
				Image:        "release",
				DeviceIP:     resolvedAddr,
				SSHPort:      "22",
				PackageRepo:  "another-target-device-name/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    true,
				Discoverable: true,
			},
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name: "Returns an error if the default device is set but undiscoverable and doesn't have an" +
				"IP in config, even if another device is discoverable",
			ffxTargetDefaultGetOutput: "fake-target-device-name",
			ffxTargetListOutput: `[{"nodename":"another-target-device-name",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["ac80::9ded:df4f:5ee8:605f"]}]`,
			expectedError: `Cannot get target address for fake-target-device-name.
		Try running 'ffx target list'.`,
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name: "Uses the correct device IP when device has multiple address in ffx target list",
			ffxTargetListOutput: `[{"nodename":"test-device-ipv4",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["ac80::9ded:df4f:5ee8:605f", "127.0.0.1"]}]`,
			expectedConfig: DeviceConfig{
				DeviceName:   "test-device-ipv4",
				Bucket:       "fuchsia",
				DeviceIP:     "127.0.0.1",
				SSHPort:      "2022",
				PackageRepo:  "test-device-ipv4/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    false,
				Discoverable: true,
			},
			execHelper:        helperCommandForNoDefaultDevice,
			execContextHelper: helperCommandContextForNoDefaultDevice,
		},
		{
			name: "Gets the discoverable device if there is only 1, even if ffx has multiple non-default devices",
			ffxTargetListOutput: `[{"nodename":"some-unknown-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["fe80::9ded:df4f:5ee8:605f"]}]`,
			expectedConfig: DeviceConfig{
				DeviceName:   "some-unknown-device",
				Bucket:       "fuchsia",
				DeviceIP:     "fe80::9ded:df4f:5ee8:605f",
				SSHPort:      "8022",
				PackageRepo:  "some-unknown-device/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    false,
				Discoverable: true,
			},
			execHelper:        helperCommandForNoDefaultDevice,
			execContextHelper: helperCommandContextForNoDefaultDevice,
		},
		{
			name:                "No discoverable device and no default device",
			ffxTargetListOutput: "[]",
			expectedError:       fmt.Sprintf("No devices found. %v", helpfulTipMsg),
			execHelper:          helperCommandForNoDefaultDevice,
			execContextHelper:   helperCommandContextForNoDefaultDevice,
		},
		{
			name:              "Multiple discoverable devices found",
			expectedError:     fmt.Sprintf("Multiple devices found. %v", helpfulTipMsg),
			execHelper:        helperCommandForNoDefaultDevice,
			execContextHelper: helperCommandContextForNoDefaultDevice,
		},
		{
			name:                      "No discoverable device but ffx has a default device that is undiscoverable",
			ffxTargetListOutput:       "[]",
			ffxTargetDefaultGetOutput: "fake-target-device-name",
			expectedError: `Cannot get target address for fake-target-device-name.
		Try running 'ffx target list'.`,
			execHelper:        helperCommandForGetFuchsiaProperty,
			execContextHelper: helperCommandContextForGetFuchsiaProperty,
		},
		{
			name:                      "Multiple discoverable devices found but ffx has a default device",
			ffxTargetDefaultGetOutput: "test-device",
			expectedConfig: DeviceConfig{
				DeviceName:   "test-device",
				Bucket:       "fuchsia",
				DeviceIP:     "127.0.0.1",
				SSHPort:      "22",
				PackageRepo:  "test-device/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    true,
				Discoverable: true,
			},
			execHelper:        helperCommandForNoDefaultDevice,
			execContextHelper: helperCommandContextForNoDefaultDevice,
		},
		{
			name:                      "Multiple discoverable devices found but ffx has a default device that isn't discoverable",
			ffxTargetDefaultGetOutput: "some-unknown-default-device",
			expectedError: `Cannot get target address for some-unknown-default-device.
		Try running 'ffx target list'.`,
			execHelper:        helperCommandForNoDefaultDevice,
			execContextHelper: helperCommandContextForNoDefaultDevice,
		},
		{
			name: "One discoverable device and no configured device",
			ffxTargetListOutput: `[{"nodename":"target-device",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["fe80::9ded:df4f:5ee8:605f"]}]`,
			expectedConfig: DeviceConfig{
				DeviceName:   "target-device",
				Bucket:       "fuchsia",
				DeviceIP:     "fe80::9ded:df4f:5ee8:605f",
				SSHPort:      "8022",
				PackageRepo:  "target-device/packages/amber-files",
				PackagePort:  "8083",
				IsDefault:    false,
				Discoverable: true,
			},
			execHelper:        helperCommandForNoConfiguredDevices,
			execContextHelper: helperCommandContextForNoConfiguredDevices,
		},
		{
			name: "Multiple discoverable devices and no configured device",
			ffxTargetListOutput: `[{"nodename":"another-target-device-name",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["123-123-123"]
		},{
			"nodename":"remote-target-name",
			"rcs_state":"N",
			"serial":"<unknown>",
			"target_type":"Unknown",
			"target_state":"Product",
			"addresses":["::1"]}]`,
			expectedError:     fmt.Sprintf("Multiple devices found. %v", helpfulTipMsg),
			execHelper:        helperCommandForNoConfiguredDevices,
			execContextHelper: helperCommandContextForNoConfiguredDevices,
		},
	}
	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			clearTestEnv()
			os.Setenv("TEST_FFX_TARGET_LIST_OUTPUT", test.ffxTargetListOutput)
			os.Setenv("TEST_FFX_TARGET_DEFAULT_GET", test.ffxTargetDefaultGetOutput)
			os.Setenv("TEST_GET_SSH_ADDRESS_OUTPUT", test.ffxTargetGetSSHAddressOutput)
			os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
			ExecCommand = test.execHelper
			ExecCommandContext = test.execContextHelper

			config, err := sdk.ResolveTargetAddress(test.deviceIP, test.deviceName)
			if err != nil {
				message := fmt.Sprintf("%v", err)
				if message != test.expectedError {
					t.Fatalf("Error '%v' did not match expected error '%v'", message, test.expectedError)
				}
			} else if test.expectedError != "" {
				t.Fatalf("Expected error '%v', but got no error", test.expectedError)
			}
			if config != test.expectedConfig {
				t.Fatalf("got config: '%v' did not match expected '%v'", config, test.expectedConfig)
			}
		})
	}
}

func TestRunFFX(t *testing.T) {
	defer clearTestEnv()

	oldTestOutDir := os.Getenv("FUCHSIA_TEST_OUTDIR")
	defer os.Setenv("FUCHSIA_TEST_OUTDIR", oldTestOutDir)

	tests := []struct {
		name                   string
		setTestOutDirEnvKey    bool
		setFFXIsolateDirEnvKey bool
		wantError              bool
	}{
		{
			name: "no environment variables set",
		},
		{
			name:                "only FUCHSIA_TEST_OUTDIR set",
			setTestOutDirEnvKey: true,
			wantError:           true,
		},
		{
			name:                   "only FFX_ISOLATE_DIR set",
			setFFXIsolateDirEnvKey: true,
		},
		{
			name:                   "both environment variables set",
			setTestOutDirEnvKey:    true,
			setFFXIsolateDirEnvKey: true,
		},
	}
	testSDK := SDKProperties{}
	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			clearTestEnv()
			if test.setTestOutDirEnvKey {
				os.Setenv("FUCHSIA_TEST_OUTDIR", t.TempDir())
			} else {
				os.Unsetenv("FUCHSIA_TEST_OUTDIR")
			}
			if test.setFFXIsolateDirEnvKey {
				os.Setenv("FFX_ISOLATE_DIR", t.TempDir())
			} else {
				os.Unsetenv("FFX_ISOLATE_DIR")
			}
			ExecCommand = helperCommandForSetTesting
			ExecCommandContext = helperCommandContextForSDKCommon
			_, err := testSDK.RunFFX([]string{}, false)
			if test.wantError && err == nil {
				t.Fatalf("expected error but got nil")
			} else if !test.wantError && err != nil {
				t.Fatalf("unexpected error: %s", err)
			}
		})
	}
}

func TestRunFFXDoctor(t *testing.T) {
	sdk := SDKProperties{}

	ExecCommand = helperCommandForSetTesting
	ExecCommandContext = helperCommandContextForSetTesting
	defer clearTestEnv()
	os.Setenv("FFX_ISOLATE_DIR", t.TempDir())

	output, err := sdk.RunFFXDoctor()
	if err != nil {
		t.Fatalf("unexpected err %v", err)
	}

	expectedOutput := "Welcome to ffx doctor."
	if output != expectedOutput {
		t.Fatalf("Expected %v, got %v", expectedOutput, output)
	}
}

func TestMapToDeviceConfig(t *testing.T) {
	testSDK := SDKProperties{
		dataPath: t.TempDir(),
	}
	tests := []struct {
		jsonString   string
		deviceConfig DeviceConfig
		deviceName   string
	}{
		{
			jsonString: `{
				  "test-device1": {
					"bucket": "",
					"device-ip": "",
					"device-name": "test-device1",
					"image": "",
					"package-port": "",
					"package-repo": "",
					"ssh-port": ""
				  }
				}
				`,
			deviceName: "test-device1",
			deviceConfig: DeviceConfig{
				DeviceName:  "test-device1",
				Bucket:      "fuchsia",
				PackageRepo: filepath.Join(testSDK.dataPath, "test-device1", "packages", "amber-files"),
				SSHPort:     "22",
				IsDefault:   false,
				PackagePort: "8083",
			},
		},
		{
			jsonString: `{
				  "test-device1": {
					"bucket": "",
					"device-name": "test-device1",
					"image": "some-fuchsia-image",
					"package-port": 8888,
					"package-repo": ""
				  }
				}
				`,
			deviceName: "test-device1",
			deviceConfig: DeviceConfig{
				DeviceName:  "test-device1",
				Image:       "some-fuchsia-image",
				Bucket:      "fuchsia",
				PackageRepo: filepath.Join(testSDK.dataPath, "test-device1", "packages", "amber-files"),
				SSHPort:     "22",
				PackagePort: "8888",
			},
		},
		// Test case for unmarshalling being changed to be string
		// values for numbers
		{
			jsonString: `{
				  "test-device1": {
					"bucket": "",
					"device-name": "test-device1",
					"image": "",
					"package-port": "8888",
					"package-repo": "",
					"ssh-port": "1022"
				  }
				}
				`,
			deviceName: "test-device1",
			deviceConfig: DeviceConfig{
				DeviceName:  "test-device1",
				Bucket:      "fuchsia",
				PackageRepo: filepath.Join(testSDK.dataPath, "test-device1", "packages", "amber-files"),
				SSHPort:     "22",
				PackagePort: "8888",
			},
		},
	}

	for i, test := range tests {
		var data map[string]interface{}
		err := json.Unmarshal([]byte(test.jsonString), &data)
		if err != nil {
			t.Errorf("Error parsing json for %v: %v", i, err)
		}

		actualDevice, ok := testSDK.mapToDeviceConfig(test.deviceName, data[test.deviceName])
		if !ok {
			t.Errorf("Error mapping to DeviceConfig %v: %v", i, data)
		}
		expected := test.deviceConfig
		if actualDevice != expected {
			t.Errorf("Test %v: unexpected deviceConfig: %v. Expected %v", i, actualDevice, expected)
		}
	}
}

func TestWriteTempFile(t *testing.T) {
	var tests = []struct {
		content []byte
	}{
		{
			content: []byte("hello, world."),
		},
	}
	for _, test := range tests {
		path, err := WriteTempFile(test.content)
		if err != nil {
			t.Errorf("WriteTempFile(%v): got unexpected error %s", test.content, err)
		}
		dat, err := os.ReadFile(path)
		if err != nil {
			t.Errorf("Error reading temp file: %s", err)
		}
		if string(dat) != string(test.content) {
			t.Errorf("File content diff got %s, want %s", string(dat), string(test.content))
		}
	}
}

func helperCommandContextForGetFuchsiaProperty(_ context.Context, command string, s ...string) (cmd *exec.Cmd) {
	return helperCommandForGetFuchsiaProperty(command, s...)
}

func helperCommandForGetFuchsiaProperty(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	return cmd
}

func helperCommandContextForNoDefaultDevice(_ context.Context, command string, s ...string) (cmd *exec.Cmd) {
	return helperCommandForNoDefaultDevice(command, s...)
}

func helperCommandForNoDefaultDevice(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	cmd.Env = append(cmd.Env, "NO_DEFAULT_DEVICE=1")

	return cmd
}

func helperCommandForRemoteTarget(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	cmd.Env = append(cmd.Env, "FFX_TEST_REMOTE_TARGET_CONFIG=1")
	return cmd
}

func helperCommandContextForNoConfiguredDevices(_ context.Context, command string, s ...string) (cmd *exec.Cmd) {
	return helperCommandForNoConfiguredDevices(command, s...)
}

func helperCommandForNoConfiguredDevices(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	cmd.Env = append(cmd.Env, "FFX_NO_CONFIGURED_DEVICES=1")
	cmd.Env = append(cmd.Env, "NO_DEFAULT_DEVICE=1")
	return cmd
}

func helperCommandContextForSetTesting(_ context.Context, command string, s ...string) (cmd *exec.Cmd) {
	return helperCommandForSetTesting(command, s...)
}

func helperCommandForSetTesting(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	cmd.Env = append(cmd.Env, "ALLOW_SET=1")
	return cmd
}
func helperCommandForRemoveTesting(command string, s ...string) (cmd *exec.Cmd) {
	cs := []string{"-test.run=TestFakeFfx", "--"}
	cs = append(cs, command)
	cs = append(cs, s...)

	cmd = exec.Command(os.Args[0], cs...)
	// Set this in the environment, so we can control the result.
	cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1")
	cmd.Env = append(cmd.Env, "ALLOW_SET=1")
	cmd.Env = append(cmd.Env, "ALLOW_REMOVE=1")
	return cmd
}

func TestFakeSDKCommon(t *testing.T) {
	t.Helper()
	if os.Getenv("GO_WANT_HELPER_PROCESS") != "1" {
		return
	}
	defer os.Exit(0)

	args := os.Args
	for len(args) > 0 {
		if args[0] == "--" {
			args = args[1:]
			break
		}
		args = args[1:]
	}
	if len(args) == 0 {
		fmt.Fprintf(os.Stderr, "No command\n")
		os.Exit(2)
	}
	// Check the command line
	cmd, args := args[0], args[1:]
	switch filepath.Base(cmd) {
	case "gsutil":
		fakeGSUtil(args)
	case "ffx":
		fakeFfxTarget(args)
	case "ssh":
		fakeSSH(args)
	case "sftp":
		fakeSFTP(args, os.Stdin)
	case "ssh-keygen":
		fakeSSHKeygen(args)
	default:
		fmt.Fprintf(os.Stderr, "Unexpected command %v", cmd)
		os.Exit(1)
	}
}

func fakeGSUtil(args []string) {
	expected := []string{}

	if len(args) == 0 {
		fmt.Fprintf(os.Stderr, "Expected arguments to gsutil\n")
		os.Exit(1)
	}
	switch args[0] {
	case "ls":
		switch args[1] {
		case "gs://fuchsia/development/test-version/images*":
			expected = []string{args[0], args[1]}
			fmt.Printf("%v/image1.tgz\n", args[1])
			fmt.Printf("%v/image2.tgz\n", args[1])
		case "gs://private-bucket/development/test-version/images*":
			expected = []string{args[0], args[1]}
			fmt.Printf("%v/priv-image3.tgz\n", args[1])
			fmt.Printf("%v/priv-image4.tgz\n", args[1])
		case "gs://fuchsia/development/multi-version**/images*":
			expected = []string{args[0], args[1]}
			fmt.Print("gs://fuchsia/development/multi-version1/images/image1.tgz\n")
			fmt.Print("gs://fuchsia/development/multi-version2/images/image1.tgz\n")
		case "gs://new/development/multi-version**/images*":
			expected = []string{args[0], args[1]}
			fmt.Print("gs://new/development/multi-version1/images/priv-image1.tgz\n")
			fmt.Print("gs://new/development/multi-version2/images/priv-image1.tgz\n")
		case "gs://new/development/non_default**/images*":
			expected = []string{args[0], args[1]}
			fmt.Print("gs://new/development/non_default1/images/priv-image1.tgz\n")
			fmt.Print("gs://new/development/non_default2/images/priv-image1.tgz\n")
		case "gs://fuchsia/development/unknown/images*":
			expected = []string{args[0], args[1]}
			fmt.Fprintf(os.Stderr, "CommandException: One or more URLs matched no objects.")
			os.Exit(2)
		default:
			expected = []string{"ls", "gs://fuchsia/development/test-version/images"}
		}
	}

	ok := len(args) == len(expected)
	if ok {
		for i := range args {
			if strings.Contains(expected[i], "*") {
				expectedPattern := regexp.MustCompile(expected[i])
				ok = ok && expectedPattern.MatchString(args[i])
			} else {
				ok = ok && args[i] == expected[i]
			}
		}
	}
	if !ok {
		fmt.Fprintf(os.Stderr, "unexpected gsutil args  %v. Expected %v", args, expected)
		os.Exit(1)
	}
}

func fakeFfxTarget(args []string) {
	expected := []string{}
	argsStr := strings.Join(args, " ")
	expectedListArgs := []string{"--machine", "json", "target", "list"}
	expectedGetSSHAddressArgs := []string{"--target", "*", "target", "get-ssh-address"}
	expectedGetDefaultTarget := []string{"target", "default", "get"}
	expectedSetDefaultTarget := []string{"target", "default", "set", "new-device-name"}
	expectedUnsetDefaultTarget := []string{"target", "default", "unset"}
	if strings.Contains(argsStr, "target list") {
		expected = expectedListArgs
		if os.Getenv("TEST_FFX_TARGET_LIST_OUTPUT") != "" {
			fmt.Println(os.Getenv("TEST_FFX_TARGET_LIST_OUTPUT"))
		} else {
			fmt.Println(defaultTargetJSONOutput)
		}
	} else if strings.Contains(argsStr, "target get-ssh-address") {
		expected = expectedGetSSHAddressArgs
		if val, ok := sshAddresses[args[1]]; ok {
			fmt.Println(val)
		} else {
			fmt.Println(getSSHAddressOutput)
		}
	} else if strings.Contains(argsStr, "target default") {
		if args[2] == "get" {
			expected = expectedGetDefaultTarget
			if os.Getenv("TEST_FFX_TARGET_DEFAULT_GET") != "" {
				fmt.Println(os.Getenv("TEST_FFX_TARGET_DEFAULT_GET"))
			} else {
				fmt.Println("")
			}
		} else if args[2] == "set" {
			expected = expectedSetDefaultTarget
		} else if args[2] == "unset" {
			expected = expectedUnsetDefaultTarget
		}
	}
	ok := len(expected) == len(args)
	for i := range args {
		if strings.Contains(expected[i], "*") {
			expectedPattern := regexp.MustCompile(expected[i])
			ok = ok && expectedPattern.MatchString(args[i])
		} else {
			ok = ok && args[i] == expected[i]
		}
	}
	if !ok {
		fmt.Fprintf(os.Stderr, "unexpected ssh args  %v exepected %v", args, expected)
		os.Exit(1)
	}
}

func TestFakeFfx(*testing.T) {
	if os.Getenv("GO_WANT_HELPER_PROCESS") != "1" {
		return
	}
	defer os.Exit(0)

	args := os.Args
	for len(args) > 0 {
		if args[0] == "--" {
			args = args[1:]
			break
		}
		args = args[1:]
	}

	if len(args) == 0 {
		fmt.Fprintf(os.Stderr, "No command\n")
		os.Exit(2)
	}
	if strings.HasSuffix(args[0], "ffx") && args[1] == "doctor" {
		fmt.Printf("Welcome to ffx doctor.")
		os.Exit(0)
	}
	if strings.HasSuffix(args[0], "ffx") && (args[1] == "target" || args[1] == "--target" || args[1] == "--machine") {
		fakeFfxTarget(args[1:])
		os.Exit(0)
	}
	if args[1] != "config" {
		fmt.Fprintf(os.Stderr, "Unexpected command %v, expected `config`", args[1])
		os.Exit(2)
	}
	switch args[2] {
	case "get":
		if !handleGetFake(args[3:]) {
			fmt.Fprintf(os.Stderr, "Whatever error message")
			os.Exit(2)
		}
	case "set":
		if os.Getenv("ALLOW_SET") != "1" {
			fmt.Fprintf(os.Stderr, "Verb `set` not allowed")
			os.Exit(2)
		}
		handleSetFake(args[3:])
	case "remove":
		handleRemoveFake(args[3:])
	default:
		fmt.Fprintf(os.Stderr, "Unexpected verb %v", args[2])
		os.Exit(2)
	}
}

func handleGetFake(args []string) bool {
	var (
		dataName   string
		deviceData map[string]interface{}
	)

	currentDeviceData := os.Getenv("TEST_CURRENT_DEVICE_DATA")
	if len(currentDeviceData) > 0 {
		err := json.Unmarshal([]byte(currentDeviceData), &deviceData)
		if err != nil {
			fmt.Fprintf(os.Stderr, "Error parsing current data %v: %s", err, currentDeviceData)
			os.Exit(1)
		}
	} else {
		deviceData = make(map[string]interface{})
	}
	if value, ok := deviceData["device-name"].(string); ok {
		dataName = value
	}

	switch args[0] {
	case "DeviceConfiguration":
		if os.Getenv("ALLOW_SET") == "1" {
			fmt.Println(`{
				"new-device-name":{
					"bucket":"fuchsia-bucket","device-ip":"::1","device-name":"new-device-name","image":"release","package-port":"7033","package-repo":"","ssh-port":"22"
				}
			}`)
		}
	case "device_config":
		if os.Getenv("FFX_TEST_REMOTE_TARGET_CONFIG") == "1" {
			fmt.Println(`{
				"remote-target-name":{
					"bucket":"fuchsia-bucket","device-ip":"::1","device-name":"remote-target-name","image":"release","package-port":"","package-repo":"","ssh-port":"22"
				},
				"another-target-device-name":{
					"bucket":"fuchsia-bucket","device-ip":"","device-name":"another-target-device-name","image":"release","package-port":"","package-repo":"","ssh-port":"22"
				}
				}`)
		} else if os.Getenv("FFX_NO_CONFIGURED_DEVICES") == "1" {
			fmt.Println("{}")
		} else if os.Getenv("FFX_HAS_NEW_DEVICE") == "1" {
			fmt.Println(`{
				"new-device-name":{
					"bucket":"fuchsia-bucket","device-ip":"::1","device-name":"new-device-name","image":"release","package-port":"7033","package-repo":"","ssh-port":"22"
				}
			}`)
		} else {
			fmt.Println(`{
				"fake-target-device-name":{
					"bucket":"fuchsia-bucket","device-ip":"","device-name":"fake-target-device-name","image":"release","package-port":"","package-repo":"","ssh-port":"22"
				},
				"another-target-device-name":{
					"bucket":"fuchsia-bucket","device-ip":"","device-name":"another-target-device-name","image":"release","package-port":"","package-repo":"","ssh-port":"22"
				},
				"another-test-device":{
					"bucket":"fuchsia-bucket","device-ip":"127.0.0.1","device-name":"another-test-device","image":"release","package-port":"","package-repo":"","ssh-port":"123456"
				}
				}`)
		}
	case "device_config.another-target-device-name":
		fmt.Println(`{
				"bucket":"fuchsia-bucket","device-ip":"","device-name":"another-target-device-name","image":"release","package-port":"","package-repo":"","ssh-port":"22"
			}`)
	case "device_config.fake-target-device-name":
		fmt.Println(`{
				"bucket":"","device-ip":"","device-name":"fake-target-device-name","image":"","package-port":"","package-repo":"","ssh-port":""
			}`)
	case "device_config.remote-target-name":
		fmt.Println(`{
					"bucket":"","device-ip":"::1","device-name":"remote-target-name","image":"","package-port":"","package-repo":"","ssh-port":""
				}`)
	default:
		if args[0] == fmt.Sprintf("device_config.%s", dataName) {
			fmt.Println(currentDeviceData)

		} else {
			return false
		}
	}
	return true
}

func handleSetFake(args []string) {
	sdk := SDKProperties{}
	expectedData := os.Getenv("TEST_EXPECTED_SET_DATA")
	var data map[string]interface{}
	if len(expectedData) > 0 {
		err := json.Unmarshal([]byte(expectedData), &data)
		if err != nil {
			fmt.Fprintf(os.Stderr, "Error parsing configuration data %s: %s", err, expectedData)
			os.Exit(1)
		}
	} else {
		data = make(map[string]interface{})
	}

	if len(args) > 2 {
		fmt.Fprintf(os.Stderr, "Invalid number of arguments got: %d, expected 2", len(args))
		os.Exit(1)
	}
	// Check the property name
	parts := strings.Split(args[0], ".")
	switch len(parts) {
	case 3:
		// This is a device setting
		if parts[0] != "device_config" || parts[1] != "new-device-name" {
			fmt.Fprintf(os.Stderr, "Expected device property name format. Got: %s", parts)
			os.Exit(1)
		}
		if !sdk.IsValidProperty(parts[2]) {
			fmt.Fprintf(os.Stderr, "Invalid property name for a device: %s", parts)
			os.Exit(1)
		}
	case 2:
		// Setting a reserved property
		if parts[0] != "device_config" || !isReservedProperty(parts[1]) {
			fmt.Fprintf(os.Stderr, "Unexpected property being set: %s", parts)
			os.Exit(1)
		}
	default:
		fmt.Fprintf(os.Stderr, "Unexpected property being set: %s", parts)
		os.Exit(1)
	}
	if expectedValue, ok := data[args[0]].(string); ok {
		if expectedValue != args[1] {
			fmt.Fprintf(os.Stderr, "Unexpected property %s value being set: %s, expected %s", args[0], args[1], expectedValue)
			os.Exit(1)
		}
	} else {
		fmt.Fprintf(os.Stderr, "Unexpected property %s value attempted to be set", args[0])
		os.Exit(1)
	}

}

func handleRemoveFake(args []string) {
	if len(args) > 1 {
		fmt.Fprintf(os.Stderr, "Invalid number of arguments got: %d, want 1", len(args))
		os.Exit(1)
	}
	// Check the property name
	parts := strings.Split(args[0], ".")
	switch len(parts) {
	case 2:
		if parts[0] != "device_config" || parts[1] != "old-device-name" {
			fmt.Fprintf(os.Stderr, `BUG: An internal command error occurred.
			Config key not found`)
			os.Exit(1)
		}
	default:
		fmt.Fprintf(os.Stderr, "Unexpected property being removed: %s", parts)
		os.Exit(1)
	}
}

func fakeSFTP(args []string, stdin *os.File) {
	expected := []string{}
	sshConfigMatch := "/.*/sshconfig"
	if os.Getenv("FSERVE_TEST_USE_CUSTOM_SSH_CONFIG") != "" {
		sshConfigMatch = "custom-sshconfig"
	}
	sshConfigArgs := []string{"-F", sshConfigMatch}
	expected = append(expected, sshConfigArgs...)

	targetaddr := "[fe80::c0ff:eee:fe00:4444%en0]"

	customSSHPortArgs := []string{"-p", "1022"}
	if os.Getenv("FSERVE_TEST_USE_CUSTOM_SSH_PORT") != "" {
		expected = append(expected, customSSHPortArgs...)
	}

	privateKeyArgs := []string{"-i", "private-key"}
	if os.Getenv("FSERVE_TEST_USE_PRIVATE_KEY") != "" {
		expected = append(expected, privateKeyArgs...)
	}

	expected = append(expected, "-q", "-b", "-", targetaddr)

	ok := len(args) == len(expected)
	if ok {
		for i := range args {
			if strings.Contains(expected[i], "*") {
				expectedPattern := regexp.MustCompile(expected[i])
				ok = ok && expectedPattern.MatchString(args[i])
			} else {
				ok = ok && args[i] == expected[i]
			}
		}
	}
	if !ok {
		fmt.Fprintf(os.Stderr, "unexpected sftp args  %v expected %v", args, expected)
		os.Exit(1)
	}

	expectedSrc := "/some/src/file"
	expectedDst := "/dst/file"

	expectedSFTPInput := fmt.Sprintf("get %v %v", expectedSrc, expectedDst)

	if os.Getenv("SFTP_TO_TARGET") == "1" {
		expectedSFTPInput = fmt.Sprintf("put %v %v", expectedSrc, expectedDst)
	}

	inputToSFTP, err := io.ReadAll(stdin)
	if err != nil {
		fmt.Fprintf(os.Stderr, "got error converting stdin to string: %v", err)
		os.Exit(1)
	}
	actualInputToSFTP := string(inputToSFTP)
	if actualInputToSFTP != expectedSFTPInput {
		fmt.Fprintf(os.Stderr, "expected %v, got %v", expectedSFTPInput, actualInputToSFTP)
		os.Exit(1)
	}
}

func fakeSSH(args []string) {
	expected := []string{}
	expectedHostConnection := []string{}
	expectedSetSource := []string{}
	privateKeyArgs := []string{"-i", "private-key"}

	sshConfigMatch := "/.*/sshconfig"
	if os.Getenv("FSERVE_TEST_USE_CUSTOM_SSH_CONFIG") != "" {
		sshConfigMatch = "custom-sshconfig"
	}
	sshConfigArgs := []string{"-F", sshConfigMatch}

	hostaddr := "fe80::c0ff:eeee:fefe:c000%eth1"
	targetaddr := resolvedAddr
	targetIndex := 2

	expectedHostConnection = append(expectedHostConnection, sshConfigArgs...)
	expectedSetSource = append(expectedSetSource, sshConfigArgs...)

	customSSHPortArgs := []string{"-p", "1022"}
	if os.Getenv("FSERVE_TEST_USE_CUSTOM_SSH_PORT") != "" {
		expectedHostConnection = append(expectedHostConnection, customSSHPortArgs...)
		expectedSetSource = append(expectedSetSource, customSSHPortArgs...)
		targetIndex = targetIndex + 2
	}

	if os.Getenv("FSERVE_TEST_USE_PRIVATE_KEY") != "" {
		targetIndex = targetIndex + 2
		expectedHostConnection = append(expectedHostConnection, privateKeyArgs...)
		expectedSetSource = append(expectedSetSource, privateKeyArgs...)

	}

	if args[targetIndex] == resolvedAddr {
		hostaddr = "fe80::c0ff:eeee:fefe:c000%eth1"

	} else {
		targetaddr = args[targetIndex]
		hostaddr = "10.10.1.12"
	}

	expectedHostConnection = append(expectedHostConnection, targetaddr, "echo", "$SSH_CONNECTION")

	if args[len(args)-1] == "$SSH_CONNECTION" {
		expected = expectedHostConnection
		fmt.Printf("%v 54545 fe80::c00f:f0f0:eeee:cccc 22\n", hostaddr)
	}

	ok := len(args) == len(expected)
	if ok {
		for i := range args {
			if strings.Contains(expected[i], "*") {
				expectedPattern := regexp.MustCompile(expected[i])
				ok = ok && expectedPattern.MatchString(args[i])
			} else {
				ok = ok && args[i] == expected[i]
			}
		}
	}
	if !ok {
		fmt.Fprintf(os.Stderr, "unexpected ssh args  %v expected %v", args, expected)
		os.Exit(1)
	}
}

func fakeSSHKeygen(args []string) {
	expectedPrivate := []string{"-P", "", "-t", "ed25519", "-f", "/.*/_TEMP_HOME/.ssh/fuchsia_ed25519", "-C", "testuser@test-host generated by Fuchsia GN SDK"}
	expectedPublic := []string{"-y", "-f", "/.*/_TEMP_HOME/.ssh/fuchsia_ed25519"}
	expected := []string{}
	if len(args) == 0 {
		fmt.Fprintf(os.Stderr, "expected ssh-keygen args")
		os.Exit(1)
	}
	if args[0] == "-P" {
		expected = expectedPrivate
	} else if args[0] == "-y" {
		expected = expectedPublic
		fmt.Println("ssh-ed25519 AAAAC3NzaC1lTESTNTE5AAAAILxVYY7Q++kWUCmlfK1B6JQ9FPRaee05Te/PSHWVTeST testuser@test-host generated by Fuchsia GN SDK")
	}
	ok := len(args) == len(expected)
	if ok {
		for i := range args {
			if strings.Contains(expected[i], "*") {
				expectedPattern := regexp.MustCompile(expected[i])
				ok = ok && expectedPattern.MatchString(args[i])
			} else {
				ok = ok && args[i] == expected[i]
			}
		}
	}
	if !ok {
		fmt.Fprintf(os.Stderr, "unexpected ssh-keygen args  %v exepected %v", args, expected)
		os.Exit(1)
	}
}

func clearTestEnv() {
	ExecCommand = exec.Command

	os.Unsetenv("TEST_FFX_TARGET_LIST_OUTPUT")
	os.Unsetenv("TEST_FFX_TARGET_DEFAULT_GET")
	os.Unsetenv("TEST_GET_SSH_ADDRESS_OUTPUT")
	os.Unsetenv("FFX_HAS_NEW_DEVICE")
	os.Unsetenv("FFX_ISOLATE_DIR")

	GetUserHomeDir = DefaultGetUserHomeDir
	GetUsername = DefaultGetUsername
	GetHostname = DefaultGetHostname

	os.Unsetenv("TEST_EXPECTED_SET_DATA")
	os.Unsetenv("TEST_CURRENT_DEVICE_DATA")
}