commit 824e01e762c1ae342326fbe2dfc6f2eef25b9484
author Dale Sather <dalesat@google.com> Wed Jul 08 23:54:14 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Wed Jul 08 23:54:14 2020 +0000
tree b8798d08d60ce458b30c83c18759a3ff5acb55a9
parent bebdb8a08be32bbcb60c436a7fd3c0e34e42e46b

[mdns] change default ttl for PTR resources from 4500s to 120s

RFC6762 recommends that PTR records have a time-to-live of 120
seconds. The default was previously set to 4500 seconds (75
minutes) in the mdns implementation.

Fixed: 55765

Test: fx test mdns-tests
      Manifest constant change only. Any regressions will be
      detected by existing integration tests.
Change-Id: If63e5cb05b5c3f8d50535cf3ed31c1cb17428d6f
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/405445
API-Review: Dale Sather <dalesat@google.com>
Testability-Review: Dale Sather <dalesat@google.com>
Reviewed-by: Austin Foxley <afoxley@google.com>
Commit-Queue: Dale Sather <dalesat@google.com>

sdk/fidl/fuchsia.net.mdns/fuchsia.net.mdns.api

diff --git a/sdk/fidl/fuchsia.net.mdns/fuchsia.net.mdns.api b/sdk/fidl/fuchsia.net.mdns/fuchsia.net.mdns.api
index ae72a7a..8db1bff 100644
--- a/sdk/fidl/fuchsia.net.mdns/fuchsia.net.mdns.api
+++ b/sdk/fidl/fuchsia.net.mdns/fuchsia.net.mdns.api
@@ -1,3 +1,3 @@
 {
-  "fidl/fuchsia.net.mdns": "6f9bbebd14e7297973747a223b84cba7"
+  "fidl/fuchsia.net.mdns": "4352493ab4769297c727067d664eb5e0"
 }
\ No newline at end of file

sdk/fidl/fuchsia.net.mdns/mdns.fidl

diff --git a/sdk/fidl/fuchsia.net.mdns/mdns.fidl b/sdk/fidl/fuchsia.net.mdns/mdns.fidl
index b0a5808..b121cb7 100644
--- a/sdk/fidl/fuchsia.net.mdns/mdns.fidl
+++ b/sdk/fidl/fuchsia.net.mdns/mdns.fidl
@@ -308,7 +308,7 @@
 
 const uint16 DEFAULT_SRV_PRIORITY = 0;
 const uint16 DEFAULT_SRV_WEIGHT = 0;
-const zx.duration DEFAULT_PTR_TTL = 4500000000000; // 75 minutes
+const zx.duration DEFAULT_PTR_TTL = 120000000000; // 2 minutes
 const zx.duration DEFAULT_SRV_TTL = 120000000000; // 2 minutes
 const zx.duration DEFAULT_TXT_TTL = 4500000000000; // 75 minutes
 const uint32 MAX_TEXT_STRINGS = 256;

src/connectivity/network/mdns/service/mdns.h

diff --git a/src/connectivity/network/mdns/service/mdns.h b/src/connectivity/network/mdns/service/mdns.h
index 1e518f7..38a90d1 100644
--- a/src/connectivity/network/mdns/service/mdns.h
+++ b/src/connectivity/network/mdns/service/mdns.h
@@ -71,7 +71,7 @@
     std::vector<std::string> text_;
     uint16_t srv_priority_ = 0;
     uint16_t srv_weight_ = 0;
-    uint32_t ptr_ttl_seconds_ = 4500;  // default 75 minutes
+    uint32_t ptr_ttl_seconds_ = 120;   // default 2 minutes
     uint32_t srv_ttl_seconds_ = 120;   // default 2 minutes
     uint32_t txt_ttl_seconds_ = 4500;  // default 75 minutes
   };