src/storage/blobfs/test/unit/blob_test.cc

// Copyright 2020 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "src/storage/blobfs/blob.h"

#include <zircon/assert.h>
#include <zircon/errors.h>
#include <zircon/types.h>

#include <chrono>
#include <condition_variable>
#include <memory>

#include <block-client/cpp/fake-device.h>
#include <fbl/auto_call.h>
#include <fs/vfs_types.h>
#include <gmock/gmock.h>
#include <gtest/gtest.h>

#include "src/lib/digest/digest.h"
#include "src/lib/digest/node-digest.h"
#include "src/storage/blobfs/blob_layout.h"
#include "src/storage/blobfs/blobfs.h"
#include "src/storage/blobfs/common.h"
#include "src/storage/blobfs/format.h"
#include "src/storage/blobfs/fsck.h"
#include "src/storage/blobfs/mkfs.h"
#include "src/storage/blobfs/test/blob_utils.h"
#include "src/storage/blobfs/test/unit/utils.h"

namespace blobfs {
namespace {

constexpr const char kEmptyBlobName[] =
    "15ec7bf0b50732b49f8228e07d24365338f9e3ab994b00af08e5a3bffe55fd8b";

constexpr uint32_t kBlockSize = 512;
constexpr uint32_t kNumBlocks = 400 * kBlobfsBlockSize / kBlockSize;
namespace fio = ::llcpp::fuchsia::io;

class BlobTest : public testing::TestWithParam<std::tuple<BlobLayoutFormat, CompressionAlgorithm>> {
 public:
  virtual uint64_t GetOldestMinorVersion() const { return kBlobfsCurrentMinorVersion; }

  void SetUp() override {
    auto device = std::make_unique<block_client::FakeBlockDevice>(kNumBlocks, kBlockSize);
    device_ = device.get();

    FilesystemOptions filesystem_options{
        .blob_layout_format = std::get<0>(GetParam()),
        .oldest_minor_version = GetOldestMinorVersion(),
    };
    ASSERT_EQ(FormatFilesystem(device.get(), filesystem_options), ZX_OK);

    MountOptions mount_options{.compression_settings = {
                                   .compression_algorithm = std::get<1>(GetParam()),
                               }};
    auto blobfs_or = Blobfs::Create(loop_.dispatcher(), std::move(device), mount_options);
    ASSERT_TRUE(blobfs_or.is_ok());
    fs_ = std::move(blobfs_or.value());
  }

  void TearDown() override { device_ = nullptr; }

  fbl::RefPtr<fs::Vnode> OpenRoot() const {
    fbl::RefPtr<fs::Vnode> root;
    EXPECT_EQ(fs_->OpenRootNode(&root), ZX_OK);
    return root;
  }

 protected:
  async::Loop loop_{&kAsyncLoopConfigAttachToCurrentThread};

  block_client::FakeBlockDevice* device_;
  std::unique_ptr<Blobfs> fs_;
};

// Return an old revsions so we can test migrating blobs.
class BlobTestWithOldMinorVersion : public BlobTest {
 public:
  uint64_t GetOldestMinorVersion() const override { return kBlobfsMinorVersionBackupSuperblock; }
};

TEST_P(BlobTest, TruncateWouldOverflow) {
  fbl::RefPtr root = OpenRoot();
  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Create(kEmptyBlobName, 0, &file), ZX_OK);

  EXPECT_EQ(file->Truncate(UINT64_MAX), ZX_ERR_OUT_OF_RANGE);
}

// Tests that Blob::Sync issues the callback in the right way in the right cases. This does not
// currently test that the data was actually written to the block device.
TEST_P(BlobTest, SyncBehavior) {
  auto root = OpenRoot();

  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 64);
  memmove(info->path, info->path + 1, strlen(info->path));  // Remove leading slash.

  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Create(info->path, 0, &file), ZX_OK);

  size_t out_actual = 0;
  EXPECT_EQ(file->Truncate(info->size_data), ZX_OK);

  // Try syncing before the data has been written. This currently issues an error synchronously but
  // we accept either synchronous or asynchronous callbacks.
  sync_completion_t sync;
  file->Sync([&](zx_status_t status) {
    EXPECT_EQ(ZX_ERR_BAD_STATE, status);
    sync_completion_signal(&sync);
  });
  sync_completion_wait(&sync, ZX_TIME_INFINITE);

  EXPECT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
  EXPECT_EQ(info->size_data, out_actual);

  // It's difficult to get a precise hook into the period between when data has been written and
  // when it has been flushed to disk.  The journal will delay flushing metadata, so the following
  // should test sync being called before metadata has been flushed, and then again afterwards.
  for (int i = 0; i < 2; ++i) {
    sync_completion_t sync;
    file->Sync([&](zx_status_t status) {
      EXPECT_EQ(ZX_OK, status) << i;
      sync_completion_signal(&sync);
    });
    sync_completion_wait(&sync, ZX_TIME_INFINITE);
  }
}

TEST_P(BlobTest, ReadingBlobZerosTail) {
  // Remount without compression so that we can manipulate the data that is loaded.
  MountOptions options = {.compression_settings = {
                              .compression_algorithm = CompressionAlgorithm::UNCOMPRESSED,
                          }};
  auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)), options);
  ASSERT_TRUE(blobfs_or.is_ok());
  fs_ = std::move(blobfs_or.value());

  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 64);
  uint64_t block;
  {
    auto root = OpenRoot();
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    size_t out_actual = 0;
    EXPECT_EQ(file->Truncate(info->size_data), ZX_OK);
    EXPECT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    EXPECT_EQ(out_actual, info->size_data);
    {
      auto blob = fbl::RefPtr<Blob>::Downcast(file);
      block = fs_->GetNode(blob->Ino())->extents[0].Start() + DataStartBlock(fs_->Info());
    }
  }

  // Unmount.
  std::unique_ptr<block_client::BlockDevice> device = Blobfs::Destroy(std::move(fs_));

  // Read the block that contains the blob.
  storage::VmoBuffer buffer;
  ASSERT_EQ(buffer.Initialize(device.get(), 1, kBlobfsBlockSize, "test_buffer"), ZX_OK);
  block_fifo_request_t request = {
      .opcode = BLOCKIO_READ,
      .vmoid = buffer.vmoid(),
      .length = kBlobfsBlockSize / kBlockSize,
      .vmo_offset = 0,
      .dev_offset = block * kBlobfsBlockSize / kBlockSize,
  };
  ASSERT_EQ(device->FifoTransaction(&request, 1), ZX_OK);

  // Corrupt the end of the page.
  static_cast<uint8_t*>(buffer.Data(0))[PAGE_SIZE - 1] = 1;

  // Write the block back.
  request.opcode = BLOCKIO_WRITE;
  ASSERT_EQ(device->FifoTransaction(&request, 1), ZX_OK);

  // Remount and try and read the blob.
  auto remounted_blobfs_or = Blobfs::Create(loop_.dispatcher(), std::move(device), options);
  ASSERT_TRUE(remounted_blobfs_or.is_ok());
  fs_ = std::move(remounted_blobfs_or.value());

  auto root = OpenRoot();
  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);

  // Trying to read from the blob would fail if the tail wasn't zeroed.
  size_t actual;
  uint8_t data;
  EXPECT_EQ(file->Read(&data, 1, 0, &actual), ZX_OK);
  {
    zx::vmo vmo = {};
    size_t data_size;
    EXPECT_EQ(file->GetVmo(fio::VMO_FLAG_READ, &vmo, &data_size), ZX_OK);
    EXPECT_EQ(data_size, 64ul);

    size_t vmo_size;
    EXPECT_EQ(vmo.get_size(&vmo_size), ZX_OK);
    ASSERT_EQ(vmo_size, size_t{PAGE_SIZE});

    uint8_t data;
    EXPECT_EQ(vmo.read(&data, PAGE_SIZE - 1, 1), ZX_OK);
    // The corrupted bit in the tail was zeroed when being read.
    EXPECT_EQ(data, 0);
  }
}

TEST_P(BlobTestWithOldMinorVersion, ReadWriteAllCompressionFormats) {
  auto root = OpenRoot();
  std::unique_ptr<BlobInfo> info = GenerateRealisticBlob("", 1 << 16);

  // Write the blob
  {
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    size_t out_actual = 0;
    EXPECT_EQ(file->Truncate(info->size_data), ZX_OK);
    EXPECT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    EXPECT_EQ(out_actual, info->size_data);
  }

  for (int pass = 0; pass < 2; ++pass) {
    // Read back the blob
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
    size_t actual;
    uint8_t data[info->size_data];
    EXPECT_EQ(file->Read(&data, info->size_data, 0, &actual), ZX_OK);
    EXPECT_EQ(info->size_data, actual);
    EXPECT_EQ(memcmp(data, info->data.get(), info->size_data), 0);

    if (pass == 1) {
      // Check that it got migrated.
      auto blob = fbl::RefPtr<Blob>::Downcast(file);
      EXPECT_TRUE(SupportsPaging(blob->GetNode()));
      EXPECT_GE(fs_->Info().oldest_minor_version, kBlobfsMinorVersionNoOldCompressionFormats);
    } else {
      // Remount
      auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)));
      ASSERT_TRUE(blobfs_or.is_ok());
      fs_ = std::move(blobfs_or.value());
      root = OpenRoot();
    }
  }

  EXPECT_EQ(Fsck(Blobfs::Destroy(std::move(fs_)), MountOptions()), ZX_OK);
}

TEST_P(BlobTest, WriteBlobWithSharedBlockInCompactFormat) {
  // Remount without compression so we can force a specific blob size in storage.
  MountOptions options = {.compression_settings = {
                              .compression_algorithm = CompressionAlgorithm::UNCOMPRESSED,
                          }};
  auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)), options);
  ASSERT_TRUE(blobfs_or.is_ok());
  fs_ = std::move(blobfs_or.value());

  // Create a blob where the Merkle tree in the compact layout fits perfectly into the space
  // remaining at the end of the blob.
  ASSERT_EQ(fs_->Info().block_size, digest::kDefaultNodeSize);
  std::unique_ptr<BlobInfo> info =
      GenerateRealisticBlob("", (digest::kDefaultNodeSize - digest::kSha256Length) * 3);
  {
    if (GetBlobLayoutFormat(fs_->Info()) == BlobLayoutFormat::kCompactMerkleTreeAtEnd) {
      std::unique_ptr<MerkleTreeInfo> merkle_tree =
          CreateMerkleTree(info->data.get(), info->size_data, /*use_compact_format=*/true);
      EXPECT_EQ(info->size_data + merkle_tree->merkle_tree_size, digest::kDefaultNodeSize * 3);
    }
    fbl::RefPtr<fs::Vnode> file;
    auto root = OpenRoot();
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    size_t out_actual = 0;
    EXPECT_EQ(file->Truncate(info->size_data), ZX_OK);
    EXPECT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    EXPECT_EQ(out_actual, info->size_data);
  }

  // Remount to avoid caching.
  auto remounted_blobfs_or =
      Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)), options);
  ASSERT_TRUE(remounted_blobfs_or.is_ok());
  fs_ = std::move(remounted_blobfs_or.value());

  // Read back the blob
  {
    fbl::RefPtr<fs::Vnode> file;
    auto root = OpenRoot();
    ASSERT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
    size_t actual;
    uint8_t data[info->size_data];
    EXPECT_EQ(file->Read(&data, info->size_data, 0, &actual), ZX_OK);
    EXPECT_EQ(info->size_data, actual);
    EXPECT_EQ(memcmp(data, info->data.get(), info->size_data), 0);
  }
}

TEST_P(BlobTest, WriteErrorsAreFused) {
  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", kBlockSize * kNumBlocks);
  auto root = OpenRoot();
  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
  ASSERT_EQ(file->Truncate(info->size_data), ZX_OK);
  uint64_t out_actual;
  EXPECT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_ERR_NO_SPACE);
  // Writing just 1 byte now should see the same error returned.
  EXPECT_EQ(file->Write(info->data.get(), 1, 0, &out_actual), ZX_ERR_NO_SPACE);
}

TEST_P(BlobTest, UnlinkBlocksUntilNoVmoChildren) {
  std::unique_ptr<BlobInfo> info = GenerateRealisticBlob("", 1 << 16);
  auto root = OpenRoot();

  // Write the blob
  {
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    size_t out_actual = 0;
    ASSERT_EQ(file->Truncate(info->size_data), ZX_OK);
    ASSERT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    ASSERT_EQ(file->Close(), ZX_OK);
    ASSERT_EQ(out_actual, info->size_data);
  }

  // Get a copy of the VMO, but discard the vnode reference.
  zx::vmo vmo = [&]() {
    fbl::RefPtr<fs::Vnode> file;
    // Lookup doesn't call Open, so no need to Close later.
    EXPECT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
    zx::vmo vmo = {};
    size_t data_size;
    EXPECT_EQ(file->GetVmo(fio::VMO_FLAG_READ, &vmo, &data_size), ZX_OK);
    EXPECT_EQ(data_size, info->size_data);
    return vmo;
  }();

  ASSERT_EQ(root->Unlink(info->path + 1, /* must_be_dir=*/false), ZX_OK);
  uint8_t buf[8192];
  for (size_t off = 0; off < 1 << 16; off += kBlobfsBlockSize) {
    EXPECT_EQ(vmo.read(buf, off, kBlobfsBlockSize), ZX_OK);
  }
}

TEST_P(BlobTest, VmoChildDeletedTriggersPurging) {
  std::unique_ptr<BlobInfo> info = GenerateRealisticBlob("", 1 << 16);
  auto root = OpenRoot();

  // Write the blob
  {
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    size_t out_actual = 0;
    ASSERT_EQ(file->Truncate(info->size_data), ZX_OK);
    ASSERT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    ASSERT_EQ(file->Close(), ZX_OK);
    ASSERT_EQ(out_actual, info->size_data);
  }

  // Get a copy of the VMO, but discard the vnode reference.
  zx::vmo vmo = [&]() {
    fbl::RefPtr<fs::Vnode> file;
    // Lookup doesn't call Open, so no need to Close later.
    EXPECT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
    zx::vmo vmo = {};
    size_t data_size;
    EXPECT_EQ(file->GetVmo(fio::VMO_FLAG_READ, &vmo, &data_size), ZX_OK);
    EXPECT_EQ(data_size, info->size_data);
    return vmo;
  }();

  ASSERT_EQ(root->Unlink(info->path + 1, /* must_be_dir=*/false), ZX_OK);

  // Delete the VMO. This should eventually trigger deletion of the blob.
  vmo.reset();

  // Unfortunately, polling the filesystem is the best option for checking the file as deleted.
  bool deleted = false;
  const auto start = std::chrono::steady_clock::now();
  constexpr auto kMaxWait = std::chrono::seconds(60);
  while (std::chrono::steady_clock::now() <= start + kMaxWait) {
    loop_.RunUntilIdle();

    fbl::RefPtr<fs::Vnode> file;
    zx_status_t status = root->Lookup(info->path + 1, &file);
    if (status == ZX_ERR_NOT_FOUND) {
      deleted = true;
      break;
    }
    ASSERT_EQ(status, ZX_OK);

    zx::nanosleep(zx::deadline_after(zx::sec(1)));
  }
  EXPECT_TRUE(deleted);
}

TEST_P(BlobTest, BlobPrepareWriteFailure) {
  // Remount without compression so that we can trigger failure.
  MountOptions options = {.compression_settings = {
                              .compression_algorithm = CompressionAlgorithm::UNCOMPRESSED,
                          }};
  auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)), options);
  ASSERT_TRUE(blobfs_or.is_ok());
  fs_ = std::move(blobfs_or.value());

  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 64);
  {
    auto root = OpenRoot();
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    auto blob = fbl::RefPtr<Blob>::Downcast(file);
    // PrepareWrite should assert on debug builds and return ZX_ERR_INTERNAL
    // on non-debug builds.
#ifndef NDEBUG
    ASSERT_DEATH({ blob->PrepareWrite(info->size_data, /*compress=*/true); }, "");
#else
    EXPECT_EQ(blob->PrepareWrite(info->size_data, /*compress=*/true), ZX_ERR_INTERNAL);
#endif
    ASSERT_EQ(file->Close(), ZX_OK);
  }
}

std::string VmoName(const zx::vmo& vmo) {
  char buf[ZX_MAX_NAME_LEN + 1] = {'\0'};
  EXPECT_EQ(vmo.get_property(ZX_PROP_NAME, buf, ZX_MAX_NAME_LEN), ZX_OK);
  return std::string(buf, ::strlen(buf));
}

TEST_P(BlobTest, VmoNameActiveWhileFdOpen) {
  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 64);
  auto root = OpenRoot();
  const std::string active_name = std::string("blob-").append(std::string_view(info->path + 1, 8));
  const std::string inactive_name =
      std::string("inactive-blob-").append(std::string_view(info->path + 1, 8));

  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
  size_t out_actual = 0;
  ASSERT_EQ(file->Truncate(info->size_data), ZX_OK);
  ASSERT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
  // Make sure the async part of the write finishes.
  loop_.RunUntilIdle();
  ASSERT_EQ(file->Close(), ZX_OK);
  ASSERT_EQ(file->OpenValidating(fs::VnodeConnectionOptions(), nullptr), ZX_OK);
  auto blob = fbl::RefPtr<Blob>::Downcast(std::move(file));

  // Blobfs lazily creates the data VMO on first read.
  EXPECT_FALSE(blob->DataVmo());
  char c;
  size_t actual;
  ASSERT_EQ(blob->Read(&c, sizeof(c), 0u, &actual), ZX_OK);
  EXPECT_TRUE(blob->DataVmo());
  EXPECT_EQ(VmoName(blob->DataVmo()), active_name);

  ASSERT_EQ(blob->Close(), ZX_OK);
  EXPECT_EQ(VmoName(blob->DataVmo()), inactive_name);

  ASSERT_EQ(blob->OpenValidating(fs::VnodeConnectionOptions(), nullptr), ZX_OK);
  EXPECT_EQ(VmoName(blob->DataVmo()), active_name);

  ASSERT_EQ(blob->Close(), ZX_OK);
}

TEST_P(BlobTest, VmoNameActiveWhileVmoClonesExist) {
  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 64);
  auto root = OpenRoot();
  const std::string active_name = std::string("blob-").append(std::string_view(info->path + 1, 8));
  const std::string inactive_name =
      std::string("inactive-blob-").append(std::string_view(info->path + 1, 8));

  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
  size_t out_actual = 0;
  ASSERT_EQ(file->Truncate(info->size_data), ZX_OK);
  ASSERT_EQ(file->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
  // Make sure the async part of the write finishes.
  loop_.RunUntilIdle();
  ASSERT_EQ(file->Close(), ZX_OK);
  ASSERT_EQ(file->OpenValidating(fs::VnodeConnectionOptions(), nullptr), ZX_OK);
  auto blob = fbl::RefPtr<Blob>::Downcast(std::move(file));

  zx::vmo vmo;
  size_t size;
  ASSERT_EQ(blob->GetVmo(fio::VMO_FLAG_READ, &vmo, &size), ZX_OK);
  ASSERT_EQ(blob->Close(), ZX_OK);
  EXPECT_EQ(VmoName(blob->DataVmo()), active_name);

  // The ZX_VMO_ZERO_CHILDREN signal is asynchronous; unfortunately polling is the best we can do.
  vmo.reset();
  bool active = true;
  const auto start = std::chrono::steady_clock::now();
  constexpr auto kMaxWait = std::chrono::seconds(60);
  while (std::chrono::steady_clock::now() <= start + kMaxWait) {
    loop_.RunUntilIdle();
    if (VmoName(blob->DataVmo()) == inactive_name) {
      active = false;
      break;
    }
    zx::nanosleep(zx::deadline_after(zx::sec(1)));
  }
  EXPECT_FALSE(active) << "Name did not become inactive after deadline";
}

using BlobMigrationTest = BlobTestWithOldMinorVersion;

TEST_P(BlobMigrationTest, MigrateLargeBlobSucceeds) {
  auto root = OpenRoot();
  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", 300 * 1024);

  // Write the blob
  {
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    auto blob = fbl::RefPtr<Blob>::Downcast(file);
    size_t out_actual = 0;
    EXPECT_EQ(blob->PrepareWrite(info->size_data, /*compress=*/true), ZX_OK);
    EXPECT_EQ(blob->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    EXPECT_EQ(out_actual, info->size_data);
  }

  // Remount
  auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)));
  ASSERT_TRUE(blobfs_or.is_ok());
  fs_ = std::move(blobfs_or.value());
  root = OpenRoot();

  // Read back the blob
  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
  size_t actual;
  auto data = std::make_unique<uint8_t[]>(info->size_data);
  EXPECT_EQ(file->Read(data.get(), info->size_data, 0, &actual), ZX_OK);
  EXPECT_EQ(info->size_data, actual);
  EXPECT_EQ(memcmp(data.get(), info->data.get(), info->size_data), 0);

  auto blob = fbl::RefPtr<Blob>::Downcast(file);
  EXPECT_TRUE(SupportsPaging(blob->GetNode()));
  EXPECT_GE(fs_->Info().oldest_minor_version, kBlobfsMinorVersionNoOldCompressionFormats);

  EXPECT_EQ(Fsck(Blobfs::Destroy(std::move(fs_)), MountOptions()), ZX_OK);
}

TEST_P(BlobMigrationTest, MigrateWhenNoSpaceSkipped) {
  auto root = OpenRoot();
  // Create a blob that takes up half the disk.
  std::unique_ptr<BlobInfo> info = GenerateRandomBlob("", kNumBlocks * kBlockSize / 2);

  {
    fbl::RefPtr<fs::Vnode> file;
    ASSERT_EQ(root->Create(info->path + 1, 0, &file), ZX_OK);
    auto blob = fbl::RefPtr<Blob>::Downcast(file);
    size_t out_actual = 0;
    EXPECT_EQ(blob->PrepareWrite(info->size_data, /*compress=*/true), ZX_OK);
    EXPECT_EQ(blob->Write(info->data.get(), info->size_data, 0, &out_actual), ZX_OK);
    EXPECT_EQ(out_actual, info->size_data);
  }

  // Remount
  auto blobfs_or = Blobfs::Create(loop_.dispatcher(), Blobfs::Destroy(std::move(fs_)));
  ASSERT_TRUE(blobfs_or.is_ok());
  fs_ = std::move(blobfs_or.value());
  root = OpenRoot();

  // Read back the blob
  fbl::RefPtr<fs::Vnode> file;
  ASSERT_EQ(root->Lookup(info->path + 1, &file), ZX_OK);
  size_t actual;
  auto data = std::make_unique<uint8_t[]>(info->size_data);
  EXPECT_EQ(file->Read(data.get(), info->size_data, 0, &actual), ZX_OK);
  EXPECT_EQ(info->size_data, actual);
  EXPECT_EQ(memcmp(data.get(), info->data.get(), info->size_data), 0);

  // The blob shouldn't have been migrated and the filesystem oldest minor version shouldn't have
  // changed.
  EXPECT_GE(fs_->Info().oldest_minor_version, kBlobfsMinorVersionBackupSuperblock);

  EXPECT_EQ(Fsck(Blobfs::Destroy(std::move(fs_)), MountOptions()), ZX_OK);
}

std::string GetTestParamName(
    const ::testing::TestParamInfo<std::tuple<BlobLayoutFormat, CompressionAlgorithm>>& param) {
  const auto& [layout, algorithm] = param.param;
  return GetBlobLayoutFormatNameForTests(layout) + GetCompressionAlgorithmName(algorithm);
}

INSTANTIATE_TEST_SUITE_P(
    /*no prefix*/, BlobTest,
    testing::Combine(testing::Values(BlobLayoutFormat::kPaddedMerkleTreeAtStart,
                                     BlobLayoutFormat::kCompactMerkleTreeAtEnd),
                     testing::Values(CompressionAlgorithm::CHUNKED)),
    GetTestParamName);

INSTANTIATE_TEST_SUITE_P(
    /*no prefix*/, BlobTestWithOldMinorVersion,
    testing::Combine(testing::Values(BlobLayoutFormat::kPaddedMerkleTreeAtStart),
                     testing::Values(CompressionAlgorithm::UNCOMPRESSED, CompressionAlgorithm::LZ4,
                                     CompressionAlgorithm::ZSTD,
                                     CompressionAlgorithm::ZSTD_SEEKABLE,
                                     CompressionAlgorithm::CHUNKED)),
    GetTestParamName);

INSTANTIATE_TEST_SUITE_P(
    /*no prefix*/, BlobMigrationTest,
    testing::Combine(testing::Values(BlobLayoutFormat::kPaddedMerkleTreeAtStart),
                     testing::Values(CompressionAlgorithm::ZSTD)),
    GetTestParamName);

}  // namespace
}  // namespace blobfs