commit 3cac4f30a7fec52287418a75f1efc492a2d66903
author Josh Gargus <jjosh@google.com> Wed Jul 08 19:55:53 2020 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Wed Jul 08 19:55:53 2020 +0000
tree 8d2fc4d5660605c85effda7af9ec28a6d6f20ace
parent 59ac8a77415ba6401eca49a59b56efaf5b268750

[scenic] Fix screenshots with scenic_display_frame_number.

When the build arg scenic_display_frame_number=true, Scenic blits
the frame number into rendered frames.  This requires the
VK_IMAGE_USAGE_TRANSFER_DST_BIT to be set, which wasn't
being done until this CL.

Bug: 55548

Test: gfx_pixeltests no longer crash when
scenic_display_frame_number=true

Change-Id: I92ad30ddea6e3d66a7bff0850e101e800db585a3
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/404254
Commit-Queue: Josh Gargus <jjosh@google.com>
Reviewed-by: Yilong Li <liyl@google.com>
Testability-Review: Yilong Li <liyl@google.com>

src/ui/scenic/lib/gfx/screenshotter.cc

diff --git a/src/ui/scenic/lib/gfx/screenshotter.cc b/src/ui/scenic/lib/gfx/screenshotter.cc
index 50e1978..104594a 100644
--- a/src/ui/scenic/lib/gfx/screenshotter.cc
+++ b/src/ui/scenic/lib/gfx/screenshotter.cc
@@ -165,8 +165,8 @@
   image_info.format = kScenicScreenshotFormat;
   image_info.width = width;
   image_info.height = height;
-  image_info.usage =
-      vk::ImageUsageFlagBits::eColorAttachment | vk::ImageUsageFlagBits::eTransferSrc;
+  image_info.usage = vk::ImageUsageFlagBits::eColorAttachment |
+                     vk::ImageUsageFlagBits::eTransferSrc | vk::ImageUsageFlagBits::eTransferDst;
 
   // TODO(ES-7): cache is never trimmed.
   escher::ImagePtr image = escher->image_cache()->NewImage(image_info);