Revert "[sl4f] Disable 'trace via facade' test on NUC"
This reverts commit 9fef1cc810560b3c461b8205ee7458d44a6a44ea.
Reason for revert: didn't actually fix the builder. I suspect it only passed in CQ because the try builder unexpectedly sharded the tests differently from the CI builder, which I'll investigate separately.
Original change's description:
> [sl4f] Disable 'trace via facade' test on NUC
>
> This test's failure to properly clean up resources when it times out
> seems to be the underlying cause (or one of several underlying causes)
> of non-hermetic test ordering bugs seen described in
> https://fxbug.dev/73859.
>
> When this test times out, later test cases get stuck and the shard
> eventually times out, e.g.: https://ci.chromium.org/b/8850395944552814656
>
> Test: Running the internal terminal-x64-release-nuc_in_basic_envs
> builder (which is currently red) in CQ using "Choose Tryjobs":
> ci.chromium.org/b/8850141709014083216
>
> Exempt-From-Owner-Approval: emergency change to fix the tree
> Bug: 73859
> Change-Id: I75aa9fc03170625b82cc91ebc4ed23ddb4745903
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/514401
> Reviewed-by: Brian Hamrick <bhamrick@google.com>
TBR=mseaborn@google.com,bhamrick@google.com,olivernewman@google.com,yuanzhi@google.com
Change-Id: I3d14f249651fce5b33567e7efab0a6338f5884b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 73859
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/514880
Reviewed-by: Oliver Newman <olivernewman@google.com>
Commit-Queue: Oliver Newman <olivernewman@google.com>
diff --git a/src/tests/end_to_end/sl4f/test/performance_test.dart b/src/tests/end_to_end/sl4f/test/performance_test.dart
index e1f589c..7b78bc4 100644
--- a/src/tests/end_to_end/sl4f/test/performance_test.dart
+++ b/src/tests/end_to_end/sl4f/test/performance_test.dart
@@ -36,25 +36,20 @@
});
group(sl4f.Sl4f, () {
- // TODO(https://fxbug.dev/73859): This test leaks resources if it times out,
- // causing later tests to break. Re-enable when non-hermeticity is fixed.
- if (Platform.environment['FUCHSIA_DEVICE_TYPE'] !=
- 'Intel NUC Kit NUC7i5DNHE') {
- test('trace via facade', () async {
- final traceSession = await performance.initializeTracing();
- await traceSession.start();
- await Future.delayed(Duration(seconds: 2));
- await traceSession.stop();
- final traceFile = await traceSession.terminateAndDownload('test-trace');
+ test('trace via facade', () async {
+ final traceSession = await performance.initializeTracing();
+ await traceSession.start();
+ await Future.delayed(Duration(seconds: 2));
+ await traceSession.stop();
+ final traceFile = await traceSession.terminateAndDownload('test-trace');
- expect(traceFile.path, matches(RegExp(r'-test-trace-trace.fxt$')));
- expect(
- dumpDir.listSync().map((f) => f.path.split('/').last),
- unorderedMatches([
- matches(RegExp(r'-test-trace-trace.fxt$')),
- ]));
- });
- }
+ expect(traceFile.path, matches(RegExp(r'-test-trace-trace.fxt$')));
+ expect(
+ dumpDir.listSync().map((f) => f.path.split('/').last),
+ unorderedMatches([
+ matches(RegExp(r'-test-trace-trace.fxt$')),
+ ]));
+ });
test('get trace data without writing to file', () async {
final traceSession = await performance.initializeTracing();
