[appmgr] Delete dead feature deprecated-global-dev
Fixed: 83185
Change-Id: Ice372173de61fefa586a0c3fba71b8547d7ba6e2
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/693299
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Shai Barack <shayba@google.com>
Reviewed-by: Adam Barth <abarth@google.com>
diff --git a/docs/concepts/components/v1/component_manifests.md b/docs/concepts/components/v1/component_manifests.md
index 30e89186..d2e091a 100644
--- a/docs/concepts/components/v1/component_manifests.md
+++ b/docs/concepts/components/v1/component_manifests.md
@@ -310,9 +310,6 @@
partition is for storing persistent data that will survive a factory reset,
and is only to be used for specific, approved use cases.
-- `deprecated-global-dev`, which requests access to all of `/dev` rather than a
- given list of items.
-
See [sandboxing](/docs/concepts/process/sandboxing.md) for more information about sandboxing.
[hub]: /docs/concepts/components/v1/hub.md
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/BUILD.gn b/src/sys/appmgr/integration_tests/sandbox/features/BUILD.gn
index 4581b38..a32f9ee 100644
--- a/src/sys/appmgr/integration_tests/sandbox/features/BUILD.gn
+++ b/src/sys/appmgr/integration_tests/sandbox/features/BUILD.gn
@@ -7,7 +7,6 @@
deps = [
"ambient-executable-policy",
"build-info",
- "deprecated-global-dev",
"durable-data",
"factory-data",
"hub",
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/BUILD.gn b/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/BUILD.gn
deleted file mode 100644
index 12c75778..0000000
--- a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/BUILD.gn
+++ /dev/null
@@ -1,31 +0,0 @@
-# Copyright 2021 The Fuchsia Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import("//src/sys/appmgr/integration_tests/sandbox/sandbox_test_package.gni")
-
-group("deprecated-global-dev") {
- testonly = true
- deps = [
- ":has_deprecated_global_dev",
- ":no_deprecated_global_dev",
- ]
-}
-
-sandbox_test_package("has_deprecated_global_dev") {
- sources = [ "has_deprecated_global_dev.cc" ]
-
- deps = [
- "//src/lib/fxl/test:gtest_main",
- "//src/sys/appmgr/integration_tests/sandbox:namespace_test",
- ]
-}
-
-sandbox_test_package("no_deprecated_global_dev") {
- sources = [ "no_deprecated_global_dev.cc" ]
-
- deps = [
- "//src/lib/fxl/test:gtest_main",
- "//src/sys/appmgr/integration_tests/sandbox:namespace_test",
- ]
-}
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/has_deprecated_global_dev.cc b/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/has_deprecated_global_dev.cc
deleted file mode 100644
index f85d8b7f..0000000
--- a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/has_deprecated_global_dev.cc
+++ /dev/null
@@ -1,13 +0,0 @@
-// Copyright 2021 The Fuchsia Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/sys/appmgr/integration_tests/sandbox/namespace_test.h"
-
-TEST_F(NamespaceTest, HasDeprecatedGlobalDev) {
- ExpectExists("/dev");
- // Expect some paths under /dev that it's safe to assume would be present
- ExpectExists("/dev/class");
- ExpectExists("/dev/diagnostics");
- ExpectExists("/dev/sys");
-}
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/has_deprecated_global_dev.cmx b/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/has_deprecated_global_dev.cmx
deleted file mode 100644
index 1aa1a21..0000000
--- a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/has_deprecated_global_dev.cmx
+++ /dev/null
@@ -1,13 +0,0 @@
-{
- "include": [
- "syslog/client.shard.cmx"
- ],
- "program": {
- "binary": "bin/has_deprecated_global_dev"
- },
- "sandbox": {
- "features": [
- "deprecated-global-dev"
- ]
- }
-}
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/no_deprecated_global_dev.cmx b/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/no_deprecated_global_dev.cmx
deleted file mode 100644
index 0f0865a..0000000
--- a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/meta/no_deprecated_global_dev.cmx
+++ /dev/null
@@ -1,8 +0,0 @@
-{
- "include": [
- "syslog/client.shard.cmx"
- ],
- "program": {
- "binary": "bin/no_deprecated_global_dev"
- }
-}
diff --git a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/no_deprecated_global_dev.cc b/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/no_deprecated_global_dev.cc
deleted file mode 100644
index ba245ca..0000000
--- a/src/sys/appmgr/integration_tests/sandbox/features/deprecated-global-dev/no_deprecated_global_dev.cc
+++ /dev/null
@@ -1,7 +0,0 @@
-// Copyright 2021 The Fuchsia Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/sys/appmgr/integration_tests/sandbox/namespace_test.h"
-
-TEST_F(NamespaceTest, NoDeprecatedGlobalDev) { ExpectDoesNotExist("/dev"); }
diff --git a/src/sys/appmgr/namespace_builder.cc b/src/sys/appmgr/namespace_builder.cc
index 0a239bb..efe997e 100644
--- a/src/sys/appmgr/namespace_builder.cc
+++ b/src/sys/appmgr/namespace_builder.cc
@@ -29,7 +29,6 @@
constexpr char kBlockedDataName[] = "data";
constexpr char kBuildInfoAllowList[] = "allowlist/build_info.txt";
-constexpr char kDeprecatedGlobalDevAllowList[] = "allowlist/deprecated_global_dev.txt";
NamespaceBuilder::~NamespaceBuilder() = default;
@@ -210,17 +209,6 @@
FX_LOGS(WARNING) << "Component " << ns_id
<< " is not allowlisted to use build-info. See fxbug.dev/50308.";
}
- } else if (feature == "deprecated-global-dev") {
- // TODO(fxbug.dev/83185): delete this.
- AllowList deprecated_global_dev_allowlist(appmgr_config_dir_, kDeprecatedGlobalDevAllowList);
- FuchsiaPkgUrl pkg_url;
- if (pkg_url.Parse(ns_id) && deprecated_global_dev_allowlist.IsAllowed(pkg_url)) {
- PushDirectoryFromPath("/dev");
- } else {
- FX_LOGS(WARNING)
- << "Component " << ns_id
- << " is not allowlisted to use deprecated-global-dev. See fxbug.dev/83185.";
- }
}
}
diff --git a/src/sys/lib/cm_json/cmx_schema.json b/src/sys/lib/cm_json/cmx_schema.json
index 4141b0a..9b1d73d 100644
--- a/src/sys/lib/cm_json/cmx_schema.json
+++ b/src/sys/lib/cm_json/cmx_schema.json
@@ -118,7 +118,6 @@
"build-info",
"config-data",
"deprecated-global-data",
- "deprecated-global-dev",
"deprecated-global-hub",
"deprecated-global-tmp",
"deprecated-misc-storage",
