commit 130a43a76d3401622c20bd1c41a9301f0792cb85
author Tamir Duberstein <tamird@google.com> Tue Apr 13 15:00:46 2021 +0000
committer CQ Bot <commit-bot@chromium.org> Tue Apr 13 15:00:46 2021 +0000
tree 988647d4c46e8105a8fc0569ab900cf309c56925
parent 34728f9ad6121b9557d1ca4d75b01424f93ca613

[mdns] Appease clang-tidy

- Remove redundant `static` in anonymous namespace
- Use range-based for loops

Change-Id: I4dfdf5ffbeb517833a3fcfbfc007641353331848
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/514803
Fuchsia-Auto-Submit: Tamir Duberstein <tamird@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>

src/connectivity/network/mdns/service/dns_reading.cc

diff --git a/src/connectivity/network/mdns/service/dns_reading.cc b/src/connectivity/network/mdns/service/dns_reading.cc
index 16f73be..764112a 100644
--- a/src/connectivity/network/mdns/service/dns_reading.cc
+++ b/src/connectivity/network/mdns/service/dns_reading.cc
@@ -12,11 +12,11 @@
 
 // Max record counts. These values are selected to prevent an attack that would
 // cause is to allocate memory for large numbers of records.
-static constexpr size_t kMaxQuestions = 1024;
-static constexpr size_t kMaxAnswers = 1024;
-static constexpr size_t kMaxAuthorities = 1024;
-static constexpr size_t kMaxAdditionals = 1024;
-static constexpr size_t kMaxDnsNameSize = 255;
+constexpr size_t kMaxQuestions = 1024;
+constexpr size_t kMaxAnswers = 1024;
+constexpr size_t kMaxAuthorities = 1024;
+constexpr size_t kMaxAdditionals = 1024;
+constexpr size_t kMaxDnsNameSize = 255;
 
 void ReadNameLabels(PacketReader& reader, std::vector<char>& chars) {
   size_t start_position_of_current_run = reader.bytes_consumed();
@@ -343,29 +343,29 @@
 
   if (reader.healthy()) {
     value.questions_.resize(value.header_.question_count_);
-    for (uint16_t i = 0; i < value.questions_.size(); ++i) {
-      reader >> value.questions_[i];
+    for (auto& question : value.questions_) {
+      reader >> question;
     }
   }
 
   if (reader.healthy()) {
     value.answers_.resize(value.header_.answer_count_);
-    for (uint16_t i = 0; i < value.answers_.size(); ++i) {
-      reader >> value.answers_[i];
+    for (auto& answer : value.answers_) {
+      reader >> answer;
     }
   }
 
   if (reader.healthy()) {
     value.authorities_.resize(value.header_.authority_count_);
-    for (uint16_t i = 0; i < value.authorities_.size(); ++i) {
-      reader >> value.authorities_[i];
+    for (auto& authority : value.authorities_) {
+      reader >> authority;
     }
   }
 
   if (reader.healthy()) {
     value.additionals_.resize(value.header_.additional_count_);
-    for (uint16_t i = 0; i < value.additionals_.size(); ++i) {
-      reader >> value.additionals_[i];
+    for (auto& additional : value.additionals_) {
+      reader >> additional;
     }
   }