[cleo][sensors] Add tests for BMA253 accel sensor
ZX-2788
Test: runtests -t bma253-test
Change-Id: I3387e885bdd77bd0185a2e16b01b72566b47d7cb
diff --git a/system/dev/input/bma253/bma253-test.cpp b/system/dev/input/bma253/bma253-test.cpp
new file mode 100644
index 0000000..7b9c9ee
--- /dev/null
+++ b/system/dev/input/bma253/bma253-test.cpp
@@ -0,0 +1,194 @@
+// Copyright 2019 The Fuchsia Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "bma253.h"
+
+#include <fbl/vector.h>
+#include <lib/mock-hidbus-ifc/mock-hidbus-ifc.h>
+#include <lib/mock-i2c/mock-i2c.h>
+#include <lib/sync/completion.h>
+#include <unittest/unittest.h>
+
+namespace accel {
+
+bool TestInit() {
+ BEGIN_TEST;
+
+ zx::port port;
+ ASSERT_EQ(ZX_OK, zx::port::create(0, &port));
+
+ mock_i2c::MockI2c mock_i2c;
+ mock_i2c
+ .ExpectWriteStop({0x0f, 0b0101})
+ .ExpectWriteStop({0x10, 0b01011});
+
+ ddk::I2cChannel i2c(mock_i2c.GetProto());
+ Bma253 device(nullptr, std::move(i2c), std::move(port));
+
+ EXPECT_EQ(ZX_OK, device.Init());
+ EXPECT_TRUE(mock_i2c.VerifyAndClear());
+
+ END_TEST;
+}
+
+bool TestInputReport() {
+ BEGIN_TEST;
+
+ BEGIN_TEST;
+
+ zx::port port;
+ ASSERT_EQ(ZX_OK, zx::port::create(0, &port));
+
+ mock_i2c::MockI2c mock_i2c;
+ mock_i2c
+ .ExpectWrite({0x02})
+ .ExpectReadStop({0xb1, 0x65, 0x31, 0xf7, 0x01, 0x39})
+ .ExpectWrite({0x08})
+ .ExpectReadStop({0x3e});
+
+ ddk::I2cChannel i2c(mock_i2c.GetProto());
+ Bma253 device(nullptr, std::move(i2c), std::move(port));
+
+ bma253_input_rpt_t report;
+ size_t actual;
+ EXPECT_EQ(ZX_OK, device.HidbusGetReport(HID_REPORT_TYPE_INPUT, BMA253_RPT_ID_INPUT, &report,
+ sizeof(report), &actual));
+ EXPECT_EQ(sizeof(report), actual);
+
+ EXPECT_EQ(BMA253_RPT_ID_INPUT, report.rpt_id);
+ EXPECT_EQ(0x65b, report.acceleration_x);
+ EXPECT_EQ(0xf73, report.acceleration_y);
+ EXPECT_EQ(0x390, report.acceleration_z);
+ EXPECT_EQ(0x3e, report.temperature);
+
+ EXPECT_TRUE(mock_i2c.VerifyAndClear());
+
+ END_TEST;
+}
+
+bool TestFeatureReport() {
+ BEGIN_TEST;
+
+ zx::port port;
+ ASSERT_EQ(ZX_OK, zx::port::create(0, &port));
+
+ mock_i2c::MockI2c mock_i2c;
+ ddk::I2cChannel i2c(mock_i2c.GetProto());
+ Bma253 device(nullptr, std::move(i2c), std::move(port));
+
+ bma253_feature_rpt_t report;
+ size_t actual;
+
+ EXPECT_EQ(ZX_OK, device.HidbusGetReport(HID_REPORT_TYPE_FEATURE, BMA253_RPT_ID_FEATURE, &report,
+ sizeof(report), &actual));
+ EXPECT_EQ(sizeof(report), actual);
+
+ EXPECT_EQ(BMA253_RPT_ID_FEATURE, report.rpt_id);
+ EXPECT_EQ(0, report.interval_ms);
+
+ report.interval_ms = 1000;
+
+ EXPECT_EQ(ZX_OK, device.HidbusSetReport(HID_REPORT_TYPE_FEATURE, BMA253_RPT_ID_FEATURE, &report,
+ sizeof(report)));
+
+ EXPECT_EQ(ZX_OK, device.HidbusGetReport(HID_REPORT_TYPE_FEATURE, BMA253_RPT_ID_FEATURE, &report,
+ sizeof(report), &actual));
+ EXPECT_EQ(sizeof(report), actual);
+
+ EXPECT_EQ(BMA253_RPT_ID_FEATURE, report.rpt_id);
+ EXPECT_EQ(1000, report.interval_ms);
+
+ END_TEST;
+}
+
+bool TestPolling() {
+ BEGIN_TEST;
+
+ zx::port port;
+ ASSERT_EQ(ZX_OK, zx::port::create(0, &port));
+
+ mock_i2c::MockI2c mock_i2c;
+ mock_i2c
+ .ExpectWrite({0x02})
+ .ExpectReadStop({0xb1, 0x65, 0x31, 0xf7, 0x01, 0x39})
+ .ExpectWrite({0x08})
+ .ExpectReadStop({0x3e})
+ .ExpectWrite({0x02})
+ .ExpectReadStop({0x91, 0x51, 0xc1, 0x73, 0xa1, 0xd6})
+ .ExpectWrite({0x08})
+ .ExpectReadStop({0xb6})
+ .ExpectWrite({0x02})
+ .ExpectReadStop({0x61, 0x24, 0x61, 0xf2, 0xe1, 0x93})
+ .ExpectWrite({0x08})
+ .ExpectReadStop({0x72});
+
+ ddk::I2cChannel i2c(mock_i2c.GetProto());
+ Bma253 device(nullptr, std::move(i2c), std::move(port));
+
+ bma253_feature_rpt_t report = {BMA253_RPT_ID_FEATURE, 1000};
+ EXPECT_EQ(ZX_OK, device.HidbusSetReport(HID_REPORT_TYPE_FEATURE, BMA253_RPT_ID_FEATURE, &report,
+ sizeof(report)));
+
+ mock_hidbus_ifc::MockHidbusIfc<bma253_input_rpt_t> mock_ifc;
+ EXPECT_EQ(ZX_OK, device.HidbusStart(mock_ifc.proto()));
+
+ EXPECT_EQ(ZX_OK, mock_ifc.WaitForReports(3));
+ device.HidbusStop();
+
+ EXPECT_TRUE(mock_i2c.VerifyAndClear());
+
+ ASSERT_EQ(3, mock_ifc.reports().size());
+
+ EXPECT_EQ(BMA253_RPT_ID_INPUT, mock_ifc.reports()[0].rpt_id);
+ EXPECT_EQ(0x65b, mock_ifc.reports()[0].acceleration_x);
+ EXPECT_EQ(0xf73, mock_ifc.reports()[0].acceleration_y);
+ EXPECT_EQ(0x390, mock_ifc.reports()[0].acceleration_z);
+ EXPECT_EQ(0x3e, mock_ifc.reports()[0].temperature);
+
+ EXPECT_EQ(BMA253_RPT_ID_INPUT, mock_ifc.reports()[1].rpt_id);
+ EXPECT_EQ(0x519, mock_ifc.reports()[1].acceleration_x);
+ EXPECT_EQ(0x73c, mock_ifc.reports()[1].acceleration_y);
+ EXPECT_EQ(0xd6a, mock_ifc.reports()[1].acceleration_z);
+ EXPECT_EQ(0xb6, mock_ifc.reports()[1].temperature);
+
+ EXPECT_EQ(BMA253_RPT_ID_INPUT, mock_ifc.reports()[2].rpt_id);
+ EXPECT_EQ(0x246, mock_ifc.reports()[2].acceleration_x);
+ EXPECT_EQ(0xf26, mock_ifc.reports()[2].acceleration_y);
+ EXPECT_EQ(0x93e, mock_ifc.reports()[2].acceleration_z);
+ EXPECT_EQ(0x72, mock_ifc.reports()[2].temperature);
+
+ END_TEST;
+}
+
+bool TestNotImplemented() {
+ BEGIN_TEST;
+
+ zx::port port;
+ ASSERT_EQ(ZX_OK, zx::port::create(0, &port));
+
+ mock_i2c::MockI2c mock_i2c;
+ ddk::I2cChannel i2c(mock_i2c.GetProto());
+ Bma253 device(nullptr, std::move(i2c), std::move(port));
+
+ EXPECT_EQ(ZX_ERR_NOT_SUPPORTED, device.HidbusGetIdle(0, nullptr));
+ EXPECT_EQ(ZX_ERR_NOT_SUPPORTED, device.HidbusSetIdle(0, 0));
+ EXPECT_EQ(ZX_ERR_NOT_SUPPORTED, device.HidbusGetProtocol(nullptr));
+ EXPECT_EQ(ZX_ERR_NOT_SUPPORTED, device.HidbusSetProtocol({}));
+
+ END_TEST;
+}
+
+} // namespace accel
+
+int main(int argc, char** argv) {
+ return unittest_run_all_tests(argc, argv) ? 0 : 1;
+}
+
+BEGIN_TEST_CASE(Bma253Tests)
+RUN_TEST_SMALL(accel::TestInit)
+RUN_TEST_SMALL(accel::TestInputReport)
+RUN_TEST_SMALL(accel::TestFeatureReport)
+RUN_TEST_SMALL(accel::TestPolling)
+RUN_TEST_SMALL(accel::TestNotImplemented)
+END_TEST_CASE(Bma253Tests)
diff --git a/system/dev/input/bma253/bma253.h b/system/dev/input/bma253/bma253.h
index 414670e..b2e3dcf 100644
--- a/system/dev/input/bma253/bma253.h
+++ b/system/dev/input/bma253/bma253.h
@@ -40,7 +40,7 @@
zx_status_t HidbusGetProtocol(hid_protocol_t* out_protocol);
zx_status_t HidbusSetProtocol(hid_protocol_t protocol);
-private:
+ // Visible for testing.
Bma253(zx_device_t* parent, ddk::I2cChannel i2c, zx::port port)
: DeviceType(parent), i2c_(i2c) {
simple_hid_ = simplehid::SimpleHid<bma253_input_rpt_t>(
@@ -51,7 +51,10 @@
);
}
+ // Visible for testing.
zx_status_t Init();
+
+private:
zx_status_t GetInputReport(bma253_input_rpt_t* report);
fbl::Mutex i2c_lock_;
diff --git a/system/dev/input/bma253/rules.mk b/system/dev/input/bma253/rules.mk
index 2cc94b3..db692f5 100644
--- a/system/dev/input/bma253/rules.mk
+++ b/system/dev/input/bma253/rules.mk
@@ -35,3 +35,41 @@
system/banjo/ddk-protocol-platform-device \
include make/module.mk
+
+MODULE := $(LOCAL_DIR).test
+
+MODULE_NAME := bma253-test
+
+MODULE_TYPE := usertest
+
+MODULE_SRCS += \
+ $(LOCAL_DIR)/bma253.cpp \
+ $(LOCAL_DIR)/bma253-test.cpp \
+
+MODULE_STATIC_LIBS := \
+ system/dev/lib/mock-hidbus-ifc \
+ system/dev/lib/mock-i2c \
+ system/ulib/ddk \
+ system/ulib/ddktl \
+ system/ulib/fbl \
+ system/ulib/fit \
+ system/ulib/hid \
+ system/ulib/simplehid \
+ system/ulib/sync \
+ system/ulib/zx \
+ system/ulib/zxcpp \
+
+MODULE_LIBS := \
+ system/ulib/driver \
+ system/ulib/c \
+ system/ulib/unittest \
+ system/ulib/zircon \
+
+MODULE_BANJO_LIBS := \
+ system/banjo/ddk-protocol-clk \
+ system/banjo/ddk-protocol-gpio \
+ system/banjo/ddk-protocol-hidbus \
+ system/banjo/ddk-protocol-i2c \
+ system/banjo/ddk-protocol-platform-device \
+
+include make/module.mk
