commit 2b3253da69b54f464d3d0321f039dcc359298bed
author Brijen Raval <braval@google.com> Sat Sep 22 23:17:35 2018 -0700
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Sep 24 15:47:40 2018 +0000
tree 0066e6ab63e285b79db77623fade72fc1f3308d2
parent 06c69c7568f402d8bd21685ae1cdaeee1ff7ca1e

[interrupts] Disable manual triggering of interrupts

ZX-2177 #done

Test: Boot up on vim2 & last use of this was recently fixed
Change-Id: I318aaf39e06c51d9de647fcec0fe5f21fe664d2a

kernel/object/interrupt_dispatcher.cpp

diff --git a/kernel/object/interrupt_dispatcher.cpp b/kernel/object/interrupt_dispatcher.cpp
index 33876ca..bb6e680 100644
--- a/kernel/object/interrupt_dispatcher.cpp
+++ b/kernel/object/interrupt_dispatcher.cpp
@@ -72,14 +72,8 @@
 
 zx_status_t InterruptDispatcher::Trigger(zx_time_t timestamp) {
 
-    // TODO(braval): Currently @johngro's driver uses zx_interrupt_trigger
-    // to wake up a thread waiting on a physical interrupt
-    // Once his driver adopts the interrupt with ports bounded, we can enforce
-    // the below condition again
-    /*
-    if (!(interrupt_.flags & INTERRUPT_VIRTUAL))
+    if (!(flags_ & INTERRUPT_VIRTUAL))
         return ZX_ERR_BAD_STATE;
-    */
 
     // Using AutoReschedDisable is necessary for correctness to prevent
     // context-switching to the woken thread while holding spinlock_.