| commit | 00242ce4a3fbef7306812606af5f3834ba86614c | [log] [tgz] |
|---|---|---|
| author | Miguel Flores Ruiz de Eguino <miguelfrde@google.com> | Mon Oct 03 09:35:51 2022 +0000 |
| committer | Miguel Flores <miguelfrde@google.com> | Mon Oct 03 09:35:51 2022 +0000 |
| tree | 3fdfb69a6424a3459d40e3544a66bd51f3745016 | |
| parent | 995a2192fdc44dab80a47fa2acd2eeab238d6c68 [diff] |
[ffx] Fix bug that was leaving orphaned `ffx log` processes When working in tree, `.jiri_root/bin/ffx` launches a `fx ffx` subprocess. We were leaving orphaned process as `kill()` wasn't doing what we expected. This change fixes that. Before (note how each time the logs view is closed and reopened a new process appears): https://screencast.googleplex.com/cast/NjIwMzkwMTcyMTE4MjIwOHw1MGQ4Mzg1NC0xMA After (only a single process when the view is active, zero processes when it's closed): https://screencast.googleplex.com/cast/NTYzNzk0MjUyMjQxMzA1Nnw0N2E0OTI5ZS02MA An interesting side effect of this worth exploring more is that I don't have to run `ffx doctor --restart-daemon` as often anymore. Change-Id: I78fdd7866d4d115378a93570114cd35b42d2b42e Reviewed-on: https://fuchsia-review.googlesource.com/c/vscode-plugins/+/732203 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Solly Ross <sollyross@google.com>
This VS Code extension implements the commonly needed functionality for Fuchsia development.
This is a Work In Progress Currently supporting:
The FFX tool path can be set under Settings > Extensions > Fuchsia SDK. If this path is not set, the extension will automatically search for it at:
Use of the Fuchsia core developer tools is subject to the Google Terms of Service. The Google Privacy Policy describes how data is handled in your use of this service.