commit ffbdd238608f18efe5662afc2692e02dd381595f
author Jody Sankey <jsankey@google.com> Fri Mar 22 17:58:35 2019 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Mar 22 17:58:35 2019 +0000
tree 3b1fd5c8c94ceaf207fdcb9497e0d2db48947136
parent 865baee6c0aa6dffce8faddcd9baf17025c05638

[auth] Fix auth_provider error code.

I believe this is the cause of the spurious internal error we've been
finding in our logs. If the view gets closed on us that not our fault
and so auth provider shouldn't be declaring an internal error (which
gets converted by token manager into another internal error).

Change-Id: I746a8e5550bae100a6fee4121fae29b3152ac9f8

auth_providers/google/google_auth_provider_impl.cc

diff --git a/auth_providers/google/google_auth_provider_impl.cc b/auth_providers/google/google_auth_provider_impl.cc
index 3d233a6..5bed4ed 100644
--- a/auth_providers/google/google_auth_provider_impl.cc
+++ b/auth_providers/google/google_auth_provider_impl.cc
@@ -165,7 +165,7 @@
   auth_ui_context_.set_error_handler([this](zx_status_t status) {
     FX_LOG(INFO, NULL, "Overlay cancelled by the caller");
     ReleaseResources();
-    get_persistent_credential_callback_(AuthProviderStatus::INTERNAL_ERROR,
+    get_persistent_credential_callback_(AuthProviderStatus::UNKNOWN_ERROR,
                                         nullptr, nullptr);
     return;
   });