[mediaplayer] modernize BUILD.gn for mediaplayer_skia example
This CL updates the BUILD.gn and related files for the example app
mediaplayer_skia. In particular, deprecated_system_image is no longer
used, and the package target has no package_name parameter. A .cmx
file has been added.
TEST: no behavior change, tested to ensure the app runs:
fx shell set_root_view \
fuchsia-pkg://fuchsia.com/mediaplayer_skia#meta/mediaplayer_skia.cmx \
<media file>
Change-Id: I90ee979c67574873a2fb27d9c8c3694ecd4c63e8
diff --git a/examples/mediaplayer/mediaplayer_skia/BUILD.gn b/examples/mediaplayer/mediaplayer_skia/BUILD.gn
index 1e0211f..2af506e 100644
--- a/examples/mediaplayer/mediaplayer_skia/BUILD.gn
+++ b/examples/mediaplayer/mediaplayer_skia/BUILD.gn
@@ -4,7 +4,9 @@
import("//build/package.gni")
-executable("mediaplayer_skia") {
+executable("mediaplayer_skia_bin") {
+ output_name = "mediaplayer_skia"
+
sources = [
"main.cc",
"mediaplayer_params.cc",
@@ -28,17 +30,21 @@
]
}
-package("package") {
- deprecated_system_image = true
- package_name = "mediaplayer_skia"
-
- deps = [
- ":mediaplayer_skia",
- ]
-
+package("mediaplayer_skia") {
binaries = [
{
name = "mediaplayer_skia"
},
]
+
+ deps = [
+ ":mediaplayer_skia_bin",
+ ]
+
+ meta = [
+ {
+ path = rebase_path("meta/mediaplayer_skia.cmx")
+ dest = "mediaplayer_skia.cmx"
+ },
+ ]
}
diff --git a/examples/mediaplayer/mediaplayer_skia/meta/mediaplayer_skia.cmx b/examples/mediaplayer/mediaplayer_skia/meta/mediaplayer_skia.cmx
new file mode 100644
index 0000000..4fbb8c6
--- /dev/null
+++ b/examples/mediaplayer/mediaplayer_skia/meta/mediaplayer_skia.cmx
@@ -0,0 +1,18 @@
+{
+ "program": {
+ "binary": "bin/mediaplayer_skia"
+ },
+ "sandbox": {
+ "features": [
+ "persistent-storage",
+ "system-temp"
+ ],
+ "services": [
+ "fuchsia.fonts.Provider",
+ "fuchsia.mediaplayer.Player",
+ "fuchsia.tracelink.Registry",
+ "fuchsia.ui.scenic.Scenic",
+ "fuchsia.ui.viewsv1.ViewManager"
+ ]
+ }
+}
diff --git a/packages/examples/misc b/packages/examples/misc
index 76bc685..89c9cc0 100644
--- a/packages/examples/misc
+++ b/packages/examples/misc
@@ -4,7 +4,7 @@
],
"packages": [
"//topaz/examples/mediaplayer/mediaplayer_flutter",
- "//topaz/examples/mediaplayer/mediaplayer_skia:package",
+ "//topaz/examples/mediaplayer/mediaplayer_skia",
"//topaz/examples/mine_digger",
"//topaz/examples/ledger/todo_list",
"//topaz/examples/ledger/todo_list_sledge",
