commit 905a3af6dc1b9a2a47dedbf5dc4bfc868891fdd2
author Chingjun Lau <chingjun@google.com> Mon Mar 25 21:39:28 2019 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Mar 25 21:39:28 2019 +0000
tree 214fb03687ce4a8d5238da96ddedc4687afd3d00
parent bfbf2bf4d962ac1a4bbdff0739564725ec414f83

[flutter,dart] Remove size limit on memfs in non-product flutter/dart runner

Change-Id: I6698f55fd54edda750700e2db26c80ded1a96b18

runtime/dart/utils/tempfs.cc

diff --git a/runtime/dart/utils/tempfs.cc b/runtime/dart/utils/tempfs.cc
index c68fd4f..ef66901 100644
--- a/runtime/dart/utils/tempfs.cc
+++ b/runtime/dart/utils/tempfs.cc
@@ -18,12 +18,18 @@
 namespace {
 
 constexpr char kTmpPath[] = "/tmp";
-constexpr size_t kMaxTmpPages = 1024;
+[[maybe_unused]] constexpr size_t kMaxTmpPages = 1024;
 
 void DispatchTempMemFS() {
   async::Loop loop(&kAsyncLoopConfigAttachToThread);
+#if defined(DART_PRODUCT)
   zx_status_t status = memfs_install_at_with_page_limit(
       loop.dispatcher(), kMaxTmpPages, kTmpPath);
+#else
+  // Hot reload uses /tmp to hold the updated dills and assets so do not
+  // impose any size limitation in non product runners.
+  zx_status_t status = memfs_install_at(loop.dispatcher(), kTmpPath);
+#endif
   if (status != ZX_OK) {
     FXL_LOG(ERROR) << "Failed to install a /tmp memfs: "
                    << zx_status_get_string(status);