commit 66710bd0d032f114ced9ad815971a7df2e763d33
author Miguel Flores Ruiz de Eguino <miguelfrde@google.com> Thu Sep 12 16:33:12 2019 -0700
committer Miguel Flores Ruiz de Eguino <miguelfrde@google.com> Fri Sep 13 12:51:27 2019 -0700
tree 67e1f5c96b3da3b6cd10dec59263daed123963d2
parent b1d888b6d3839f35ba9ce43c2f81d85b5eddb7d8

[modular-api-audit] Get rid of scheduleTask and deleteTask

Needs: https://fuchsia-review.googlesource.com/c/fuchsia/+/319510</pre>

TESTED=build

Change-Id: Ib25d6ae16564c9951656713d200ff440a4d7d7e9

public/dart/fuchsia_modular/lib/src/agent/agent.dart

diff --git a/public/dart/fuchsia_modular/lib/src/agent/agent.dart b/public/dart/fuchsia_modular/lib/src/agent/agent.dart
index 9fd57b8..e9c7f0c 100644
--- a/public/dart/fuchsia_modular/lib/src/agent/agent.dart
+++ b/public/dart/fuchsia_modular/lib/src/agent/agent.dart
@@ -6,7 +6,6 @@
 
 import 'package:fidl/fidl.dart';
 import 'package:fidl_fuchsia_auth/fidl_async.dart' as fidl_auth;
-import 'package:fidl_fuchsia_modular/fidl_async.dart' as fidl_agent;
 
 import 'agent_task_handler.dart';
 import 'internal/_agent_impl.dart';
@@ -103,12 +102,4 @@
   /// class MyAgentTaskHandler extends AgentTaskHandler { ... }
   /// ```
   void registerTaskHandler(AgentTaskHandler taskHandler);
-
-  /// Schedules a task described in [taskInfo]. [registerTaskHandler] must be
-  /// called before scheduling any tasks. When this task is scheduled to
-  /// run, [AgentTaskHandler.runTask()] is called.
-  void scheduleTask(fidl_agent.TaskInfo taskInfo);
-
-  /// No new runs of this [taskId] will be scheduled.
-  void deleteTask(String taskId);
 }

public/dart/fuchsia_modular/lib/src/agent/internal/_agent_impl.dart

diff --git a/public/dart/fuchsia_modular/lib/src/agent/internal/_agent_impl.dart b/public/dart/fuchsia_modular/lib/src/agent/internal/_agent_impl.dart
index 3b1ee69..48f1bd5 100644
--- a/public/dart/fuchsia_modular/lib/src/agent/internal/_agent_impl.dart
+++ b/public/dart/fuchsia_modular/lib/src/agent/internal/_agent_impl.dart
@@ -159,27 +159,6 @@
     _outstandingTasks.add(taskId);
   }
 
-  @override
-  void scheduleTask(fidl.TaskInfo taskInfo) {
-    if (taskInfo == null) {
-      throw ArgumentError.notNull('taskInfo');
-    }
-    if (_taskHandler == null) {
-      throw Exception(
-          'Attempting to schedule a task without registering a task handler to '
-          'receive it');
-    }
-    _getContext().scheduleTask(taskInfo);
-  }
-
-  @override
-  void deleteTask(String taskId) {
-    if (taskId == null) {
-      throw ArgumentError.notNull('taskId');
-    }
-    _getContext().deleteTask(taskId);
-  }
-
   /// Exposes this [fidl.Agent] instance to the
   /// [StartupContext#addPublicService]. In other words, advertises this as an
   /// [fidl.Agent] to the rest of the system via the [StartupContext].

public/dart/fuchsia_modular/test/agent/internal/agent_impl_test.dart

diff --git a/public/dart/fuchsia_modular/test/agent/internal/agent_impl_test.dart b/public/dart/fuchsia_modular/test/agent/internal/agent_impl_test.dart
index 8c4dcbc..a57529f 100644
--- a/public/dart/fuchsia_modular/test/agent/internal/agent_impl_test.dart
+++ b/public/dart/fuchsia_modular/test/agent/internal/agent_impl_test.dart
@@ -180,45 +180,6 @@
   });
 
   group('Agent Tasks:', () {
-    final fakeTask = fidl.TaskInfo(
-        taskId: '1',
-        triggerCondition: fidl.TriggerCondition.withMessageOnQueue('dunno'),
-        persistent: false);
-
-    test('verify calling scheduleTask with null task throws', () {
-      expect(() {
-        AgentImpl().scheduleTask(null);
-      }, throwsArgumentError);
-    });
-
-    test('verify calling scheduleTask without handler throws', () {
-      expect(() {
-        AgentImpl().scheduleTask(fakeTask);
-      }, throwsException);
-    });
-
-    test('verify scheduleTask should call context.scheduleTask', () {
-      final mockAgentContext = MockAgentContext();
-
-      AgentImpl(agentContext: mockAgentContext)
-        ..registerTaskHandler(MyAgentTaskHandler())
-        ..scheduleTask(fakeTask);
-      verify(mockAgentContext.scheduleTask(fakeTask));
-    });
-
-    test('verify calling deleteTask with null task throws', () {
-      expect(() {
-        AgentImpl().deleteTask(null);
-      }, throwsArgumentError);
-    });
-
-    test('verify deleteTask should call context.deleteTask', () {
-      final mockAgentContext = MockAgentContext();
-
-      AgentImpl(agentContext: mockAgentContext).deleteTask('1');
-      verify(mockAgentContext.deleteTask('1'));
-    });
-
     test('verify calling registerTaskHandler with null task throws', () {
       expect(() {
         AgentImpl().registerTaskHandler(null);