commit 3a47054cffdc77ffed03a6e3fa54fd0f99e11b38
author Adam Barth <abarth@chromium.org> Mon Jun 18 20:19:04 2018 -0700
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Jun 19 03:54:46 2018 +0000
tree eb36b66246c48a960909446e8ab0ebd9807a373e
parent 27e537bc315b12f3986848853d4b4d9b1d09e7e6

[dart] zx_channel_write always consumes handles

Previously, zx_channel_write would consume handles only on success. Now,
the function always consumes them.

Test: No behavior change
Change-Id: I8607505334d0522898cb43ad371002e8d1a21f00

public/dart-pkg/zircon/sdk_ext/system.cc

diff --git a/public/dart-pkg/zircon/sdk_ext/system.cc b/public/dart-pkg/zircon/sdk_ext/system.cc
index 243f9a5..b19ca12 100644
--- a/public/dart-pkg/zircon/sdk_ext/system.cc
+++ b/public/dart-pkg/zircon/sdk_ext/system.cc
@@ -202,11 +202,9 @@
   zx_status_t status = zx_channel_write(channel->handle(), 0, data.data(),
                                         data.length_in_bytes(),
                                         zx_handles.data(), zx_handles.size());
-  if (status == ZX_OK) {
-    // Handles were transferred.
-    for (Handle* handle : handles) {
-      handle->ReleaseHandle();
-    }
+  // Handles are always consumed.
+  for (Handle* handle : handles) {
+    handle->ReleaseHandle();
   }
 
   return status;