commit 26a2c9fcc7dd6b2e3d67d16dd0225e8d59836167
author Ryan Macnak <rmacnak@google.com> Mon Apr 01 16:39:52 2019 +0000
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Apr 01 16:39:52 2019 +0000
tree 3ae85e1aa767b6c2dab2acd31e1bd1916b4a1b87
parent 0ddbc71b9965c93d02b8ac7a671e3ad634a728f5

[dart:zircon] Work around tonic bug with unbalanced typed data acquire and release.

Fix missing return in invalid vmo writes.

Change-Id: I5849bcafe935f3db289e85a625bebf11f3c86291

public/dart-pkg/zircon/sdk_ext/system.cc

diff --git a/public/dart-pkg/zircon/sdk_ext/system.cc b/public/dart-pkg/zircon/sdk_ext/system.cc
index efa0297..961b3e7 100644
--- a/public/dart-pkg/zircon/sdk_ext/system.cc
+++ b/public/dart-pkg/zircon/sdk_ext/system.cc
@@ -218,6 +218,7 @@
                                  const tonic::DartByteData& data,
                                  std::vector<Handle*> handles) {
   if (!channel || !channel->is_valid()) {
+    data.Release();
     return ZX_ERR_BAD_HANDLE;
   }
 
@@ -234,6 +235,7 @@
     handle->ReleaseHandle();
   }
 
+  data.Release();
   return status;
 }
 
@@ -387,7 +389,7 @@
                              const tonic::DartByteData& data) {
   if (!vmo || !vmo->is_valid()) {
     data.Release();
-    ZX_ERR_BAD_HANDLE;
+    return ZX_ERR_BAD_HANDLE;
   }
 
   zx_status_t status =