[dump_breakpad_symbols] Have dump_breakpad_symbols produce an archive(2)
Added some logic to enable soft trasition
IN-851 #comment
Change-Id: I7b8205962f545b73607a73f4491302cf9f8e4b1a
diff --git a/cmd/dump_breakpad_symbols/main.go b/cmd/dump_breakpad_symbols/main.go
index 65d3a09..09fe0e6 100755
--- a/cmd/dump_breakpad_symbols/main.go
+++ b/cmd/dump_breakpad_symbols/main.go
@@ -108,13 +108,6 @@
}
defer summaryFile.Close()
- // Create and open tarball.
- tarFile, err := os.Create(tarFilepath)
- if err != nil {
- log.Fatalf("could not create file %s: %v", tarFilepath, err)
- }
- defer tarFile.Close()
-
// Callback to run breakpad `dump_syms` command.
execDumpSyms := func(args []string) ([]byte, error) {
return exec.Command(dumpSymsPath, args...).Output()
@@ -153,11 +146,21 @@
os.Exit(1)
}
- // Collect Breakpad symbol files generated by the build to a tarball.
- if err := writeTarball(tarFile, summary, outdir); err != nil {
- fmt.Fprintf(os.Stderr, "failed to generate tarball %s: %v", tarFilepath, err)
- os.Exit(1)
+ if tarFilepath != "" {
+ // Create and open tarball.
+ tarFile, err := os.Create(tarFilepath)
+ if err != nil {
+ log.Fatalf("could not create file %s: %v", tarFilepath, err)
+ }
+ defer tarFile.Close()
+
+ // Collect Breakpad symbol files generated by the build to a tarball.
+ if err := writeTarball(tarFile, summary, outdir); err != nil {
+ fmt.Fprintf(os.Stderr, "failed to generate tarball %s: %v", tarFilepath, err)
+ os.Exit(1)
+ }
}
+
}
// processIdsFiles dumps symbol data for each executable in a set of ids files.
