commit e620e0b4872e810b8f9d28a4220d5db698ddf1a8
author Adam Barth <abarth@chromium.org> Fri Jul 15 16:13:00 2016 -0700
committer Adam Barth <abarth@chromium.org> Fri Jul 15 16:13:00 2016 -0700
tree 081f8affb60da67e26a01cb1c4b6b5023a800748
parent 469276b50821ea9490c83f9e689b8c1de6d7c12a

Disable unnecessary warnings

After this patch, zlib builds without generating warnings.

Change-Id: I2098ede981bf9a774addd53f71cd7671f8baee62

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index ab32bae..614324f 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -24,8 +24,15 @@
 }
 
 config("zlib_warnings") {
+  visibility = [ ":*" ]
+
+  cflags = [
+    "-Wno-implicit-function-declaration",
+    "-Wno-shift-negative-value",
+  ]
+
   if (is_clang && (current_cpu == "x86" || current_cpu == "x64")) {
-    cflags = [ "-Wno-incompatible-pointer-types" ]
+    cflags += [ "-Wno-incompatible-pointer-types" ]
   }
 }
 
@@ -72,9 +79,14 @@
 
 config("minizip_warnings") {
   visibility = [ ":*" ]
+
+  cflags = [
+    "-Wno-implicit-function-declaration",
+  ]
+
   if (is_clang) {
     # zlib uses `if ((a == b))` for some reason.
-    cflags = [ "-Wno-parentheses-equality" ]
+    cflags += [ "-Wno-parentheses-equality" ]
   }
 }