commit c27250f52fcfb936d4f0410d1199fe24c04b9713
author Nigel Tao <nigeltao@golang.org> Fri Oct 28 17:14:32 2022 +1100
committer Nigel Tao <nigeltao@golang.org> Fri Oct 28 17:17:09 2022 +1100
tree 76878a828f26ddf86187ad5ee9e1656d7bd0dfeb
parent 9445c8b9d09df3db16bcbb5bd33e4e14e819f701

Add -Wall to build-example.sh

build-example.sh

diff --git a/build-example.sh b/build-example.sh
index 6f512f7..c428d8a 100755
--- a/build-example.sh
+++ b/build-example.sh
@@ -28,8 +28,8 @@
 
 # The "-fdata-sections -ffunction-sections -Wl,--gc-sections" produces smaller
 # binaries. See commit 41fce8a8 "Strip examples of unused data and functions".
-CFLAGS=${CFLAGS:--O3 -fdata-sections -ffunction-sections -Wl,--gc-sections}
-CXXFLAGS=${CXXFLAGS:--O3 -fdata-sections -ffunction-sections -Wl,--gc-sections}
+CFLAGS=${CFLAGS:--O3 -fdata-sections -ffunction-sections -Wall -Wl,--gc-sections}
+CXXFLAGS=${CXXFLAGS:--O3 -fdata-sections -ffunction-sections -Wall -Wl,--gc-sections}
 
 mkdir -p gen/bin
 

example/cbor-to-json/cbor-to-json.cc

diff --git a/example/cbor-to-json/cbor-to-json.cc b/example/cbor-to-json/cbor-to-json.cc
index e23b8cd..02b540c 100644
--- a/example/cbor-to-json/cbor-to-json.cc
+++ b/example/cbor-to-json/cbor-to-json.cc
@@ -385,10 +385,8 @@
     if (n == 0) {
       break;
     }
-    ssize_t i = fwrite(g_dst.reader_pointer(), 1, n, stdout);
-    if (i >= 0) {
-      g_dst.meta.ri += i;
-    }
+    size_t i = fwrite(g_dst.reader_pointer(), 1, n, stdout);
+    g_dst.meta.ri += i;
     if (i < n) {
       return "main: error writing to stdout";
     }

example/json-to-cbor/json-to-cbor.cc

diff --git a/example/json-to-cbor/json-to-cbor.cc b/example/json-to-cbor/json-to-cbor.cc
index cb04504..30f806e 100644
--- a/example/json-to-cbor/json-to-cbor.cc
+++ b/example/json-to-cbor/json-to-cbor.cc
@@ -215,10 +215,8 @@
     if (n == 0) {
       break;
     }
-    ssize_t i = fwrite(g_dst.reader_pointer(), 1, n, stdout);
-    if (i >= 0) {
-      g_dst.meta.ri += i;
-    }
+    size_t i = fwrite(g_dst.reader_pointer(), 1, n, stdout);
+    g_dst.meta.ri += i;
     if (i < n) {
       return "main: error writing to stdout";
     }