commit 4007d6ff218110d55830c6dc2ca9822825afa0da
author C Shapiro <shapiroc@google.com> Mon Jun 19 16:53:58 2017 -0600
committer chrome-bot <chrome-bot@chromium.org> Tue Jun 20 13:38:10 2017 -0700
tree 27c289a36cec0131a909175c8512f704dfe9e273
parent c8d08ca31313d9ef5f85d0614f00eb3e4494aa71

Unified build support for multi-firmware signing

Unified builds break down multiple firmware images for each model;
however, the signing script didn't have support for this.

This updates the signing script to iterate over all models in a unified
build and sign each firmware image separately.

BUG=chromium:734485
TEST=sign_official_build.sh recovery for reef and reef-uni
BRANCH=none

Change-Id: Ia2b5b8bd36ac77aeb7944362186d1d5739e6ff3d
Reviewed-on: https://chromium-review.googlesource.com/540131
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

scripts/image_signing/sign_official_build.sh

diff --git a/scripts/image_signing/sign_official_build.sh b/scripts/image_signing/sign_official_build.sh
index 8333b01..5bdd5e4 100755
--- a/scripts/image_signing/sign_official_build.sh
+++ b/scripts/image_signing/sign_official_build.sh
@@ -562,19 +562,42 @@
   fi
   info "Found a valid firmware update shellball."
 
-  local image_file sign_args=() loem_sfx loem_output_dir
-  for image_file in "${shellball_dir}"/bios*.bin; do
-    if [[ -e "${KEY_DIR}/loem.ini" ]]; then
-      # Extract the extended details from "bios.bin" and use that in the
-      # subdir for the keyset.
-      loem_sfx=$(sed -r 's:.*/bios([^/]*)[.]bin$:\1:' <<<"${image_file}")
-      loem_output_dir="${shellball_dir}/keyset${loem_sfx}"
-      sign_args=( "${loem_output_dir}" )
-      mkdir -p "${loem_output_dir}"
-    fi
-    sign_firmware "${image_file}" "${KEY_DIR}" "${FIRMWARE_VERSION}" \
-      "${sign_args[@]}"
-  done
+  if [[ -d "${shellball_dir}/models" ]]; then
+    info "Signing firmware for all of the models in the unified build."
+    local model_dir
+    for model_dir in "${shellball_dir}"/models/*; do
+      local image_file sign_args=() loem_sfx loem_output_dir
+      for image_file in "${model_dir}"/bios*.bin; do
+        local model_name=$(sed -r 's:.*/models/(.*)/bios.*[.]bin$:\1:'\
+              <<<"${model_dir}")
+        if [[ -e "${KEY_DIR}/loem.ini" ]]; then
+          # Extract the extended details from "bios.bin" and use that, along
+          # with the model name, as the subdir for the keyset.
+          loem_sfx=$(sed -r "s:.*/models/${model_name}/bios([^/]*)[.]bin$:\1:"\
+                   <<<"${image_file}")
+          loem_output_dir="${shellball_dir}/keyset${loem_sfx}${model_name}"
+          sign_args=( "${loem_output_dir}" )
+          mkdir -p "${loem_output_dir}"
+        fi
+        sign_firmware "${image_file}" "${KEY_DIR}" "${FIRMWARE_VERSION}" \
+          "${sign_args[@]}"
+      done
+    done
+  else
+    local image_file sign_args=() loem_sfx loem_output_dir
+    for image_file in "${shellball_dir}"/bios*.bin; do
+      if [[ -e "${KEY_DIR}/loem.ini" ]]; then
+        # Extract the extended details from "bios.bin" and use that in the
+        # subdir for the keyset.
+        loem_sfx=$(sed -r 's:.*/bios([^/]*)[.]bin$:\1:' <<<"${image_file}")
+        loem_output_dir="${shellball_dir}/keyset${loem_sfx}"
+        sign_args=( "${loem_output_dir}" )
+        mkdir -p "${loem_output_dir}"
+      fi
+      sign_firmware "${image_file}" "${KEY_DIR}" "${FIRMWARE_VERSION}" \
+        "${sign_args[@]}"
+    done
+  fi
 
   local signer_notes="${shellball_dir}/VERSION.signer"
   echo "" >"$signer_notes"