Merge pull request #6815 from practicalswift/mark-crashers-as-fixed

Mark previously non-deterministic crashers as fixed
diff --git a/validation-test/compiler_crashers/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift b/validation-test/compiler_crashers/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
deleted file mode 100644
index 0ab5ba5..0000000
--- a/validation-test/compiler_crashers/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
+++ /dev/null
@@ -1,12 +0,0 @@
-// This source file is part of the Swift.org open source project
-// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
-// Licensed under Apache License v2.0 with Runtime Library Exception
-//
-// See https://swift.org/LICENSE.txt for license information
-// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
-
-// This test is disabled because it may fail to crash on the Ubuntu 14.04 host.
-// REQUIRES: deterministic-behavior
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-([-.f\n{}{$0(n&[]{
diff --git a/validation-test/compiler_crashers/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift b/validation-test/compiler_crashers/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift
deleted file mode 100644
index c827f3d..0000000
--- a/validation-test/compiler_crashers/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift
+++ /dev/null
@@ -1,12 +0,0 @@
-// This source file is part of the Swift.org open source project
-// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
-// Licensed under Apache License v2.0 with Runtime Library Exception
-//
-// See https://swift.org/LICENSE.txt for license information
-// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
-
-// This test is disabled because it fails to crash on the Ubuntu 14.04 host.
-// REQUIRES: deterministic-behavior
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-let E=_==#keyPath(n&_=b:{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
diff --git a/validation-test/compiler_crashers/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift b/validation-test/compiler_crashers_fixed/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
similarity index 79%
rename from validation-test/compiler_crashers/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
rename to validation-test/compiler_crashers_fixed/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
index 3eec44e..0fd3d45 100644
--- a/validation-test/compiler_crashers/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
+++ b/validation-test/compiler_crashers_fixed/28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 b<n([print{$0
diff --git a/validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift b/validation-test/compiler_crashers_fixed/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
similarity index 79%
rename from validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
rename to validation-test/compiler_crashers_fixed/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
index d1c111c..314c8e5 100644
--- a/validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
+++ b/validation-test/compiler_crashers_fixed/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 T>[print{$0{
diff --git a/validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift b/validation-test/compiler_crashers_fixed/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
similarity index 77%
copy from validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
copy to validation-test/compiler_crashers_fixed/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
index 03e7e53..538a668 100644
--- a/validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
+++ b/validation-test/compiler_crashers_fixed/28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
@@ -5,7 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-_&[i
--{$0
+// RUN: not %target-swift-frontend %s -emit-ir
+([-.f\n{}{$0(n&[]{
diff --git a/validation-test/compiler_crashers/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift b/validation-test/compiler_crashers_fixed/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
similarity index 79%
rename from validation-test/compiler_crashers/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
rename to validation-test/compiler_crashers_fixed/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
index e6bf4e7..921d39b 100644
--- a/validation-test/compiler_crashers/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
+++ b/validation-test/compiler_crashers_fixed/28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
@@ -5,7 +5,6 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 f\n&[print{$0
 e
diff --git a/validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift b/validation-test/compiler_crashers_fixed/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
similarity index 79%
rename from validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
rename to validation-test/compiler_crashers_fixed/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
index 03e7e53..c98ac07 100644
--- a/validation-test/compiler_crashers/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
+++ b/validation-test/compiler_crashers_fixed/28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
@@ -5,7 +5,6 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 _&[i
 -{$0
diff --git a/validation-test/compiler_crashers/28606-swift-typebase-getcanonicaltype.swift b/validation-test/compiler_crashers_fixed/28606-swift-typebase-getcanonicaltype.swift
similarity index 80%
rename from validation-test/compiler_crashers/28606-swift-typebase-getcanonicaltype.swift
rename to validation-test/compiler_crashers_fixed/28606-swift-typebase-getcanonicaltype.swift
index b0257bd..eb2bdfb 100644
--- a/validation-test/compiler_crashers/28606-swift-typebase-getcanonicaltype.swift
+++ b/validation-test/compiler_crashers_fixed/28606-swift-typebase-getcanonicaltype.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 print([.h.h=#keyPath(n&_=(){
diff --git a/validation-test/compiler_crashers/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift b/validation-test/compiler_crashers_fixed/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift
similarity index 80%
rename from validation-test/compiler_crashers/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift
rename to validation-test/compiler_crashers_fixed/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift
index 1cac17e..ccd8932 100644
--- a/validation-test/compiler_crashers/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift
+++ b/validation-test/compiler_crashers_fixed/28615-swift-constraints-constraintgraph-bindtypevariable-swift-typevariabletype-swift.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 print(_===#keyPath(t>c
diff --git a/validation-test/compiler_crashers/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift b/validation-test/compiler_crashers_fixed/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
similarity index 78%
rename from validation-test/compiler_crashers/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
rename to validation-test/compiler_crashers_fixed/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
index bea13fb..5e313ac 100644
--- a/validation-test/compiler_crashers/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
+++ b/validation-test/compiler_crashers_fixed/28621-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
@@ -5,7 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-// REQUIRES: asserts
+// RUN: not %target-swift-frontend %s -emit-ir
 [{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{}}}($0/(#keyPath(b{{{{{{
diff --git a/validation-test/compiler_crashers_fixed/28632-unreachable-executed-at-swift-lib-ast-type-cpp-1130.swift b/validation-test/compiler_crashers_fixed/28632-unreachable-executed-at-swift-lib-ast-type-cpp-1130.swift
index 7cf03a0..076f523 100644
--- a/validation-test/compiler_crashers_fixed/28632-unreachable-executed-at-swift-lib-ast-type-cpp-1130.swift
+++ b/validation-test/compiler_crashers_fixed/28632-unreachable-executed-at-swift-lib-ast-type-cpp-1130.swift
@@ -5,8 +5,6 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: asserts
 // RUN: not %target-swift-frontend %s -emit-ir
-
 {func a>
 print(a==#keyPath(a{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
diff --git a/validation-test/compiler_crashers/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift b/validation-test/compiler_crashers_fixed/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
similarity index 80%
rename from validation-test/compiler_crashers/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
rename to validation-test/compiler_crashers_fixed/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
index 90f0648..7f38b0d 100644
--- a/validation-test/compiler_crashers/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
+++ b/validation-test/compiler_crashers_fixed/28633-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 guard let f===#keyPath(n&_=#keyPath(a
diff --git a/validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift b/validation-test/compiler_crashers_fixed/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift
similarity index 74%
copy from validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
copy to validation-test/compiler_crashers_fixed/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift
index d1c111c..2f412e2 100644
--- a/validation-test/compiler_crashers/28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
+++ b/validation-test/compiler_crashers_fixed/28634-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-T>[print{$0{
+// RUN: not %target-swift-frontend %s -emit-ir
+let E=_==#keyPath(n&_=b:{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
diff --git a/validation-test/compiler_crashers/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift b/validation-test/compiler_crashers_fixed/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
similarity index 80%
rename from validation-test/compiler_crashers/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
rename to validation-test/compiler_crashers_fixed/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
index a4a6cbc..bf5b7b5 100644
--- a/validation-test/compiler_crashers/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
+++ b/validation-test/compiler_crashers_fixed/28637-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
@@ -5,8 +5,7 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 print(Integer
 print(
 #keyPath(n&_=d
diff --git a/validation-test/compiler_crashers_fixed/28641-result-case-not-implemented.swift b/validation-test/compiler_crashers_fixed/28641-result-case-not-implemented.swift
index d3370b0..cc8212d 100644
--- a/validation-test/compiler_crashers_fixed/28641-result-case-not-implemented.swift
+++ b/validation-test/compiler_crashers_fixed/28641-result-case-not-implemented.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: asserts
 // RUN: not %target-swift-frontend %s -emit-ir
 {let β=b&[{{{#keyPath(n&[{{{{{{{{{{{{{{{{{{{{{{{{{{a{{{{s
diff --git a/validation-test/compiler_crashers/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift b/validation-test/compiler_crashers_fixed/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
similarity index 81%
rename from validation-test/compiler_crashers/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
rename to validation-test/compiler_crashers_fixed/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
index af242e6..5d7ed11 100644
--- a/validation-test/compiler_crashers/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
+++ b/validation-test/compiler_crashers_fixed/28643-swift-tupletype-get-llvm-arrayref-swift-tupletypeelt-swift-astcontext-const.swift
@@ -5,8 +5,7 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 H
 print(_==(
 #keyPath(n&_=b{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
diff --git a/validation-test/compiler_crashers/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift b/validation-test/compiler_crashers_fixed/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift
similarity index 80%
rename from validation-test/compiler_crashers/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift
rename to validation-test/compiler_crashers_fixed/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift
index 03e377b..5a39469 100644
--- a/validation-test/compiler_crashers/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift
+++ b/validation-test/compiler_crashers_fixed/28644-swift-functiontype-get-swift-type-swift-type-swift-anyfunctiontype-extinfo-const.swift
@@ -5,6 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// REQUIRES: deterministic-behavior
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 [.h=_==Array(#keyPath(t