Merge pull request #166 from ddunbar/db-version-bump

[Core] Bump DB schema version.
diff --git a/lib/Ninja/Lexer.cpp b/lib/Ninja/Lexer.cpp
index 4f58522..bd52509 100644
--- a/lib/Ninja/Lexer.cpp
+++ b/lib/Ninja/Lexer.cpp
@@ -297,8 +297,10 @@
   }
 
   case '|': {
-    if (peekNextChar() == '|')
-      return getNextChar(), setTokenKind(result, Token::Kind::PipePipe);
+    if (peekNextChar() == '|') {
+      (void) getNextChar();
+      return setTokenKind(result, Token::Kind::PipePipe);
+    }
     return setTokenKind(result, Token::Kind::Pipe);
   }
 
diff --git a/llbuild.xcodeproj/project.pbxproj b/llbuild.xcodeproj/project.pbxproj
index bb99339..5601958 100644
--- a/llbuild.xcodeproj/project.pbxproj
+++ b/llbuild.xcodeproj/project.pbxproj
@@ -3312,14 +3312,19 @@
 				CLANG_ENABLE_CODE_COVERAGE = "$(LLBUILD_ENABLE_CODE_COVERAGE)";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -3368,14 +3373,19 @@
 				CLANG_ENABLE_CODE_COVERAGE = "$(LLBUILD_ENABLE_CODE_COVERAGE)";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -3619,6 +3629,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ENABLE_CODE_COVERAGE = NO;
+				CLANG_WARN_COMMA = NO;
 				HEADER_SEARCH_PATHS = "$(SRCROOT)/include";
 			};
 			name = Debug;
@@ -3627,6 +3638,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ENABLE_CODE_COVERAGE = NO;
+				CLANG_WARN_COMMA = NO;
 				HEADER_SEARCH_PATHS = "$(SRCROOT)/include";
 			};
 			name = Release;
diff --git a/llbuild.xcodeproj/xcshareddata/xcschemes/PerfTests.xcscheme b/llbuild.xcodeproj/xcshareddata/xcschemes/PerfTests.xcscheme
index 798206d..b76917d 100644
--- a/llbuild.xcodeproj/xcshareddata/xcschemes/PerfTests.xcscheme
+++ b/llbuild.xcodeproj/xcshareddata/xcschemes/PerfTests.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git "a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild \050external tests\051.xcscheme" "b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild \050external tests\051.xcscheme"
index 3d88010..ff8169c 100644
--- "a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild \050external tests\051.xcscheme"
+++ "b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild \050external tests\051.xcscheme"
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-Bot.xcscheme b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-Bot.xcscheme
index 84876fd..eb37768 100644
--- a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-Bot.xcscheme
+++ b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-Bot.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-asan-Bot.xcscheme b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-asan-Bot.xcscheme
index 9b21e87..5606808 100644
--- a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-asan-Bot.xcscheme
+++ b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-asan-Bot.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -26,9 +26,9 @@
       buildConfiguration = "Release"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      enableAddressSanitizer = "YES"
       shouldUseLaunchSchemeArgsEnv = "YES"
-      codeCoverageEnabled = "YES"
-      enableAddressSanitizer = "YES">
+      codeCoverageEnabled = "YES">
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -57,11 +57,11 @@
       buildConfiguration = "Release"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      enableAddressSanitizer = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"
       debugDocumentVersioning = "YES"
-      enableAddressSanitizer = "YES"
       debugServiceExtension = "internal"
       allowLocationSimulation = "YES">
       <MacroExpansion>
diff --git a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-perf-Bot.xcscheme b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-perf-Bot.xcscheme
index fe1cfc9..563701c 100644
--- a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-perf-Bot.xcscheme
+++ b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild-perf-Bot.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild.xcscheme b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild.xcscheme
index a525787..f968444 100644
--- a/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild.xcscheme
+++ b/llbuild.xcodeproj/xcshareddata/xcschemes/llbuild.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "9900"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
diff --git a/unittests/BuildSystem/BuildSystemTaskTests.cpp b/unittests/BuildSystem/BuildSystemTaskTests.cpp
index f8fd3b6..5d9ee9f 100644
--- a/unittests/BuildSystem/BuildSystemTaskTests.cpp
+++ b/unittests/BuildSystem/BuildSystemTaskTests.cpp
@@ -262,6 +262,8 @@
 
 /// Check that cancellation applies to enqueued jobs.
 TEST(BuildSystemTaskTests, cancelAllInQueue) {
+// Disabled: <rdar://problem/32142112> BuildSystem/BuildSystemTests/BuildSystemTaskTests.cancelAllInQueue FAILED
+#ifdef false
   TmpDir tempDir{ __FUNCTION__ };
 
   SmallString<256> manifest{ tempDir.str() };
@@ -322,6 +324,7 @@
           "commandStarted(C1)",
           "commandFinished(C1)",
           }), delegate.getMessages());
+#endif
 }
 
 // Tests the behaviour of StaleFileRemovalTool