commit 51f7aba0dc814295209af377bcec58ed3c5782d5
author Alex Lorenz <arphaman@gmail.com> Mon May 15 10:20:39 2017 +0000
committer Alex Lorenz <arphaman@gmail.com> Mon May 15 11:37:18 2017 +0100
tree 7a13fda4a38133b056baac783ec41a1c24abef3f
parent 28984a7879463e04ba9698edc85a51d232cc1ec5

[index] Avoid a crash that happens when looking up a dependent name
in a record that has no definition

rdar://32194921

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@303045 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 7c14490d8a1bffaff51996c6c0619242f35725fa)

lib/Index/IndexBody.cpp

diff --git a/lib/Index/IndexBody.cpp b/lib/Index/IndexBody.cpp
index 9439c11..08d233f 100644
--- a/lib/Index/IndexBody.cpp
+++ b/lib/Index/IndexBody.cpp
@@ -165,6 +165,9 @@
     if (!TD)
       return true;
     CXXRecordDecl *RD = TD->getTemplatedDecl();
+    if (!RD->hasDefinition())
+      return true;
+    RD = RD->getDefinition();
     std::vector<const NamedDecl *> Symbols =
         RD->lookupDependentName(NameInfo.getName(), Filter);
     // FIXME: Improve overload handling.

lib/Index/IndexTypeSourceInfo.cpp

diff --git a/lib/Index/IndexTypeSourceInfo.cpp b/lib/Index/IndexTypeSourceInfo.cpp
index 7e2041c..e9ca651 100644
--- a/lib/Index/IndexTypeSourceInfo.cpp
+++ b/lib/Index/IndexTypeSourceInfo.cpp
@@ -157,6 +157,9 @@
     if (!TD)
       return true;
     CXXRecordDecl *RD = TD->getTemplatedDecl();
+    if (!RD->hasDefinition())
+      return true;
+    RD = RD->getDefinition();
     DeclarationName Name(DNT->getIdentifier());
     std::vector<const NamedDecl *> Symbols = RD->lookupDependentName(
         Name, [](const NamedDecl *ND) { return isa<TypeDecl>(ND); });

test/Index/Core/index-dependent-source.cpp

diff --git a/test/Index/Core/index-dependent-source.cpp b/test/Index/Core/index-dependent-source.cpp
index 35f5cf4..2541079 100644
--- a/test/Index/Core/index-dependent-source.cpp
+++ b/test/Index/Core/index-dependent-source.cpp
@@ -122,3 +122,12 @@
   object.overload1(Y());
 // CHECK-NOT: [[@LINE-1]]
 }
+
+template<typename T> struct UndefinedTemplateClass;
+
+template<typename T>
+void undefinedTemplateLookup(UndefinedTemplateClass<T> &x) {
+// Shouldn't crash!
+  x.lookup;
+  typename UndefinedTemplateClass<T>::Type y;
+}