| commit | 3ce89dad5bc324dad9c4b77393e16f3bcb7396a7 | [log] [tgz] |
|---|---|---|
| author | liyuqian <liyuqian@google.com> | Wed Nov 09 08:53:39 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Nov 09 08:53:39 2016 -0800 |
| tree | 41f24f9127f416216825c01cca510e7abc24a34c | |
| parent | e4fd0780ec279845ea98e18899f03d939b01db16 [diff] |
Fix the meaning of stop_y stop_y means that we should stop exactly at stop_y, so the last row should be [stop_y - 1, stop_y], not [stop_y, stop_y + 1]. Somehow this misunderstanding didn't trigger any issue until Chrome exercises SkAAClip with some websites (e.g., http://www.lemonde.fr/elections-americaines/article/2016/11/07/deux-programmes-deux-visions-de-l-amerique_5026444_829254.html). When we blitter the extra row [stop_y, stop_y + 1], the SkAAClip will return nullptr by findRow. Later when that nullptr row is used to findX, the crash happened. BUG=chromium:662925, chromium:662776 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2481703004 Review-Url: https://codereview.chromium.org/2481703004