Google Git
Sign in
fuchsia / third_party / rust / e3d2831ff4fb15520d21856c91c2d9233724bdd5
commite3d2831ff4fb15520d21856c91c2d9233724bdd5[log] [tgz]
authorbors <bors@rust-lang.org>Wed Dec 13 08:33:05 2023 +0000
committerbors <bors@rust-lang.org>Wed Dec 13 08:33:05 2023 +0000
tree000c8cea35c2f47ef6c780f48cc76d65e4d784ea
parentb5c0dd6da2c7388b0a1ae60632f7acd81a9ccd40 [diff]
parentaa3dc4c2253540b3c30143f7bfe59ab44bcafec0 [diff]
Auto merge of #118534 - RalfJung:extern-type-size-of-val, r=WaffleLapkin

codegen: panic when trying to compute size/align of extern type

The alignment is also computed when accessing a field of extern type at non-zero offset, so we also panic in that case.

Previously `size_of_val` worked because the code path there assumed that "thin pointer" means "sized". But that's not true any more with extern types. The returned size and align are just blatantly wrong, so it seems better to panic than returning wrong results. We use a non-unwinding panic since code probably does not expect size_of_val to panic.
tree: 000c8cea35c2f47ef6c780f48cc76d65e4d784ea
  1. .github/
  2. .vscode/
  3. build_system/
  4. docs/
  5. example/
  6. patches/
  7. scripts/
  8. src/
  9. .cirrus.yml
  10. .gitattributes
  11. .gitignore
  12. Cargo.lock
  13. Cargo.toml
  14. clean_all.sh
  15. config.txt
  16. LICENSE-APACHE
  17. LICENSE-MIT
  18. Readme.md
  19. rust-toolchain
  20. rustfmt.toml
  21. test.sh
  22. y.rs
  23. y.sh
Readme.md

Cranelift codegen backend for rust

The goal of this project is to create an alternative codegen backend for the rust compiler based on Cranelift. This has the potential to improve compilation times in debug mode. If your project doesn't use any of the things listed under “Not yet supported”, it should work fine. If not please open an issue.

Download using Rustup

The Cranelift codegen backend is distributed in nightly builds on Linux and x86_64 macOS. If you want to install it using Rustup, you can do that by running:

$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly

Once it is installed, you can enable it with one of the following approaches:

  • CARGO_PROFILE_DEV_CODEGEN_BACKEND=cranelift cargo +nightly build -Zcodegen-backend
  • RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
  • Add the following to .cargo/config.toml:
    [unstable]
codegen-backend = true

[profile.dev]
codegen-backend = "cranelift"
  • Add the following to Cargo.toml:
    # This line needs to come before anything else in Cargo.toml
cargo-features = ["codegen-backend"]

[profile.dev]
codegen-backend = "cranelift"

Precompiled builds

You can also download a pre-built version from the releases page. Extract the dist directory in the archive anywhere you want. If you want to use cargo clif build instead of having to specify the full path to the cargo-clif executable, you can add the bin subdirectory of the extracted dist directory to your PATH. (tutorial for Windows, and for Linux/MacOS).

Building and testing

If you want to build the backend manually, you can download it from GitHub and build it yourself:

$ git clone https://github.com/rust-lang/rustc_codegen_cranelift
$ cd rustc_codegen_cranelift
$ ./y.sh prepare
$ ./y.sh build

To run the test suite replace the last command with:

$ ./test.sh

For more docs on how to build and test see build_system/usage.txt or the help message of ./y.sh.

Usage

rustc_codegen_cranelift can be used as a near-drop-in replacement for cargo build or cargo run for existing projects.

Assuming $cg_clif_dir is the directory you cloned this repo into and you followed the instructions (y.sh prepare and y.sh build or test.sh).

In the directory with your project (where you can do the usual cargo build), run:

$ $cg_clif_dir/dist/cargo-clif build

This will build your project with rustc_codegen_cranelift instead of the usual LLVM backend.

For additional ways to use rustc_codegen_cranelift like the JIT mode see usage.md.

Building and testing with changes in rustc code

This is useful when changing code in rustc_codegen_cranelift as part of changing main Rust repository. This can happen, for example, when you are implementing a new compiler intrinsic.

Instruction below uses $RustCheckoutDir as substitute for any folder where you cloned Rust repository.

You need to do this steps to successfully compile and use the cranelift backend with your changes in rustc code:

  1. cd $RustCheckoutDir
  2. Run python x.py setup and choose option for compiler (b).
  3. Build compiler and necessary tools: python x.py build --stage=2 compiler library/std src/tools/rustdoc src/tools/rustfmt
    • (Optional) You can also build cargo by adding src/tools/cargo to previous command.
  4. Copy cargo from a nightly toolchain: cp $(rustup +nightly which cargo) ./build/host/stage2/bin/cargo. Note that you would need to do this every time you rebuilt rust repository.
  5. Link your new rustc to toolchain: rustup toolchain link stage2 ./build/host/stage2/.
  6. (Windows only) compile the build system: rustc +stage2 -O build_system/main.rs -o y.exe.
  7. You need to prefix every ./y.sh (or y if you built build_system/main.rs as y) command by rustup run stage2 to make cg_clif use your local changes in rustc.
  • rustup run stage2 ./y.sh prepare
  • rustup run stage2 ./y.sh build
  • (Optional) run tests: rustup run stage2 ./y.sh test
  1. Now you can use your cg_clif build to compile other Rust programs, e.g. you can open any Rust crate and run commands like $RustCheckoutDir/compiler/rustc_codegen_cranelift/dist/cargo-clif build --release.

Configuration

See the documentation on the BackendConfig struct in config.rs for all configuration options.

Not yet supported

License

Licensed under either of

at your option.

Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you shall be dual licensed as above, without any additional terms or conditions.