commit 3da6e061ca6c1449323dfbb23f39775e92cef63b
author Paul Wankadia <junyer@google.com> Mon Jul 18 16:26:09 2016 +1000
committer Paul Wankadia <junyer@google.com> Mon Jul 18 06:29:30 2016 +0000
tree 6b02bed264765ecc5bd306c08433b538b14e329d
parent bb58143e6b3196ccb8a3115d86a0dc73d9bceb3b

Oops, we can't just delete the State* here.

Change-Id: I3bfcbb82a618e658faef098d45c95d65ff3331bd
Reviewed-on: https://code-review.googlesource.com/5256
Reviewed-by: Paul Wankadia <junyer@google.com>

re2/dfa.cc

diff --git a/re2/dfa.cc b/re2/dfa.cc
index ea86d27..0cc58a1 100644
--- a/re2/dfa.cc
+++ b/re2/dfa.cc
@@ -752,7 +752,8 @@
   while (begin != end) {
     StateSet::iterator tmp = begin;
     ++begin;
-    delete *tmp;
+    // Deallocate the blob of memory that we allocated in DFA::CachedState().
+    delete[] reinterpret_cast<const char*>(*tmp);
   }
   state_cache_.clear();
 }