Revert "[build][clang] Ignore -Wnan-infinity-disabled in third_party code"
This reverts commit ee14808888a4b0def21bf5a4c8e99762897b5828.
Reason for revert: More complete workarounds for -Wnan-infinity-disabled have landed across Fuchsia, and disabling the warning here was not effective, since this is a header-only library. Additionally, since a new toolchain has rolled, if there is an incompatibility, or this change was, in fact, significant, the CI builders will detect the regression and we can fix them appropriately instead of by disabling a compiler diagnostic.
Original change's description:
> [build][clang] Ignore -Wnan-infinity-disabled in third_party code
>
> Upstream LLVM added a stricter warning for using infinity w/ floating
> point code. This patch disables the new warning in
> third_party/rapidsjson, which is the only library that uses this
> feature in //third_party.
>
> Bug: 324137521
> Change-Id: I5280c78613253bdd356d1b5790b5f5ca22d17e0b
> Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/rapidjson/+/986784
> Reviewed-by: Corey Tabaka <eieio@google.com>
> Commit-Queue: Paul Kirth <paulkirth@google.com>
Fixed: 324137521
Change-Id: I4c56ae422f740d0eb3899149907855ede3c027a9
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/rapidjson/+/988382
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Fuchsia-Auto-Submit: Paul Kirth <paulkirth@google.com>
diff --git a/BUILD.gn b/BUILD.gn
index 073eab9..9ca5323 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -42,9 +42,6 @@
cflags = [
"-Wno-ambiguous-reversed-operator",
- #TODO(fxb/324137521): Remove the Wno-unknown-warning-option after clang roll
- "-Wno-unknown-warning-option",
- "-Wno-nan-infinity-disabled",
"-Wno-option-ignored",
"-fPIC",
]
