commit 676d99db96e2108724e62342a47e28c8e991ed3b
author Gilles Vollant <info@winimage.com> Tue Dec 19 13:08:05 2023 +0100
committer Milo Yip <miloyip@gmail.com> Fri Mar 08 10:17:06 2024 +0800
tree e4f4cfa9e7002e59e8bd283124e7c555a1a2f8cc
parent 68afb49287fe1837ff138c3e7f77d25514ae2749

fix Visual Studio 2022 (using /std:c++20) warning warning C5232: in C++20 this comparison calls ... recursively

include/rapidjson/document.h

diff --git a/include/rapidjson/document.h b/include/rapidjson/document.h
index 2cd9a70..f183749 100644
--- a/include/rapidjson/document.h
+++ b/include/rapidjson/document.h
@@ -1033,7 +1033,7 @@
                 return false;           
             for (ConstMemberIterator lhsMemberItr = MemberBegin(); lhsMemberItr != MemberEnd(); ++lhsMemberItr) {
                 typename RhsType::ConstMemberIterator rhsMemberItr = rhs.FindMember(lhsMemberItr->name);
-                if (rhsMemberItr == rhs.MemberEnd() || lhsMemberItr->value != rhsMemberItr->value)
+                if (rhsMemberItr == rhs.MemberEnd() || (!(lhsMemberItr->value == rhsMemberItr->value)))
                     return false;
             }
             return true;
@@ -1042,7 +1042,7 @@
             if (data_.a.size != rhs.data_.a.size)
                 return false;
             for (SizeType i = 0; i < data_.a.size; i++)
-                if ((*this)[i] != rhs[i])
+                if (!((*this)[i] == rhs[i]))
                     return false;
             return true;