commit c70221df1f89953e85a3f1f96ceefbd6888bb55f
author Kevin Wolf <kwolf@redhat.com> Wed Feb 11 17:19:57 2015 +0100
committer Michael Roth <mdroth@linux.vnet.ibm.com> Sun Mar 08 22:58:14 2015 -0500
tree ef6376d06edddfca6a66f26646d30381a7cdf1d3
parent 07db6859abffa79db6290a5f9f4dfdf93148189f

vpc: Fix size in fixed image creation

If total_sectors is rounded to match the geometry, total_size needs to
be changed as well. Otherwise we end up with an image whose geometry
describes a disk larger than the image file, which doesn't end well.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
(cherry picked from commit c7dd631d482912fd615a9ef18a0e0691e7a84836)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

block/vpc.c

diff --git a/block/vpc.c b/block/vpc.c
index 38c4f02..40baa64 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -801,6 +801,7 @@
     }
 
     total_sectors = (int64_t) cyls * heads * secs_per_cyl;
+    total_size = total_sectors * BDRV_SECTOR_SIZE;
 
     /* Prepare the Hard Disk Footer */
     memset(buf, 0, 1024);
@@ -822,13 +823,8 @@
     /* Version of Virtual PC 2007 */
     footer->major = cpu_to_be16(0x0005);
     footer->minor = cpu_to_be16(0x0003);
-    if (disk_type == VHD_DYNAMIC) {
-        footer->orig_size = cpu_to_be64(total_sectors * 512);
-        footer->size = cpu_to_be64(total_sectors * 512);
-    } else {
-        footer->orig_size = cpu_to_be64(total_size);
-        footer->size = cpu_to_be64(total_size);
-    }
+    footer->orig_size = cpu_to_be64(total_size);
+    footer->size = cpu_to_be64(total_size);
     footer->cyls = cpu_to_be16(cyls);
     footer->heads = heads;
     footer->secs_per_cyl = secs_per_cyl;