commit 7f5d9b206d1e86425faa5b84b551068bf044b823
author Paolo Bonzini <pbonzini@redhat.com> Thu Mar 26 10:41:21 2020 +0100
committer Paolo Bonzini <pbonzini@redhat.com> Thu Apr 02 14:56:10 2020 -0400
tree ff9185f720d36830ce74909068f0a17d2c2dd586
parent b3fbb328123575e5b39e35e13ecbd4927569a82b

object-add: don't create return value if failed

No need to return an empty value from object-add (it would also leak
if the command failed).  While at it, remove the "if" around object_unref
since object_unref handles NULL arguments just fine.

Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200325184723.2029630-4-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

qom/qom-qmp-cmds.c

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 435193b..e47ebe8 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -285,10 +285,7 @@
     v = qobject_input_visitor_new(QOBJECT(qdict));
     obj = user_creatable_add_type(type, id, qdict, v, errp);
     visit_free(v);
-    if (obj) {
-        object_unref(obj);
-    }
-    *ret_data = QOBJECT(qdict_new());
+    object_unref(obj);
 }
 
 void qmp_object_del(const char *id, Error **errp)