commit 2b720018060179b394f8ce736983373ab80dd37c
author Laszlo Ersek <lersek@redhat.com> Wed May 08 17:31:36 2013 +0200
committer Michael Roth <mdroth@linux.vnet.ibm.com> Mon May 13 09:45:49 2013 -0500
tree a04a2bf21b4289a6d6945223663e073eb49e572d
parent 8fe6bbca7176c9dfb35083a71bda95c1856e2ed5

qga: unlink just created guest-file if fchmod() or fdopen() fails on it

We shouldn't allow guest filesystem pollution on error paths.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

qga/commands-posix.c

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 2eec712..e199738 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -355,6 +355,9 @@
             }
 
             close(fd);
+            if (oflag & O_CREAT) {
+                unlink(path);
+            }
         }
     }