commit 0cd40042c53a78057f4811379207ad9f141af703
author Anthony PERARD <anthony.perard@citrix.com> Mon Apr 06 17:42:07 2020 +0100
committer Anthony PERARD <anthony.perard@citrix.com> Tue Apr 07 16:13:26 2020 +0100
tree 0765177ae22984277c5161156c43a12cb9c7bede
parent 1aef27c93d351cf6235dbc06d112f626a9aaeba6

xen-block: Fix uninitialized variable

Since 7f5d9b206d1e ("object-add: don't create return value if
failed"), qmp_object_add() don't write any value in 'ret_data', thus
has random data. Then qobject_unref() fails and abort().

Fix by initialising 'ret_data' properly.

Fixes: 5f07c4d60d09 ("qapi: Flatten object-add")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200406164207.1446817-1-anthony.perard@citrix.com>

hw/block/xen-block.c

diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 07bb32e..99cb4c6 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -860,7 +860,7 @@
     XenBlockIOThread *iothread = g_new(XenBlockIOThread, 1);
     Error *local_err = NULL;
     QDict *opts;
-    QObject *ret_data;
+    QObject *ret_data = NULL;
 
     iothread->id = g_strdup(id);