commit 1eb9d057b991005590448d36b12d70a881def1ad
author Jeff Muizelaar <jmuizelaar@mozilla.com> Thu Jun 25 09:31:56 2009 -0400
committer Jeff Muizelaar <jmuizelaar@mozilla.com> Thu Jul 02 11:22:38 2009 -0400
tree befa466057106f904e6fd05cf0b117aebdea4067
parent d2f6ba16c87084f954a19052732271dd8c627427

Check that the profile is an RGB profile before checking if it's bogus

This avoids unitialized reads on non-RGB profiles.

iccread.c

diff --git a/iccread.c b/iccread.c
index e9a6eac..f3886e0 100644
--- a/iccread.c
+++ b/iccread.c
@@ -227,6 +227,10 @@
        bool negative;
        unsigned i;
 
+       // We currently only check the bogosity of RGB profiles
+       if (profile->color_space != RGB_SIGNATURE)
+	       return false;
+
        rX = s15Fixed16Number_to_float(profile->redColorant.X);
        rY = s15Fixed16Number_to_float(profile->redColorant.Y);
        rZ = s15Fixed16Number_to_float(profile->redColorant.Z);