commit 1c5e8cbb8fedafbb45f62d28d9d4ff2362168601
author Keith Smiley <keithbsmiley@gmail.com> Wed Apr 10 11:08:59 2019 -0700
committer Adam Cozzette <acozzette@google.com> Tue Apr 16 09:49:59 2019 -0700
tree c602b6f2befbef7dfc79d9ef5bdb827f66a2c7e0
parent 1958925c76ca38945bad19659da7e098bdf017d9

Remove -Wall from default build options

All bazel crosstools automatically pass -Wall to compiles. The order of
operations is:

- bazel crosstool flags
- `--host_copt` flags and other variations like `--host_cxxopt`
- the `copts` defined on the rule

Because of this when protobuf produces warnings, there's no way to
disable them from the consumer side if they are re-enabled later by
another `-Wall` flag.

BUILD

diff --git a/BUILD b/BUILD
index 1961cc4..2fb2605 100644
--- a/BUILD
+++ b/BUILD
@@ -49,7 +49,6 @@
     "//conditions:default": [
         "-DHAVE_PTHREAD",
         "-DHAVE_ZLIB",
-        "-Wall",
         "-Woverloaded-virtual",
         "-Wno-sign-compare",
         "-Wno-unused-function",