small fixes suggested in code review
needless use of empty byte slice (left over from earlier work)
plus a couple tweaks to tests/asserts
thanks @puellanivis for the review
diff --git a/request-example.go b/request-example.go
index a72410d..ddc85aa 100644
--- a/request-example.go
+++ b/request-example.go
@@ -214,7 +214,6 @@
name: name,
modtime: time.Now(),
isdir: isdir,
- content: []byte(""),
}
}
diff --git a/request-server_test.go b/request-server_test.go
index 63e6954..cb476b0 100644
--- a/request-server_test.go
+++ b/request-server_test.go
@@ -147,7 +147,7 @@
f, err := r.fetch("/foo")
if assert.Nil(t, err) {
assert.False(t, f.isdir)
- assert.Equal(t, []byte(""), f.content)
+ assert.Len(t, f.content, 0)
}
// lets test with an error
r.returnErr(os.ErrInvalid)
@@ -351,8 +351,8 @@
for i := 0; i < 100; i++ {
fname := fmt.Sprintf("/foo_%02d", i)
_, err := putTestFile(p.cli, fname, fname)
- if !assert.NoError(t, err) {
- t.Fatal(err)
+ if err != nil {
+ t.Fatal("expected no error, got:", err)
}
}
_, err := p.cli.ReadDir("/foo_01")
