commit 514510414321a18d201db5ebb6f179ba677fddf5
author yunhanw <yunhanw@google.com> Mon Dec 09 22:29:41 2019 -0800
committer yunhanw <yunhanw@google.com> Mon Dec 09 22:33:29 2019 -0800
tree aeb2dc7d721fde7fdaf09a9dddd7ff08f223210f
parent 08759671dd6f1213227b4fa631f6dbfa7cf7452b

HasPeerRequestedAck needs to be checked when doing SendSubscribeResponse

--After binding from connection has been created and running
SendSubscribeResponse, it needs to check HasPeerRequestedAck()
to send message.

src/lib/profiles/data-management/Current/SubscriptionHandler.cpp

diff --git a/src/lib/profiles/data-management/Current/SubscriptionHandler.cpp b/src/lib/profiles/data-management/Current/SubscriptionHandler.cpp
index f0de69f..05f9f92 100644
--- a/src/lib/profiles/data-management/Current/SubscriptionHandler.cpp
+++ b/src/lib/profiles/data-management/Current/SubscriptionHandler.cpp
@@ -863,7 +863,7 @@
 
     // Note we're sending back a message using an EC initiated by the client
     err    = mEC->SendMessage(nl::Weave::Profiles::kWeaveProfile_WDM, kMsgType_SubscribeResponse, msgBuf,
-                           nl::Weave::ExchangeContext::kSendFlag_RequestAck);
+                           mEC->HasPeerRequestedAck() ? nl::Weave::ExchangeContext::kSendFlag_RequestAck : 0);
     msgBuf = NULL;
     SuccessOrExit(err);